[HOLD for payment 2024-05-29] [Wave Collect] [Ideal nav] Simplify the navigator structure

[mountiny]

Follow up to the ideal navigation project, we have one task to simplify the structure now.

Problem

Currently, central pane screens in FullScreenNavigator are wrapped with the central pane navigator. A similar pattern can be seen in LHP where single screens are wrapped with navigators.
This may be problematic for two reasons:

• Getting information about the actual screen requires more code. It has become visible especially after we migrated to typescript. Instead of just getting the route name we have to extract the route from the state or params of the parent navigator.
• More nested navigators means worse performance.

Solution

In the early implementation of navigation, we used the custom component ThreePaneView. That was the main reason to encapsulate screens with central pane navigators. Now we use StackView for both narrow and wide layouts and the wide layout is achieved using styles.

This allows us to flatten the navigation structure. Now screens in FullScreenNavigator and LHP will be mounted directly
This way developing and maintaining navigation should be easier and we should get a slight performance boost.

cc @adamgrzybowski @WojtekBoman

[melvin-bot]

Triggered auto assignment to @stephanieelliott (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details. Please add this Feature request to a GH project, as outlined in the SO.

[WojtekBoman]

Hi! I'm working on that :)

[melvin-bot]

Triggered auto assignment to @strepanier03 (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details. Please add this Feature request to a GH project, as outlined in the SO.

[stephanieelliott]

Reapplying the New Feature label to get another BZ member on this while I am OOO til May 2. Thanks @strepanier03, I'll grab this back from you when I return!

[stephanieelliott]

I'm back from OOO, thanks for watching this while I was out @strepanier03!

Hey @WojtekBoman, any update on when this PR will be taken out of the Draft state?

[stephanieelliott]

Hey @WojtekBoman, any update on when this PR will be taken out of the Draft state?

Bump on this @WojtekBoman, how is the PR coming?

[WojtekBoman]

Hi @stephanieelliott,

I'm currently working on the new search tab as it has higher priority. I think I'll have some time to release a PR this/next week.

[stephanieelliott]

Makes sense, thanks for the update @WojtekBoman!

[stephanieelliott]

Hey @WojtekBoman, any update on this?

[mountiny]

This was merged and deployed to staging, awaiting production deploy

[stephanieelliott]

This was deployed to prod on May 22! Will be ready for payment on May 29

[mountiny]

@ahmedGaber93 is the only person required payment of $250 on this issue

No regression testing required

[melvin-bot]

Payment Summary

Upwork Job

• ROLE: @ahmedGaber93 paid $500 via Upwork (LINK)
• Contributor: @WojtekBoman is from an agency-contributor and not due payment

BugZero Checklist (@stephanieelliott)

• I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
• I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
• I have paid out the Upwork contracts or cancelled the ones that are incorrect
• I have verified the payment summary above is correct

[stephanieelliott]

I had to manually create a job on Upwork for this

• Upwork Job
• Offer for @ahmedGaber93: https://www.upwork.com/nx/wm/offer/102533846

@ahmedGaber93 please let me know when you've accepted the offer so I can issue payment!

[ahmedGaber93]

@stephanieelliott Offer accepted. Thanks!

[stephanieelliott]

Thanks @ahmedGaber93, all paid!