Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2024-07-10] [$250] Simplify the RootNavigator structure #42507

Closed
mountiny opened this issue May 23, 2024 · 28 comments
Closed
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 External Added to denote the issue can be worked on by a contributor NewFeature Something to build that is a new item.

Comments

@mountiny
Copy link
Contributor

mountiny commented May 23, 2024

Follow up to the ideal navigation project, we have one task to simplify the structure now.

Problem

The problem is the same as described in this issue but for the RootNavigator.
Currently, central pane screens in RootNavigator are wrapped with the central pane navigator. This may be problematic for two reasons:

  • Getting information about the actual screen requires more code. It has become visible especially after we migrated to typescript, instead of just getting the route name we have to extract the route from the state or params of the parent navigator.
  • More nested navigators mean worse performance.

Solution

In the early implementation of navigation, we used the custom component ThreePaneView. That was the main reason to encapsulate screens with central pane navigators. Now we use StackView for both narrow and wide layouts and the wide layout is achieved using styles.

This allows us to flatten the navigation structure. Now screens from CentralPaneNavigator will be mounted directly in the RootNavigator

This way developing and maintaining navigation should be easier and we should get a slight performance boost.
cc @adamgrzybowski @WojtekBoman

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01e857cb7b9e57642a
  • Upwork Job ID: 1793573481726357504
  • Last Price Increase: 2024-05-23
  • Automatic offers:
    • hoangzinh | Reviewer | 102432432
Issue OwnerCurrent Issue Owner: @JmillsExpensify
@mountiny mountiny added Daily KSv2 NewFeature Something to build that is a new item. labels May 23, 2024
@mountiny mountiny self-assigned this May 23, 2024
Copy link

melvin-bot bot commented May 23, 2024

Triggered auto assignment to @JmillsExpensify (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details. Please add this Feature request to a GH project, as outlined in the SO.

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Daily KSv2 labels May 23, 2024
@mountiny mountiny added the External Added to denote the issue can be worked on by a contributor label May 23, 2024
@melvin-bot melvin-bot bot changed the title Simplify the RootNavigator structure [$250] Simplify the RootNavigator structure May 23, 2024
Copy link

melvin-bot bot commented May 23, 2024

Job added to Upwork: https://www.upwork.com/jobs/~01e857cb7b9e57642a

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label May 23, 2024
Copy link

melvin-bot bot commented May 23, 2024

Triggered auto assignment to Contributor-plus team member for initial proposal review - @hoangzinh (External)

@melvin-bot melvin-bot bot added the Daily KSv2 label May 23, 2024
@mountiny mountiny removed Daily KSv2 Help Wanted Apply this label when an issue is open to proposals by contributors labels May 23, 2024
@melvin-bot melvin-bot bot removed the Weekly KSv2 label May 23, 2024
@adamgrzybowski
Copy link
Contributor

@WojtekBoman, @Kicu or I will take care of it

@WojtekBoman
Copy link
Contributor

Hi! I'm working on it :)

Copy link

melvin-bot bot commented May 23, 2024

📣 @hoangzinh 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

Copy link

melvin-bot bot commented May 23, 2024

📣 @hoangzinh 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

Copy link

melvin-bot bot commented May 28, 2024

@JmillsExpensify, @hoangzinh, @mountiny, @WojtekBoman, @adamgrzybowski Eep! 4 days overdue now. Issues have feelings too...

@melvin-bot melvin-bot bot added the Overdue label May 28, 2024
@mountiny
Copy link
Contributor Author

The PR is still in draft

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Daily KSv2 labels Jun 4, 2024
@WojtekBoman
Copy link
Contributor

same as above. @WojtekBoman there have been no new git commits/comments since last week. Do you have any updates on the PR? any blockers. Thanks

The PR is ready for review, there is one unit tests pipeline that is failing, I'm currently investigating it, but besides that everything is ready

Copy link

melvin-bot bot commented Jun 26, 2024

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

@melvin-bot melvin-bot bot added Monthly KSv2 and removed Weekly KSv2 labels Jun 27, 2024
Copy link

melvin-bot bot commented Jun 27, 2024

This issue has not been updated in over 15 days. @JmillsExpensify, @hoangzinh, @mountiny, @WojtekBoman, @adamgrzybowski eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

@mountiny
Copy link
Contributor Author

This will be ready to be paid soon

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Monthly KSv2 labels Jul 3, 2024
@melvin-bot melvin-bot bot changed the title [$250] Simplify the RootNavigator structure [HOLD for payment 2024-07-10] [$250] Simplify the RootNavigator structure Jul 3, 2024
Copy link

melvin-bot bot commented Jul 3, 2024

Reviewing label has been removed, please complete the "BugZero Checklist".

@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Jul 3, 2024
Copy link

melvin-bot bot commented Jul 3, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.3-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-07-10. 🎊

For reference, here are some details about the assignees on this issue:

Copy link

melvin-bot bot commented Jul 3, 2024

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

  • [@hoangzinh] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
  • [@JmillsExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Jul 10, 2024
@JmillsExpensify
Copy link

@hoangzinh do you mind filling out the BZ checklist?

@mountiny
Copy link
Contributor Author

@JmillsExpensify this was a new feature/ follow up so no other PR to flag this on.

$250 to @hoangzinh for their review and testing.

@mountiny
Copy link
Contributor Author

Also no regression test required

@melvin-bot melvin-bot bot added the Overdue label Jul 15, 2024
Copy link

melvin-bot bot commented Jul 15, 2024

@JmillsExpensify, @hoangzinh, @mountiny, @WojtekBoman, @adamgrzybowski Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@JmillsExpensify
Copy link

@hoangzinh the old offer expired so I just sent you a new one.

@melvin-bot melvin-bot bot removed the Overdue label Jul 16, 2024
@hoangzinh
Copy link
Contributor

Accepted. Thanks @JmillsExpensify

@JmillsExpensify
Copy link

Awesome thanks! All paid out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 External Added to denote the issue can be worked on by a contributor NewFeature Something to build that is a new item.
Projects
No open projects
Archived in project
Development

No branches or pull requests

5 participants