Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$250] [HOLD for payment 2024-06-05] Investigate android com.facebook.jni.CppException crash #40699

Closed
mountiny opened this issue Apr 22, 2024 · 32 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. External Added to denote the issue can be worked on by a contributor Reviewing Has a PR in review Weekly KSv2

Comments

@mountiny
Copy link
Contributor

mountiny commented Apr 22, 2024

There seems to be crash occurring on some android devices coming from reanimated, anyone able to investigate?
image

Fatal Exception: com.facebook.jni.CppException: [Reanimated] Data type not recognized by value unpacker.

Error: [Reanimated] Data type not recognized by value unpacker.
    at valueUnpacker (WorkletRuntime::WorkletRuntime:1:1477)
       at com.swmansion.reanimated.AndroidUIScheduler.triggerUI(AndroidUIScheduler.java)
       at com.swmansion.reanimated.AndroidUIScheduler$1.run(AndroidUIScheduler.java:24)
       at com.swmansion.reanimated.AndroidUIScheduler$2.runGuarded(AndroidUIScheduler.java:43)
       at com.facebook.react.bridge.GuardedRunnable.run(GuardedRunnable.java:29)
       at android.os.Handler.handleCallback(Handler.java:938)
       at android.os.Handler.dispatchMessage(Handler.java:99)
       at android.os.Looper.loopOnce(Looper.java:226)
       at android.os.Looper.loop(Looper.java:313)
       at android.app.ActivityThread.main(ActivityThread.java:8663)
       at java.lang.reflect.Method.invoke(Method.java)
       at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:567)
       at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1135)

Issue OwnerCurrent Issue Owner: @ikevin127
Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01666daee472e0a157
  • Upwork Job ID: 1797627295389204480
  • Last Price Increase: 2024-06-03
@mountiny mountiny added External Added to denote the issue can be worked on by a contributor Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Apr 22, 2024
@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Apr 22, 2024
Copy link

melvin-bot bot commented Apr 22, 2024

Triggered auto assignment to Contributor-plus team member for initial proposal review - @abdulrahuman5196 (External)

Copy link

melvin-bot bot commented Apr 22, 2024

Triggered auto assignment to @joekaufmanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@tienifr
Copy link
Contributor

tienifr commented Apr 22, 2024

Proposal

Please re-state the problem that we are trying to solve in this issue.

Investigate android com.facebook.jni.CppException crash

What is the root cause of that problem?

This is a known issue and was reported here, it was already fixed in latest version

What changes do you think we should make in order to solve the problem?

Upgrade the library to latest version (3.8.1). Or 3.8.0 is also fine since the bug was fixed since 3.8.0.

What alternative solutions did you explore? (Optional)

NA

@saifelance
Copy link

@tienifr
crashes related to android com.facebook.jni.CppException. The root cause appears to stem from a known issue, as reported. To address it, upgrading the library to the latest version seems like a viable solution.

@tienifr
Copy link
Contributor

tienifr commented Apr 22, 2024

Proposal updated to add some more details

@saifelance
Copy link

@tienifr
propose upgrading the library to the latest version, which should resolve the problem effectively 😀

@melvin-bot melvin-bot bot removed the Help Wanted Apply this label when an issue is open to proposals by contributors label Apr 22, 2024
@mountiny
Copy link
Contributor Author

@tienifr feel free to go ahead to prepare the bump PR

@ShridharGoel
Copy link
Contributor

@mountiny I posted the same proposal earlier here but the issue was closed: #40115 (comment)

@mountiny
Copy link
Contributor Author

Ooof, sorry for that, I think I could make you a C+ here if you want, seems like you know how to replicate this, would you live to do a C+ work here on the PR?

@ShridharGoel
Copy link
Contributor

That would be nice, thanks.

@mountiny
Copy link
Contributor Author

Gonna do that than, @tienifr please notify the C+ that will get autoassigned to the PR review

@joekaufmanexpensify
Copy link
Contributor

@tienifr is there an ETA for the PR here?

@tienifr
Copy link
Contributor

tienifr commented Apr 24, 2024

I am working on it

@tienifr
Copy link
Contributor

tienifr commented Apr 24, 2024

I faced a problem while trying to run the Android app, so I'm unable to test it.

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Daily KSv2 labels Apr 24, 2024
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label May 29, 2024
Copy link

melvin-bot bot commented May 29, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.76-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-06-05. 🎊

For reference, here are some details about the assignees on this issue:

  • @ShridharGoel requires payment (Needs manual offer from BZ)
  • @tienifr requires payment (Needs manual offer from BZ)

Copy link

melvin-bot bot commented May 29, 2024

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

  • [@mountiny] The PR that introduced the bug has been identified. Link to the PR:
  • [@mountiny] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
  • [@mountiny] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
  • [@ShridharGoel / @tienifr] Determine if we should create a regression test for this bug.
  • [@ShridharGoel / @tienifr] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
  • [@joekaufmanexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

@joekaufmanexpensify
Copy link
Contributor

I don't think BZ checklist is needed here.

@joekaufmanexpensify joekaufmanexpensify added External Added to denote the issue can be worked on by a contributor and removed External Added to denote the issue can be worked on by a contributor labels Jun 3, 2024
@melvin-bot melvin-bot bot changed the title [HOLD for payment 2024-06-05] Investigate android com.facebook.jni.CppException crash [$250] [HOLD for payment 2024-06-05] Investigate android com.facebook.jni.CppException crash Jun 3, 2024
Copy link

melvin-bot bot commented Jun 3, 2024

Job added to Upwork: https://www.upwork.com/jobs/~01666daee472e0a157

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Jun 3, 2024
Copy link

melvin-bot bot commented Jun 3, 2024

Triggered auto assignment to Contributor-plus team member for initial proposal review - @ikevin127 (External)

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Jun 3, 2024
@joekaufmanexpensify joekaufmanexpensify added Weekly KSv2 and removed Daily KSv2 Help Wanted Apply this label when an issue is open to proposals by contributors labels Jun 3, 2024
@joekaufmanexpensify
Copy link
Contributor

Payment needed here is:

@joekaufmanexpensify
Copy link
Contributor

offers sent to both of you!

@tienifr
Copy link
Contributor

tienifr commented Jun 3, 2024

@joekaufmanexpensify Thanks! I accepted the offer.

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Jun 4, 2024
@joekaufmanexpensify
Copy link
Contributor

@ShridharGoel $250 sent and contract ended!

@joekaufmanexpensify
Copy link
Contributor

@tienifr $250 sent and contract ended!

@joekaufmanexpensify
Copy link
Contributor

Upwork job closed

@joekaufmanexpensify
Copy link
Contributor

All set. Thanks everyone!

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Daily KSv2 labels Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. External Added to denote the issue can be worked on by a contributor Reviewing Has a PR in review Weekly KSv2
Projects
None yet
Development

No branches or pull requests

7 participants