[HOLD for payment 2024-05-20] [$250] Create automated tests for Workspace Taxes page

[luacmartins]

Problem

New API commands introduced as part of the Simplified Collect project don't have automated tests, which can lead to bugs and unexpected behavior when these commands are updated.

Solution

Add automated tests for the commands below:

• Test OpenPolicyTaxesPage
• Test SetPolicyCustomTaxName
• Test SetPolicyCurrencyDefaultTax
• Test SetPolicyForeignCurrencyDefaultTax
• Test CreatePolicyTax
• Test SetPolicyTaxesEnabled
• Test RenamePolicyTax
• Test UpdatePolicyTaxValue
• Test DeletePolicyTaxes

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01aabb7c33e3cc9759
• Upwork Job ID: 1783143315135184896
• Last Price Increase: 2024-04-24

Issue Owner

Current Issue Owner: @zanyrenney

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @dukenv0307 (External)

[melvin-bot]

Triggered auto assignment to @zanyrenney (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[tienifr]

Proposal

Please re-state the problem that we are trying to solve in this issue.

We need to add automated tests for new API commands in Workspace Taxes page

What is the root cause of that problem?

This is new requirement, currently we don't have any automated tests for those commands

What changes do you think we should make in order to solve the problem?

For each command, we need to:

1. Define the test scenarios for the command, this will be the different cases that the input params of the command function (for example this) can take. Eg. If a param is optional, we need to test both scenarios where that params is, and is not provided. And there should be the scenarios for different user's use cases as well, we can check this by testing the flow in the UI to see what possible values/actions they can take that influence the command input.

2. Write unit tests with those scenarios, given a set of command function input, we need to check that API.write/API.read are called with a correct set of parameters and onyxData (eg. this call).

For how to write it, we'll write Jest tests just like we did for other utils like here

What alternative solutions did you explore? (Optional)

NA

[dukenv0307]

It's not a bug issue so we can assign @tienifr. BTW, we haven't set the price for that ticket yet @luacmartins

🎀👀🎀 C+ reviewed

[melvin-bot]

Current assignee @luacmartins is eligible for the choreEngineerContributorManagement assigner, not assigning anyone new.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01aabb7c33e3cc9759

[melvin-bot]

Current assignee @dukenv0307 is eligible for the External assigner, not assigning anyone new.

[tienifr]

@dukenv0307 PR #41059 is ready

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.72-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• feat create automated tests for Workspace Taxes page #41059

If no regressions arise, payment will be issued on 2024-05-20. 🎊

For reference, here are some details about the assignees on this issue:

• @tienifr requires payment (Needs manual offer from BZ)
• @dukenv0307 requires payment (Needs manual offer from BZ)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@dukenv0307] The PR that introduced the bug has been identified. Link to the PR:
• [@dukenv0307] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@dukenv0307] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@dukenv0307] Determine if we should create a regression test for this bug.
• [@dukenv0307] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@zanyrenney] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[zanyrenney]

@dukenv0307 please complete the steps above, feel free to DM me when that is complete for the payout/ close out of th issue.

[melvin-bot]

Payment Summary

Upwork Job

• ROLE: @tienifr paid $(AMOUNT) via Upwork (LINK)
• ROLE: @dukenv0307 paid $(AMOUNT) via Upwork (LINK)

BugZero Checklist (@zanyrenney)

• I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
• I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants/1783143315135184896/hired)
• I have paid out the Upwork contracts or cancelled the ones that are incorrect
• I have verified the payment summary above is correct

[dukenv0307]

BugZero Checklist:

• The PR that introduced the bug has been identified. Link to the PR: N/A
• The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: N/A
• A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
• Determine if we should create a regression test for this bug. No
• If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again. N/A

[dukenv0307]

@zanyrenney I completed the checklist

[zanyrenney]

@dukenv0307 @tienifr i have invited you to the job

[tienifr]

Thanks @zanyrenney! I accepted the offer

[dukenv0307]

Hi @zanyrenney I don't see any job offer/invitation, would you mind double check?

Thank you!

[zanyrenney]

resent @dukenv0307 please can you check again!

[zanyrenney]

bump @dukenv0307

[zanyrenney]

[dukenv0307]

@zanyrenney Accepted!

[zanyrenney]

payment summary

paid @dukenv0307 $250 via upwork
paid @tienifr $250 via upwork.

[tienifr]

Hi @zanyrenney It seems my Upwork job is still unpaid.

Also, I actually receive payments via NewDot now. Could you help update the payment summary that I should request payment via NewDot? Then I'll do that.

Thanks!

[zanyrenney]

Hey @tienifr we can do this moving forward but as you've already been paid for this one via Upwork, we'll need to keep that as the payment method here to avoid additional work / audit in refunding and reissuing payments. thanks for your understanding!

[tienifr]

Hey @tienifr we can do this moving forward but as you've already been paid for this one via Upwork

@zanyrenney But I haven't been paid via Upwork yet, the job still remains unpaid. Please double check.

We can close that Upwork job and I'll request again on NewDot if you're good.