Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Track expense - In track expense, edit amount shows dollar briefly #40873

Closed
2 of 6 tasks
izarutskaya opened this issue Apr 24, 2024 · 16 comments
Closed
2 of 6 tasks

Track expense - In track expense, edit amount shows dollar briefly #40873

izarutskaya opened this issue Apr 24, 2024 · 16 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering

Comments

@izarutskaya
Copy link

izarutskaya commented Apr 24, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.65-0
Reproducible in staging?: Y
Reproducible in production?: N
Found when validating PR : #39956
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team

Action Performed:

  1. Go to https://staging.new.expensify.com/home
  2. Tap on a chat --- tap the FAB > track expense
  3. Enter an amount > change currency to RP> tap next
  4. Tap track expense (add a merchant when required)
  5. Tap on newly created expense to open epense details
  6. Tap amount to edit the currency
  7. Choose RP > Save
  8. Tap on amount to edit current
  9. Choose RP > Save
  10. Notice the $ shows for a brief moment after Saving expense and while the changes loading

Expected Result:

In track expense when clicking indian Rupee (RP), edit amount should not show any other currency

Actual Result:

In track expense while the amount in Indian Rupee (RP), edit amount shows dollar briefly.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6460041_1713952899660.dollar.mp4
RPReplay_Final1714710485.MP4

View all open jobs on GitHub

@izarutskaya izarutskaya added DeployBlockerCash This issue or pull request should block deployment Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Apr 24, 2024
Copy link

melvin-bot bot commented Apr 24, 2024

Triggered auto assignment to @Christinadobrzyn (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

Copy link

melvin-bot bot commented Apr 24, 2024

Triggered auto assignment to @hayata-suenaga (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

@github-actions github-actions bot added Engineering Hourly KSv2 and removed Daily KSv2 labels Apr 24, 2024
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@izarutskaya
Copy link
Author

@Christinadobrzyn I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

@izarutskaya
Copy link
Author

We think this issue might be related to the #vip-vsb.

@mountiny
Copy link
Contributor

Seems like a second regression from #39956 @shubham1206agra @thienlnam @allroundexperts

Its minor as well, can you follow up with a quick fix

@mountiny
Copy link
Contributor

demoting this as its minor but @shubham1206agra @allroundexperts assinging you as this is most likely coming from your PR

@mountiny mountiny added Daily KSv2 and removed DeployBlockerCash This issue or pull request should block deployment Hourly KSv2 labels Apr 24, 2024
@melvin-bot melvin-bot bot added the Overdue label Apr 26, 2024
Copy link

melvin-bot bot commented Apr 29, 2024

@allroundexperts, @thienlnam, @Christinadobrzyn, @shubham1206agra Huh... This is 4 days overdue. Who can take care of this?

@Christinadobrzyn
Copy link
Contributor

Just checking, are we creating a new PR for this issue? @allroundexperts @shubham1206agra?

@melvin-bot melvin-bot bot removed the Overdue label Apr 30, 2024
@allroundexperts
Copy link
Contributor

I think @shubham1206agra were unable to reproduce this. Is this correct @shubham1206agra?

@shubham1206agra
Copy link
Contributor

I was unable to repro this

@Christinadobrzyn
Copy link
Contributor

I can't reproduce this either. I'll ask QA to test - https://expensify.slack.com/archives/C9YU7BX5M/p1714468168251599

@kavimuru
Copy link

Bug is still reproduced.

can.mp4

@Christinadobrzyn
Copy link
Contributor

I'm still not able to reproduce this... @shubham1206agra or @allroundexperts can you test again and let me know if you get this?

@Christinadobrzyn
Copy link
Contributor

Christinadobrzyn commented May 3, 2024

Okay, I was able to reproduce this again when testing on iOS app - I uploaded the video to the OP and updated the steps.

Since this only seems to be affecting RP currency, I'm inclined to close this as a not critical, edge case, not part of our ROI. We can reevaluate it at a later time.

@thienlnam @allroundexperts what are your thoughts?

@thienlnam
Copy link
Contributor

I agree, doesn't seem like something we need to fix at this time

@melvin-bot melvin-bot bot removed the Overdue label May 6, 2024
@thienlnam thienlnam closed this as not planned Won't fix, can't repro, duplicate, stale May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering
Projects
None yet
Development

No branches or pull requests

8 participants