[HOLD for payment 2024-05-02] CRITICAL: [Track Expense] [$500] Unable to edit request

[thienlnam]

Things to fix from this PR: #37282

#37282 (review)

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01585d11e9c8f2b823
• Upwork Job ID: 1770523464695119872
• Last Price Increase: 2024-04-19

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01585d11e9c8f2b823

[melvin-bot]

Triggered auto assignment to Contributor Plus for review of internal employee PR - @mollfpr (Internal)

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[thienlnam]

The only API that seems to still be failing is UpdateMoneyRequestAmountAndCurrency

{
    "jsonCode": 0,
    "message": "Out of range",
    "onyxData": [],
    "requestID": "86dd74363cb759a6-DEL"
}

[thienlnam]

Fix for the above is merged - pending deploy https://github.com/Expensify/Auth/pull/10407

[thienlnam]

@shubham1206agra Are you able to link the draft PR you have here?

[melvin-bot]

@thienlnam Whoops! This issue is 2 days overdue. Let's get this updated quick!

[thienlnam]

#38699 (comment)

[thienlnam]

@shubham1206agra Bump on this - the BE issues are resolved so you should be able to open your PR now

[melvin-bot]

@thienlnam, @shubham1206agra Whoops! This issue is 2 days overdue. Let's get this updated quick!

[thienlnam]

@shubham1206agra Bump again - what's blocking us from getting this into review?

[shubham1206agra]

Nothing as for now. I will ready this PR after merging track whisper.

[thienlnam]

Increasing amount since we'd like to fit this into the next App deploy

[skyweb331]

Is this issue open for Contributors??? I can not find Help Wanted label

[quinthar]

@skyweb331 I think @shubham1206agra is already on this

[quinthar]

Or at the very least, I'm confused by their comment here: #38699 (comment)

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.65-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Edit track expense #39956

If no regressions arise, payment will be issued on 2024-05-02. 🎊

For reference, here are some details about the assignees on this issue:

• @shubham1206agra requires payment (Needs manual offer from BZ)

[melvin-bot]

Issue is ready for payment but no BZ is assigned. @twisterdotcom you are the lucky winner! Please verify the payment summary looks correct and complete the checklist. Thanks!

[melvin-bot]

Payment Summary

Upwork Job

• Contributor: @shubham1206agra paid $500 via Upwork here
• C+: @allroundexperts paid $500 via newDot Requests

BugZero Checklist (@twisterdotcom)

• I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
• I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants/1770523464695119872/hired)
• I have paid out the Upwork contracts or cancelled the ones that are incorrect
• I have verified the payment summary above is correct

[allroundexperts]

My payment is pending as well here:

#39956

@thienlnam @twisterdotcom

[shubham1206agra]

@twisterdotcom My payment is pending too. I have never received any payment.

[twisterdotcom]

@shubham1206agra you still need to accept the offer I sent here: https://www.upwork.com/nx/wm/offer/102145720

[shubham1206agra]

@twisterdotcom Accepted.

[twisterdotcom]

Nice, okay @allroundexperts I updated the Summary here: #38699 (comment) to include you and paid out @shubham1206agra.

[JmillsExpensify]

$500 approved for @allroundexperts