[$250] Split - Chat header shows split creator and split user avatar briefly when splitting expense

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.65-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Action Performed:

1. Go to staging.new.expensify.com
2. Go to FAB > Split expense
3. Split expense with one user that has no chat history
4. Note the avatar in chat header

Expected Result:

The chat header will show the split user avatar

Actual Result:

The chat header shows split creator and split user avatar briefly.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6460097_1713955443502.20240424_183933.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~019386f7d8c4cc34c1
• Upwork Job ID: 1785372503599595520
• Last Price Increase: 2024-05-07
• Automatic offers:
• Pujan92 | Reviewer | 0
• bernhardoj | Contributor | 0

[melvin-bot]

Triggered auto assignment to @anmurali (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[lanitochka17]

@anmurali FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[lanitochka17]

We think that this bug might be related to #vip-split

[bernhardoj]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The report header avatar shows both user avatars when doing a split bill with a new user.

What is the root cause of that problem?

The avatar will show all participant avatars in a report.

App/src/libs/ReportUtils.ts

Line 1942 in b0ec7b1

return getIconsForParticipants(report?.participantAccountIDs ?? [], personalDetails);

When we create a new split with a new user, we optimistically create a new chat with a participant that contains both users.

App/src/libs/actions/IOU.ts

Line 3104 in b0ec7b1

const allParticipantsAccountIDs = [...participantAccountIDs, currentUserAccountID];

App/src/libs/actions/IOU.ts

Lines 3123 to 3124 in b0ec7b1

	// Otherwise, create a new 1:1 chat report
	const splitChatReport = ReportUtils.buildOptimisticChatReport(allParticipantsAccountIDs);

But if it's a DM, the participant will exclude the current user, so when the request is completed, BE returns the correct participant, and the correct avatar is shown.

What changes do you think we should make in order to solve the problem?

For DM case, we should set the participant without the current user,

App/src/libs/actions/IOU.ts

Lines 3123 to 3124 in b0ec7b1

	// Otherwise, create a new 1:1 chat report
	const splitChatReport = ReportUtils.buildOptimisticChatReport(allParticipantsAccountIDs);

const splitChatReport = ReportUtils.buildOptimisticChatReport(participantAccountIDs);

[melvin-bot]

@anmurali Eep! 4 days overdue now. Issues have feelings too...

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~019386f7d8c4cc34c1

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @Pujan92 (External)

[Pujan92]

@bernhardoj's proposal looks good which is suggested to pass participantAccountIDs instead of allParticipantsAccountIDs(contains currentUserID) for 1:1 case.

🎀👀🎀 C+ reviewed

[melvin-bot]

Triggered auto assignment to @madmax330, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[anmurali]

@madmax330 do you agree with this? Can I assign the issue to @bernhardoj

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[melvin-bot]

@madmax330 @anmurali @Pujan92 this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[melvin-bot]

📣 @Pujan92 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[melvin-bot]

📣 @bernhardoj 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[bernhardoj]

PR is ready

cc: @Pujan92

[melvin-bot]

This issue has not been updated in over 15 days. @madmax330, @anmurali, @Pujan92, @bernhardoj eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

[bernhardoj]

The PR is merged. I think it's ready for payment @anmurali.

[Pujan92]

Bump @anmurali for the payment!

[anmurali]

Paid everyone.