[HOLD for payment 2024-06-05] [$250] Distance - No error message appears when trying to create an impossible route

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.65-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4506440
Email or phone of affected tester (no customers): sustinov@applausemail.com
Issue reported by: Applause - Internal Team

Action Performed:

Prerequisites:
Create Collect Policy in OD and invite the employee. Guides - https://sites.google.com/applausemail.com/applause-expensifyproject/wiki-guides/newdot-categories?authuser=0

Step:

1. Open https://staging.new.expensify.com/
2. Log in to your employee account
3. Navigate to the WS room
4. Navigate to + Menu - Submit expense - Distance
5. Select the starting waypoint - San Diego, CA, USA
6. Select the final waypoint - Hawaiian Gardens, CA, USA
7. Replace the final waypoint with - Hawaii, USA
8. Click on the start waypoint
9. Select again from the drop-down menu - San Diego, CA, USA
10. Complete the creation of the IOU

Expected Result:

When trying to create a route in which it is impossible to route between waypoints, an error message should appear

Actual Result:

No error message appears when trying to create an impossible route

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6460393_1713970658002.Recording__80.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01c3b8d6014bae7563
• Upwork Job ID: 1792531544970502144
• Last Price Increase: 2024-05-20
• Automatic offers:
• shubham1206agra | Reviewer | 0
• bernhardoj | Contributor | 0

Issue Owner

Current Issue Owner: @laurenreidexpensify

[melvin-bot]

Triggered auto assignment to @laurenreidexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[lanitochka17]

@laurenreidexpensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[laurenreidexpensify]

v1.4.65-5 on web chrome staging is showing the error

@lanitochka17 pls confirm the platform list again

[laurenreidexpensify]

Bump @lanitochka17 pls confirm platform list

[lanitochka17]

Issue is still reproducible with step 9

Recording.1670.mp4

We are waiting for confirmation from the tester of all platforms

[lanitochka17]

@laurenreidexpensify and reproduced on all environments

[laurenreidexpensify]

@lanitochka17 it looks like from your reproduction though that you cannot reproduce the reported error on web chrome, because you do see the error message?

[lanitochka17]

@laurenreidexpensify I agree that an error appears, but we can create an expense despite the error. Is this right?

[laurenreidexpensify]

I am not able to create an expense or move beyond Next as below when teh address is an impossible route, so I think we should remove web Chrome from the places where this error is reproducible - I am now on v1.4.70-1

[melvin-bot]

@laurenreidexpensify Whoops! This issue is 2 days overdue. Let's get this updated quick!

[melvin-bot]

@laurenreidexpensify this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[mvtglobally]

Issue is reproducible during KI retests.

1715540068285.uner.mp4

[laurenreidexpensify]

Gonna add this one as external

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01c3b8d6014bae7563

[shubham1206agra]

@bernhardoj's proposal looks good to me.

🎀 👀 🎀 C+ Reviewed

[melvin-bot]

Triggered auto assignment to @pecanoro, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[melvin-bot]

@pecanoro @shubham1206agra @laurenreidexpensify this issue is now 4 weeks old, please consider:

• Finding a contributor to fix the bug
• Closing the issue if BZ has been unable to add the issue to a VIP or Wave project
• If you have any questions, don't hesitate to start a discussion in #expensify-open-source

Thanks!

[pecanoro]

Assigning @bernhardoj to the issue!

[melvin-bot]

📣 @shubham1206agra 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[melvin-bot]

📣 @bernhardoj 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[bernhardoj]

PR is ready

cc: @shubham1206agra

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.76-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix no error message appears when trying to create an impossible route #42501

If no regressions arise, payment will be issued on 2024-06-05. 🎊

For reference, here are some details about the assignees on this issue:

• @bernhardoj requires payment automatic offer (Contributor)
• @shubham1206agra requires payment automatic offer (Reviewer)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@shubham1206agra] The PR that introduced the bug has been identified. Link to the PR:
• [@shubham1206agra] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@shubham1206agra] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@shubham1206agra] Determine if we should create a regression test for this bug.
• [@shubham1206agra] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@laurenreidexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[laurenreidexpensify]

Payment Summary for 6 June:

C+ @shubham1206agra $250 - offer sent in Upwork, please accept
Contributor @bernhardoj $250 - offer accepted in upwork, ready to pay tomorrow

@shubham1206agra please advise on steps above ^^

[shubham1206agra]

@laurenreidexpensify Accepted

[shubham1206agra]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@shubham1206agra] The PR that introduced the bug has been identified. Link to the PR: Feat/36985 create new rate field #38543
• [@shubham1206agra] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: Feat/36985 create new rate field #38543 (comment)
• [@shubham1206agra] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: Not Required
• [@shubham1206agra] Determine if we should create a regression test for this bug. Yes
• [@shubham1206agra] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

1. Press FAB > Submit Expense
2. Switch to Distance tab
3. Select San Diego and Hawaiian Garden as the Start and Stop waypoints
4. Change the Stop from Hawaiian Garden to Hawaii
5. Verify there is an error above the next button
6. Open the Stop waypoint again and select the same Hawaii
7. Verify there is an error above the next button
8. Verify pressing next won't navigate you to next page

• [@laurenreidexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[laurenreidexpensify]

Payment Summary:

C+ @shubham1206agra $250 - paid in upwork
Contributor @bernhardoj $250 - paid in upwork