Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2024-06-28] [HOLD for payment 2024-06-24] Accounting - Not able to set up Quickbooks, Intuit page freezes #40978

Closed
1 of 6 tasks
lanitochka17 opened this issue Apr 25, 2024 · 51 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Internal Requires API changes or must be handled by Expensify staff

Comments

@lanitochka17
Copy link

lanitochka17 commented Apr 25, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.65.3
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Issue found when executing PR #40713

Action Performed:

  1. Log in with a new expensifail account
  2. Create a workspace
  3. Enable "Accounting" in the workspace settings
  4. Navigate to the "Accounting" tab
  5. Tap on the "Set up" button next to Quickbooks

Expected Result:

I should be able to input data in the Intuit page fields

Actual Result:

Not able to set up Quickbooks, Intuit page freezes. You can only use the "<" button for navigating back, nothing on the Intuit page is interactable

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6460474_1713976135574.az_recorder_20240424_181853.mp4

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @joekaufmanexpensify
@lanitochka17 lanitochka17 added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Apr 25, 2024
Copy link

melvin-bot bot commented Apr 25, 2024

Triggered auto assignment to @joekaufmanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@lanitochka17
Copy link
Author

@joekaufmanexpensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

@lanitochka17
Copy link
Author

We think that this bug might be related to #wave-collect - Release 1

@joekaufmanexpensify
Copy link
Contributor

Hmm, I cannot reproduce. Works fine for me. Going to close this for now, since it's not consistently reproducible. If you're still able to consistently reproduce, please advise the device and app/android version you're using and happy to take another look!

2024-04-25_16-57-09.mp4

@kbecciv
Copy link

kbecciv commented May 8, 2024

Issue is reproducible on build 1.4.71.0

screen-20240507-155854.mp4

@kbecciv kbecciv reopened this May 8, 2024
@joekaufmanexpensify
Copy link
Contributor

I'm on 1.4.71-4 and I cannot reproduce it at all:

2024-05-08_09-45-51.mp4

@joekaufmanexpensify
Copy link
Contributor

@kbecciv if you can still reproduce this, please re-open and share the device type in addition to the app version so I can try on that same/similar device.

For now, going to re-close, as I still cannot reproduce this at all.

@kavimuru
Copy link

@joekaufmanexpensify Tester is still able to reproduce on Samsung Galaxy A52s 5G / Android 14 in the app version 1.4.74-1
Tester is unable to swipe on the setup page. Reopening the issue.

az_recorder_20240516_140754.mp4

@kavimuru kavimuru reopened this May 16, 2024
@kavimuru
Copy link

Reproduced in Pixel 6 / Android 14 and Samsung S10+ / Android12. Video from pixel 6 is attached here.

Uploading video_2024-05-16_08-39-26.mp4…

@joekaufmanexpensify
Copy link
Contributor

Hmm I will try and reproduce with those devices

@joekaufmanexpensify
Copy link
Contributor

So interesting. I still cannot reproduce this at all. I'm on 1.4.71-4 for all of the below devices.

Samsung Galaxy A52

2024-05-16_16-54-12.mp4

Samsung S10

2024-05-16_17-01-40.mp4

Pixel 6

2024-05-16_17-03-29.mp4

@joekaufmanexpensify
Copy link
Contributor

@kavimuru Perhaps the issue here is using an out of date version of the app? Please feel free to retest and LMK if it's reproducible for you on the newer version of the app.

But in the interim, I don't think we should move forward with this issue if we cannot consistently reproduce the issue. I personally have not been able to reproduce the issue on any device.

@kbecciv
Copy link

kbecciv commented May 31, 2024

@joekaufmanexpensify
Did you use an emulator or a real device? The QA team is able to consistently reproduce the issue on a real device, but it works fine when using a Bluetooth mouse. Can you please review the issue again? Thank you!

Screen_Recording_20240531_145851_New.Expensify.mp4

@kbecciv kbecciv reopened this May 31, 2024
@joekaufmanexpensify
Copy link
Contributor

@kbecciv I'm not using an emulator. I'm using browserstack, but according to our documentation, it uses real devices.

image

@joekaufmanexpensify
Copy link
Contributor

@kbecciv could you please confirm the device and app version used for the latest reproduction attempt and re-open the issue once you confirm?

I'll then try it again on my end, and then recruit a secondary internal triager to see if they have a different experience from me.

@kavimuru
Copy link

kavimuru commented Jun 7, 2024

Issue is reproduced in Samsung Galaxy A52s 5G / Android 14 and ND app version 1.4.80-4
https://platform.applause.com/services/links/v1/external/8ad2b37b22b5f095b86029797372de4ef89fbb10377a4418da0020f734bd0ecd

@kavimuru kavimuru reopened this Jun 7, 2024
@rushatgabhane
Copy link
Member

rushatgabhane commented Jun 12, 2024

Perfect, can you please mark the PR ready for review

cc @lakchote

@filip-solecki
Copy link
Contributor

Done

Copy link

melvin-bot bot commented Jun 13, 2024

Triggered auto assignment to @marcochavezf, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

@joekaufmanexpensify
Copy link
Contributor

PR merged!

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Jun 17, 2024
@melvin-bot melvin-bot bot changed the title Accounting - Not able to set up Quickbooks, Intuit page freezes [HOLD for payment 2024-06-24] Accounting - Not able to set up Quickbooks, Intuit page freezes Jun 17, 2024
Copy link

melvin-bot bot commented Jun 17, 2024

Reviewing label has been removed, please complete the "BugZero Checklist".

@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Jun 17, 2024
Copy link

melvin-bot bot commented Jun 17, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.84-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-06-24. 🎊

For reference, here are some details about the assignees on this issue:

Copy link

melvin-bot bot commented Jun 17, 2024

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

  • [@rushatgabhane] The PR that introduced the bug has been identified. Link to the PR:
  • [@rushatgabhane] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
  • [@rushatgabhane] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
  • [@rushatgabhane] Determine if we should create a regression test for this bug.
  • [@rushatgabhane] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
  • [@joekaufmanexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Weekly KSv2 labels Jun 21, 2024
@melvin-bot melvin-bot bot changed the title [HOLD for payment 2024-06-24] Accounting - Not able to set up Quickbooks, Intuit page freezes [HOLD for payment 2024-06-28] [HOLD for payment 2024-06-24] Accounting - Not able to set up Quickbooks, Intuit page freezes Jun 21, 2024
Copy link

melvin-bot bot commented Jun 21, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.85-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-06-28. 🎊

For reference, here are some details about the assignees on this issue:

Copy link

melvin-bot bot commented Jun 21, 2024

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

@joekaufmanexpensify
Copy link
Contributor

@rushatgabhane, could you please complete the checklist so we can prepare to issue payment?

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Jun 24, 2024
@joekaufmanexpensify
Copy link
Contributor

Bumped in slack

@rushatgabhane
Copy link
Member

  1. The PR that introduced the bug has been identified. Link to the PR: Xero authentication flow #40277

  2. The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/40277/files#r1653766737

  3. A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N.A.

  4. Determine if we should create a regression test for this bug. - No because part of QA

  5. If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again - N.A.

@joekaufmanexpensify
Copy link
Contributor

TY! Checklist is all set.

@joekaufmanexpensify
Copy link
Contributor

Only payment here is $250 to @rushatgabhane for C+ via NewDot.

@joekaufmanexpensify
Copy link
Contributor

@rushatgabhane you're all set to request payment via NewDot whenever you're ready. Going to close this for now, as it's otherwise all set!

@JmillsExpensify
Copy link

$250 approved for @rushatgabhane

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Internal Requires API changes or must be handled by Expensify staff
Projects
No open projects
Archived in project
Development

No branches or pull requests

10 participants