Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploy Checklist: New Expensify 2024-05-15 #42185

Closed
github-actions bot opened this issue May 15, 2024 · 22 comments
Closed

Deploy Checklist: New Expensify 2024-05-15 #42185

github-actions bot opened this issue May 15, 2024 · 22 comments
Assignees
Labels
🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging Monthly KSv2 StagingDeployCash

Comments

@github-actions
Copy link
Contributor

github-actions bot commented May 15, 2024

Release Version: 1.4.74-6
Compare Changes: production...staging

This release contains changes from the following pull requests:

Deploy Blockers:

Deployer verifications:

  • I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
  • I checked Firebase Crashlytics and verified that this release does not introduce any new crashes. More detailed instructions on this verification can be found here.
  • I checked GitHub Status and verified there is no reported incident with Actions.

cc @Expensify/applauseleads

@kavimuru kavimuru added the 🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging label May 15, 2024
@Beamanator Beamanator self-assigned this May 15, 2024
@OSBotify
Copy link
Contributor

🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/1.4.74-0 🚀

@Julesssss
Copy link
Contributor

Checking off #42194 as NOT A BLOCKER

@os-botify
Copy link

os-botify bot commented May 15, 2024

This issue either has unchecked items or has not yet been marked with the :shipit: emoji of approval.
Reopening!

@os-botify os-botify bot reopened this May 15, 2024
@kavimuru
Copy link

Regression is 75% of completion. We had site performance degrade issue and QA team was not able to login and navigate through the app. So we still have lot of PRs to validate. Will post next summary in the morning EST.

@luacmartins
Copy link
Contributor

Demoted #42236

@Beamanator
Copy link
Contributor

#42190 was fixed by #42223

@Beamanator
Copy link
Contributor

Demoting #42195, it's a new feature & just a console error

@Beamanator
Copy link
Contributor

Demoting #42209 b/c it's a pretty small style bug

@Beamanator
Copy link
Contributor

#42235 got demoted, checking it off

@Julesssss
Copy link
Contributor

#42268 isn't a blocker, as it's a new feature.

@Beamanator
Copy link
Contributor

#42207 was fixed on staging by #42237

@kavimuru
Copy link

Regression is left with 8 untested steps in the TestRail.

#41490 is failing with #40978 repro in PROD, checking it off
#42086 failing with #42271 repro in PROD, checking it off
#40950 failing with #42278 reprod in PROD, checking it off
Unchecked PRs:
#41917 is failing with #42268
#39290 - Pending validation in mWeb, iOS
#40342 - Pending validation in iOS
#41293 - Pending validation inDesktop, iOS
#41427 - Pending validation in mweb desktop iOS
#41484 - Pending validation in mweb iOS
#41564 - Pending validation in iOS
#41101 - Pending validation in mWeb, Android, iOS
#41583 - Pending validation in All the platforms
#41641 - Pending validation in iOS
#41651 - Pending validation in iOS
#41861 - Pending validation in Android iOS
#41902 - Pending validation in iOS

@Beamanator
Copy link
Contributor

Demoted #42269 as NAB

@Beamanator
Copy link
Contributor

#42263 and #42225 fixed by #42244 👍

@kavimuru
Copy link

Regression is completed:

Unchecked PRs:
#39290 is failing with #42316 repro in PROD checking it off
#41917 is failing with #42268
#41641 failing with #42195
#41293 is still failing in web mweb and android, bug not fixed comment
#41484 is still failing in iOS, bug not fixed, comment
#40610- we have difficulty in validating comment

Open Blockers:
#42189
#42210
#42232
#42254
#42259
#42273

@Beamanator
Copy link
Contributor

#42238 was tested on staging by QA, verified it fixes #42189 and #42232

@melvin-bot melvin-bot bot added the Monthly KSv2 label May 20, 2024
@AndrewGable
Copy link
Contributor

Checked off #41293, we will add another fix as a follow up

@Beamanator Beamanator removed the Monthly KSv2 label May 22, 2024
@Beamanator Beamanator removed their assignment May 22, 2024
@melvin-bot melvin-bot bot added the Monthly KSv2 label May 22, 2024
@cristipaval
Copy link
Contributor

Checked off #42351

@chiragsalian
Copy link
Contributor

Checking off #40610 - reasoning
Checking off #41484 - reasoning
Checking off #41641 - Reasoning
Checking off #41917 - Reasoning

#42210 PR merged, CP-ing it atm. Will check it off once i test on staging.

@chiragsalian
Copy link
Contributor

Checked off #42359 - reasoning

@chiragsalian
Copy link
Contributor

Checking off #42210 - reasoning

@chiragsalian
Copy link
Contributor

:shipit:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging Monthly KSv2 StagingDeployCash
Projects
None yet
Development

No branches or pull requests

9 participants