FAB - Track expense button is missing from the FAB for new expensifail accounts

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.74-0
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4561895&group_by=cases:section_id&group_order=asc&group_id=295815
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause internal team
Slack conversation:

Action Performed:

1. Sign up for a new expensifail account
2. Click on the FAB

Expected Result:

Track expense button should be available from the start.

Actual Result:

Track expense button is missing from the FAB for new expensifail accounts.
It returns if you refresh the page on web and mWeb.
You have to restart the app on iOS and Android for the button to return.
Doesn't affect Gmail accounts.

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6481609_1715777180466.bandicam_2024-05-15_14-39-43-419.mp4

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @bfitzexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @marcaaron (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open Staging deploy checklist to see the list of PRs included in this release, then work quickly on the following:

1. If you find which PR caused the issue/bug, you can reassign it to the person responsible for it.
   • If the author is OOO or won’t get online before the daily deploy is due, you are responsible for finding the best fix/path forward. Don’t hesitate to ask for help!
2. Try to reproduce the issue, if the bug is on production, remove the DeployBlocker label but stay assigned to fix it (or find out which PR broke it to get help from the author).
   • You can adjust the urgency of the issue to better represent the gravity of the bug.
   • If the issue is super low priority, feel free to un-assign yourself.
   • Be careful with PHP warnings, sometimes it is more complex than just adding a null coalescing operator as they might be uncovering some bigger bug.
   • If it was a one-off issue that requires no action (for example, Bedrock was down or it is a duplicated issue), you can close it.

Remember rule #2: Never un-assign yourself from a real DeployBlocker unless you are 100% sure someone else is assigned and will take care of it.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[marcaaron]

Doesn't affect Gmail accounts.

This sounds suspect to me. Is this behind a beta or something?

It returns if you refresh the page on web and mWeb.

also sounds like a BE problem.

[marcaaron]

Seems potentially related to #41892 cc @thienlnam

[thienlnam]

This just happens for expensifail accounts?? 😕

[thienlnam]

I wonder if this is because the accounts are getting created in a different flow than the typical CreateAccount where the shouldCreateSelfDM flag is added. This should be resolved here. Additionally if this is just for expensifail accounts we can demote this

[marcaaron]

Ah yeah that seems like a good guess. Gonna let you figure this out 🏃‍♂️

[melvin-bot]

@thienlnam Huh... This is 4 days overdue. Who can take care of this?

[melvin-bot]

@thienlnam Still overdue 6 days?! Let's take care of this!

[melvin-bot]

@thienlnam 10 days overdue. Is anyone even seeing these? Hello?

[thienlnam]

Not a daily, going to be resolved as part of this issue https://github.com/Expensify/Expensify/issues/395534

[thienlnam]

Still pending on the above, running into a runtime core dump that I haven't figured out yet

[thienlnam]

Same, no progress

[thienlnam]

Held PR is merged and deployed - asking for a retest

[mvtglobally]

Not repro https://github.com/user-attachments/assets/be4fe40f-a238-4d77-8b2c-dd5db51a8f66

[thienlnam]

Sweet - all good then