Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Task - Chat header turns to skeleton after assigning task to user with no chat history #42273

Closed
6 tasks done
m-natarajan opened this issue May 16, 2024 · 45 comments
Closed
6 tasks done
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering Internal Requires API changes or must be handled by Expensify staff Weekly KSv2

Comments

@m-natarajan
Copy link

m-natarajan commented May 16, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.74-1
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail: exp around https://expensify.testrail.io/index.php?/tests/view/4561795&group_by=cases:section_id&group_id=291936&group_order=asc
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause internal team
Slack conversation:

Action Performed:

  1. Go to staging.new.expensify.com and login
  2. Go to FAB > Assign task.
  3. Assign a task to a user that has no chat history.

Expected Result:

After the task is created, the chat header will not show skeleton.

Actual Result:

After the task is created, the chat header shows skeleton.

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6482493_1715848404484.20240516_163050.mp4

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @aldo-expensify
@m-natarajan m-natarajan added DeployBlockerCash This issue or pull request should block deployment Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. DeployBlocker Indicates it should block deploying the API labels May 16, 2024
Copy link

melvin-bot bot commented May 16, 2024

Triggered auto assignment to @iwiznia (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link

melvin-bot bot commented May 16, 2024

Triggered auto assignment to @kadiealexander (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

Copy link

melvin-bot bot commented May 16, 2024

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open Staging deploy checklist to see the list of PRs included in this release, then work quickly on the following:

  1. If you find which PR caused the issue/bug, you can reassign it to the person responsible for it.
    • If the author is OOO or won’t get online before the daily deploy is due, you are responsible for finding the best fix/path forward. Don’t hesitate to ask for help!
  2. Try to reproduce the issue, if the bug is on production, remove the DeployBlocker label but stay assigned to fix it (or find out which PR broke it to get help from the author).
    • You can adjust the urgency of the issue to better represent the gravity of the bug.
    • If the issue is super low priority, feel free to un-assign yourself.
    • Be careful with PHP warnings, sometimes it is more complex than just adding a null coalescing operator as they might be uncovering some bigger bug.
    • If it was a one-off issue that requires no action (for example, Bedrock was down or it is a duplicated issue), you can close it.

Remember rule #2: Never un-assign yourself from a real DeployBlocker unless you are 100% sure someone else is assigned and will take care of it.

@melvin-bot melvin-bot bot removed the Hourly KSv2 label May 16, 2024
@github-actions github-actions bot added Hourly KSv2 and removed Daily KSv2 labels May 16, 2024
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@m-natarajan
Copy link
Author

@kadiealexander FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

@m-natarajan
Copy link
Author

We think that this bug might be related to #vip-vsb

@iwiznia
Copy link
Contributor

iwiznia commented May 16, 2024

I can't reproduce this. It's possible it was during when we had issues in the servers, can you re-test please @m-natarajan?

@kadiealexander
Copy link
Contributor

@kavimuru
Copy link

Still able to reproduce by the tester in 2 different account.

rpreplay_final1715946448.mp4
rpreplay_final1715946288.mp4

@melvin-bot melvin-bot bot added the Overdue label May 20, 2024
@kadiealexander
Copy link
Contributor

@iwiznia can you identify the offending PR for this one?

@melvin-bot melvin-bot bot removed the Overdue label May 21, 2024
@aldo-expensify
Copy link
Contributor

I'm trying to reproduce, but failing. I tried creating a task for a user that doesn't exist and I also tried creating a task for a user with whom I opened a chat first (no messages in the chat). In both cases, it worked fine:

Screen.Recording.2024-05-22.at.12.15.13.PM.mov

@aldo-expensify
Copy link
Contributor

Can't reproduce in dev either

@mountiny
Copy link
Contributor

Seems like we are not able to reproduce, this does not seem like a web blocker to me so going to remove the label

@mountiny mountiny removed the DeployBlocker Indicates it should block deploying the API label May 22, 2024
@melvin-bot melvin-bot bot added the Overdue label Jun 20, 2024
Copy link

melvin-bot bot commented Jun 21, 2024

@kadiealexander, @aldo-expensify Whoops! This issue is 2 days overdue. Let's get this updated quick!

@aldo-expensify
Copy link
Contributor

I'm working on fixing this now

@melvin-bot melvin-bot bot removed the Overdue label Jun 21, 2024
@aldo-expensify
Copy link
Contributor

aldo-expensify commented Jun 21, 2024

Seems like CreateTask creates an onyx report with only 1 participant (yourself) missing the assignee and also a second update with both participants, so the second update fixes it:

Screen.Recording.2024-06-21.at.12.12.18.PM.mov

but then, there is a call to GetMissingOnyxMessages (which sounds like a something that shouldn't be happening) brings again the onyx report with the single participant causing the problem:

image

I'll first fix the report onyx update with incorrect participants. Then, I'll investigate why GetMissingOnyxMessages is getting called when it shouldn't.

@melvin-bot melvin-bot bot added the Overdue label Jun 24, 2024
@aldo-expensify aldo-expensify added the Reviewing Has a PR in review label Jun 24, 2024
@melvin-bot melvin-bot bot removed the Overdue label Jun 24, 2024
@aldo-expensify
Copy link
Contributor

aldo-expensify commented Jun 24, 2024

@aldo-expensify
Copy link
Contributor

Not deployed yet, got confused. We need to retest once https://github.com/Expensify/Auth/pull/11353 is deployed. I'm not sure why I wasn't able to login into applausetester+kh040601@applause.expensifail.com (the account I was using to reproduce the bug)

@aldo-expensify aldo-expensify added Weekly KSv2 and removed Daily KSv2 labels Jun 28, 2024
@aldo-expensify
Copy link
Contributor

@kadiealexander I'll go OOO next week, we will probably deploy around Monday... maybe then you can ping someone from applause to retest? 🙇

@kadiealexander
Copy link
Contributor

Requested a retest here.

@kavimuru
Copy link

Able to reproduce

20240719_175437.mp4

@aldo-expensify
Copy link
Contributor

Thanks @kavimuru . I'll have to investigate and see what else may be the issue.

@aldo-expensify aldo-expensify removed the Reviewing Has a PR in review label Jul 23, 2024
@melvin-bot melvin-bot bot added the Overdue label Jul 31, 2024
@kadiealexander
Copy link
Contributor

@aldo-expensify any updates here?

@melvin-bot melvin-bot bot removed the Overdue label Aug 1, 2024
@aldo-expensify
Copy link
Contributor

no, I haven't investigated again, I'll do it asap

@melvin-bot melvin-bot bot added the Overdue label Aug 9, 2024
@kadiealexander
Copy link
Contributor

Not overdue

@melvin-bot melvin-bot bot removed the Overdue label Aug 12, 2024
@melvin-bot melvin-bot bot added the Overdue label Aug 20, 2024
@aldo-expensify
Copy link
Contributor

Investigating now....

@melvin-bot melvin-bot bot removed the Overdue label Aug 20, 2024
@aldo-expensify
Copy link
Contributor

Hmm I don't see "Assign task" anymore in the menu, so I can't reproduce with the existing steps... Should we close?

If you create a task from within a chat, then the "Assign task" action appears in the FAB (big green button) menu, but it appears with a pre-selected assignee, so we can't either reproduce this way.

image

@aldo-expensify
Copy link
Contributor

I'll close this since I think it is no longer reproducible. Feel free to reopen if you find new steps to reproduce.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering Internal Requires API changes or must be handled by Expensify staff Weekly KSv2
Projects
No open projects
Status: No status
Development

No branches or pull requests

9 participants