Add XeroChartOfAccountsPage #41849

SzymczakJ · 2024-05-08T14:40:21Z

Details

This PR add Xero chart of accounts page.

Fixed Issues

$ #39731
PROPOSAL: N/A

Tests

With a Workspace with a Xero connection
Go to Import page
Check that the first item (Chart of accounts) looks like on this screenshot:

Click "Chart of accounts"
Verify that the page looks like this:

Disable the checkbox at the bottom
Go back to the import page
Verify that "Chart of accounts" still shows "Imported, displayed as categories"

Offline tests

QA Steps

Same as tests

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

androidChartOfAccounts.mov

Android: mWeb Chrome

androidwebChartOfAccounts.mov

iOS: Native

iosChartOfAccounts.mov

iOS: mWeb Safari

ioswebCHartOfAccounts.mov

MacOS: Chrome / Safari

webChartOfAccounts.mov

MacOS: Desktop

desktopChartOfAccounts.mov

kosmydel

Code LGTM 🚀

kosmydel · 2024-05-08T15:55:16Z

src/SCREENS.ts

@@ -242,6 +242,7 @@ const SCREENS = {
            QUICKBOOKS_ONLINE_INVOICE_ACCOUNT_SELECTOR: 'Policy_Accounting_Quickbooks_Online_Invoice_Account_Selector',
            XERO_IMPORT: 'Policy_Accounting_Xero_Import',
            XERO_ORGANIZATION: 'Policy_Accounting_Xero_Customers',
+            XERO_CHART_OF_ACCOUNTS: 'Policy_Accounting_Xero_Import_Chart_Of_Accounts',


Was this Import added intentionally?

Suggested change

XERO_CHART_OF_ACCOUNTS: 'Policy_Accounting_Xero_Import_Chart_Of_Accounts',

XERO_CHART_OF_ACCOUNTS: 'Policy_Accounting_Xero_Chart_Of_Accounts',

Yes, it's intended. Quickbooks Chart of accounts page has the same naming and I'm trying to keep the same convention 😄

melvin-bot · 2024-05-09T08:53:15Z

@s77rt Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

lakchote · 2024-05-09T10:29:32Z

@Expensify/design could you take a look please?

shawnborton · 2024-05-09T11:49:55Z

Screenshot looks pretty good to me!

lakchote · 2024-05-09T13:12:55Z

@SzymczakJ please change the target branch to xero-merge-freeze

lakchote · 2024-05-09T13:17:29Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

s77rt · 2024-05-10T18:39:12Z

src/languages/es.ts

+            accountsDescription: 'Cuando estás conectado a Quickbooks Online, los planes de cuentas siempre se importan a Expensify como categorías.',
+            accountsSwitchTitle: 'Elige abajo si las categorías importadas serán activadas o desactivadas por defecto.',
+            accountsSwitchDescription: 'Las categorías activas estarán disponibles para ser escogidas cuando se crea un gasto.',


Not the correct translation

s77rt · 2024-05-10T18:52:59Z

src/pages/workspace/accounting/xero/import/XeroChartOfAccountsPage.tsx

+            <View style={[styles.flexRow, styles.mb2, styles.alignItemsCenter, styles.justifyContentBetween]}>
+                <View style={styles.flex1}>
+                    <Text fontSize={variables.fontSizeNormal}>{translate('workspace.common.enabled')}</Text>
+                </View>
+                <OfflineWithFeedback pendingAction={pendingFields?.enableNewCategories}>
+                    <View style={[styles.flex1, styles.alignItemsEnd, styles.pl3]}>
+                        <Switch
+                            accessibilityLabel={translate('workspace.accounting.accounts')}
+                            isOn={!!enableNewCategories}
+                            onToggle={() =>
+                                Connections.updatePolicyConnectionConfig(policyID, CONST.POLICY.CONNECTIONS.NAME.XERO, CONST.XERO_CONFIG.ENABLE_NEW_CATEGORIES, !enableNewCategories)
+                            }
+                        />
+                    </View>
+                </OfflineWithFeedback>
+            </View>
+            <View style={styles.flex1}>
+                <Text style={styles.mutedTextLabel}>{translate('workspace.xero.accountsSwitchDescription')}</Text>
+            </View>


Replace with ToggleSettingOptionRow and pass errors and onCloseError

SzymczakJ · 2024-05-13T09:58:17Z

@s77rt fixed your comments!

s77rt · 2024-05-13T10:02:34Z

src/pages/workspace/accounting/xero/import/XeroChartOfAccountsPage.tsx

-                <Text style={styles.mutedTextLabel}>{translate('workspace.xero.accountsSwitchDescription')}</Text>
-            </View>
+            <ToggleSettingOptionRow
+                key={translate('workspace.xero.accountsSwitchTitle')}


Why is key needed?

blooper on my side 😅

s77rt · 2024-05-13T11:20:34Z

src/pages/workspace/accounting/xero/import/XeroChartOfAccountsPage.tsx

+                title={translate('workspace.common.enabled')}
+                subtitle={translate('workspace.xero.accountsSwitchDescription')}
+                shouldPlaceSubtitleBelowSwitch
+                wrapperStyle={styles.mv3}


Suggested change

wrapperStyle={styles.mv3}

In QBO we don't have the extra margin

s77rt

Looks good to me

OSBotify · 2024-05-15T10:14:44Z

🚀 Deployed to staging by https://github.com/lakchote in version: 1.4.74-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-05-22T23:59:45Z

🚀 Deployed to production by https://github.com/chiragsalian in version: 1.4.74-6 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

SzymczakJ added 4 commits May 8, 2024 16:36

refactor workspace.qbo and workspace.common translations

7e1868a

add XeroChartOfAccountsPage

7eaa38e

fix enable toggle not working

b34d095

fix translations on XeroImportPage

16794e8

kosmydel approved these changes May 8, 2024

View reviewed changes

SzymczakJ marked this pull request as ready for review May 9, 2024 08:53

SzymczakJ requested a review from a team as a code owner May 9, 2024 08:53

melvin-bot bot requested review from s77rt and removed request for a team May 9, 2024 08:53

lakchote approved these changes May 9, 2024

View reviewed changes

SzymczakJ changed the base branch from main to xero-merge-freeze May 9, 2024 13:14

Merge branch 'xero-merge-freeze' into @szymczak/xero-chart-of-accounts

bc7465b

s77rt suggested changes May 10, 2024

View reviewed changes

fix pr comments

b576dc5

s77rt reviewed May 13, 2024

View reviewed changes

delete usused key prop

c059270

SzymczakJ requested a review from s77rt May 13, 2024 10:17

s77rt suggested changes May 13, 2024

View reviewed changes

fix PR comments

22c81b3

s77rt approved these changes May 13, 2024

View reviewed changes

melvin-bot bot requested a review from lakchote May 13, 2024 11:49

lakchote approved these changes May 13, 2024

View reviewed changes

lakchote merged commit 0667075 into Expensify:xero-merge-freeze May 13, 2024
16 checks passed

github-actions bot mentioned this pull request May 15, 2024

Deploy Checklist: New Expensify 2024-05-15 #42185

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add XeroChartOfAccountsPage #41849

Add XeroChartOfAccountsPage #41849

SzymczakJ commented May 8, 2024 •

edited

Loading

kosmydel left a comment

kosmydel May 8, 2024

SzymczakJ May 9, 2024

melvin-bot bot commented May 9, 2024

lakchote commented May 9, 2024

shawnborton commented May 9, 2024

lakchote commented May 9, 2024 •

edited

Loading

lakchote commented May 9, 2024

s77rt May 10, 2024 •

edited

Loading

s77rt May 10, 2024

SzymczakJ commented May 13, 2024

s77rt May 13, 2024

SzymczakJ May 13, 2024

s77rt May 13, 2024

s77rt May 13, 2024

s77rt left a comment

OSBotify commented May 15, 2024

OSBotify commented May 22, 2024

	XERO_CHART_OF_ACCOUNTS: 'Policy_Accounting_Xero_Import_Chart_Of_Accounts',
	XERO_CHART_OF_ACCOUNTS: 'Policy_Accounting_Xero_Chart_Of_Accounts',

Add XeroChartOfAccountsPage #41849

Add XeroChartOfAccountsPage #41849

Conversation

SzymczakJ commented May 8, 2024 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

kosmydel left a comment

Choose a reason for hiding this comment

kosmydel May 8, 2024

Choose a reason for hiding this comment

SzymczakJ May 9, 2024

Choose a reason for hiding this comment

melvin-bot bot commented May 9, 2024

lakchote commented May 9, 2024

shawnborton commented May 9, 2024

lakchote commented May 9, 2024 • edited Loading

lakchote commented May 9, 2024

Reviewer Checklist

Screenshots/Videos

s77rt May 10, 2024 • edited Loading

Choose a reason for hiding this comment

s77rt May 10, 2024

Choose a reason for hiding this comment

SzymczakJ commented May 13, 2024

s77rt May 13, 2024

Choose a reason for hiding this comment

SzymczakJ May 13, 2024

Choose a reason for hiding this comment

s77rt May 13, 2024

Choose a reason for hiding this comment

s77rt May 13, 2024

Choose a reason for hiding this comment

s77rt left a comment

Choose a reason for hiding this comment

OSBotify commented May 15, 2024

OSBotify commented May 22, 2024

SzymczakJ commented May 8, 2024 •

edited

Loading

lakchote commented May 9, 2024 •

edited

Loading

s77rt May 10, 2024 •

edited

Loading