Workspace switcher - Workspace icon is displayed when Expensify filter is selected

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.74-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Action Performed:

Precondition:

• There is at least 1 workspace

1. Go to staging.new.expensify.com
2. Open workspace switcher
3. Select a workspace
4. Open workspace switcher again
5. Select Expensify

Expected Result:

Expensify logo will display next to the breadcrumbs

Actual Result:

A workspace icon is displayed next to the breadcrumbs after switching from workspace back to Expensify

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6481505_1715771313081.E.mp4

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @iwiznia (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open Staging deploy checklist to see the list of PRs included in this release, then work quickly on the following:

1. If you find which PR caused the issue/bug, you can reassign it to the person responsible for it.
   • If the author is OOO or won’t get online before the daily deploy is due, you are responsible for finding the best fix/path forward. Don’t hesitate to ask for help!
2. Try to reproduce the issue, if the bug is on production, remove the DeployBlocker label but stay assigned to fix it (or find out which PR broke it to get help from the author).
   • You can adjust the urgency of the issue to better represent the gravity of the bug.
   • If the issue is super low priority, feel free to un-assign yourself.
   • Be careful with PHP warnings, sometimes it is more complex than just adding a null coalescing operator as they might be uncovering some bigger bug.
   • If it was a one-off issue that requires no action (for example, Bedrock was down or it is a duplicated issue), you can close it.

Remember rule #2: Never un-assign yourself from a real DeployBlocker unless you are 100% sure someone else is assigned and will take care of it.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[lanitochka17]

@iwiznia FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[lanitochka17]

We think that this bug might be related to #vip-vsp

[Nodebrute]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Workspace icon is displayed when Expensify filter is selected

What is the root cause of that problem?

We are passing an empty string here. It should be undefined.

App/src/pages/WorkspaceSwitcherPage/index.tsx

Line 148 in 1ee5d03

policyID: '',

What changes do you think we should make in order to solve the problem?

We can remove PolicyID from here or set it to undefined.

[iwiznia]

I think the bug is coming from #41769 testing that theory now

[iwiznia]

Nope

[iwiznia]

ok @Nodebrute your fix works. I think we need to change this

App/src/pages/WorkspaceSwitcherPage/index.tsx

Line 26 in 6dfa942

policyID: string;

to policyID? too.
Though I am a bit confused on what PR caused this though...

[Nodebrute]

@iwiznia

ok @Nodebrute your fix works. I think we need to change this

App/src/pages/WorkspaceSwitcherPage/index.tsx

Line 26 in 6dfa942

policyID: string;

to policyID? too.

Correct.

[Nodebrute]

@iwiznia I also struggle to find it, but I believe this is the correct RCA. This bug has always been present, but it's only now coming to light due to some recent PR. The workspace switcher policyID should always be undefined.

[Nodebrute]

@iwiznia Could you assign me to work on the fix?"

[iwiznia]

Yep, assigned you, thanks!

[allgandalf]

I think this may be coming from #40016 @iwiznia

[iwiznia]

That's correct, thanks @GandalfGwaihir!

[Nodebrute]

@iwiznia #42223 You can merge this PR in case you decide to go with this fix.

[iwiznia]

This is working now, just tested on staging