[CHECKLIST] [$250] Expense - Merchant name of the deleted expense in OD report is still shown in ND report

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.65-4
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4506647
Issue reported by: Applause - Internal Team
*

Action Performed:

Employee - OldDot

1. Navigate to one of the empty reports
2. Add an expense to the report

Employee - NewDot

1. As the employee in NewDot - Navigate to the workspace chat
2. Verify the report that had the expense added shows the new amount
3. Click on the report with the newly added expense
4. Verify the expense is displayed in the report conversation

Employee - OldDot

1. Navigate to the report with the expense
2. Delete the expense from the report

Employee - NewDot

1. As the employee in NewDot - Navigate to the workspace chat
2. Verify the report that had the expense removed displays $0.00
3. Verify if the name of Merchant still displayed below the $0.00

Expected Result:

Only $0.00 is shown in the report

Actual Result:

Merchant name of the deleted expense is shown below the $0.00

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6460737_1713988639162.2024-04-24_22-44-17.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01a644000e2f4f8e02
• Upwork Job ID: 1783553598312005632
• Last Price Increase: 2024-05-09
• Automatic offers:
• akinwale | Reviewer | 0
• ikevin127 | Contributor | 0

Issue Owner

Current Issue Owner: @garrettmknight

[melvin-bot]

Triggered auto assignment to @garrettmknight (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[lanitochka17]

@garrettmknight FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[lanitochka17]

We think that this bug might be related to #wave-collect - Release 1

[garrettmknight]

Repro'd opening it up.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01a644000e2f4f8e02

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @akinwale (External)

[garrettmknight]

Since this is a pretty niche bug and low priority I don't expect this to get fixed intentionally, quickly, but we could very well fix it elsewhere with our backwards compatibility work so I'm setting it for a retest weekly.

[fitd-tech]

Proposal

Please re-state the problem that we are trying to solve in this issue.

We don't want to display a Merchant name when the total owed is $0.00 (meaning the expense has been deleted).

What is the root cause of that problem?

I can't find a good indicator of whether the expense has been deleted, because the iouReport passed to the ReportPreview component doesn't seem to show updated information (the total amount is always 0, for instance). Instead, we're getting the total amount from the action message string:

App/src/components/ReportActionItem/ReportPreview.tsx

Lines 171 to 179 in 91d3562

	// If iouReport is not available, get amount from the action message (Ex: "Domain20821's Workspace owes $33.00" or "paid ₫60" or "paid -₫60 elsewhere")
	let displayAmount = '';
	const actionMessage = action.message?.[0]?.text ?? '';
	const splits = actionMessage.split(' ');
	splits.forEach((split) => {
	if (!/\d/.test(split)) {
	return;
	}

What changes do you think we should make in order to solve the problem?

For the sake of this particular Issue, we can set shouldShowSubtitle to false when getDisplayAmount returns'$0.00' and numberOfRequests equals 1 (in addition to the existing conditions):

App/src/components/ReportActionItem/ReportPreview.tsx

Line 228 in 91d3562

const shouldShowSubtitle = !isScanning && (shouldShowSingleRequestMerchantOrDescription || numberOfRequests > 1);

The video attached to the Issue shows some other issues. You must click on the report preview in order for the report to update and reflect the new $0.00 amount. The user would still have to perform this step in order for the merchant name to be removed. I would assume that this is a known issue, but I can attempt to resolve it here if you'd like.

What alternative solutions did you explore? (Optional)

We could also only set formattedMerchant if the above conditions aren't true, instead of removing the subtitle altogether:

App/src/components/ReportActionItem/ReportPreview.tsx

Line 144 in 91d3562

let formattedMerchant = numberOfRequests === 1 ? TransactionUtils.getMerchant(allTransactions[0]) : null;

I could also look into getting the updated iouReport so we explicitly know if the IOU total is $0.00.

[garrettmknight]

@akinwale mind giving this proposal a review when you get a chance?

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[melvin-bot]

@garrettmknight, @akinwale Whoops! This issue is 2 days overdue. Let's get this updated quick!

[akinwale]

Still looking for proposals here.

[melvin-bot]

@garrettmknight, @akinwale Eep! 4 days overdue now. Issues have feelings too...

[melvin-bot]

@garrettmknight, @akinwale Huh... This is 4 days overdue. Who can take care of this?

[ikevin127]

PR #42015 ready for review! 🚀

[mvtglobally]

Issue is reproducible during KI retests.

1715460438165.bandicam_2024-05-11_23-44-33-097.mp4

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.76-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Merchant name of the deleted expense in OD report is still shown in ND report #42015

If no regressions arise, payment will be issued on 2024-06-05. 🎊

For reference, here are some details about the assignees on this issue:

• @akinwale requires payment automatic offer (Reviewer)
• @ikevin127 requires payment automatic offer (Contributor)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@akinwale / @ikevin127] The PR that introduced the bug has been identified. Link to the PR:
• [@akinwale / @ikevin127] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@akinwale / @ikevin127] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@akinwale / @ikevin127] Determine if we should create a regression test for this bug.
• [@akinwale / @ikevin127] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@garrettmknight] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[ikevin127]

• [@ikevin127] The PR that introduced the bug has been identified. Link to the PR: ❌

Since this is a cross-app edge case (OD to ND), there was no offending PR that introduced this since we're not testing front-end ND pull requests on OD in order to catch this kind of edge cases.

• [@ikevin127] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: ❌
• [@ikevin127] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: ❌

Since we're migrating the platform from OD to ND, I don't think we should start a discussion or update the PR review checklist to extend testing of ND features to OD.

• [@ikevin127] Determine if we should create a regression test for this bug.
• [@ikevin127] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

Regression Test Proposal

Employee - OldDot

1. Navigate to one of the empty reports.
2. Add an expense with merchant to the report.

Employee - NewDot

1. As the employee in NewDot - navigate to the workspace chat.
2. Verify the report preview is matching the OD expense's amount and merchant.

Employee - OldDot

1. Navigate to the report with the expense.
2. Delete the expense from the report.

Employee - NewDot

1. As the employee in NewDot - navigate to the workspace chat.
2. Verify that the report which had the expense removed displays $0.00 amount now.
3. Verify that the merchant is not shown anymore underneath the amount. ⬇️
   Note: If the change did not propagate yet, navigate to another LNH report then return back to the workspace chat in order for the report data to re-fetch.

Do we agree 👍 or 👎.

[deetergp]

Just a couple days out from the hold expiring 👍

[garrettmknight]

Payment Summary:

• Contributor: @ikevin127 $250 paid via Upwork
• Reviewer: @akinwale $250 paid via Upwork

[garrettmknight]

@akinwale can you finish the checklist when you get a chance?

[akinwale]

@garrettmknight Looks like @ikevin127 already completed it: #40980 (comment)

@ikevin127 The bot tends to get confused when it's also a C+ acting as a contributor so it tags both. The C+ who did the review is responsible for completing the checklist.

[garrettmknight]

Ah, gotcha, thanks!