-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PAYMENT DUE 6/18 - $250][Live Markdown] Multiple italics markdown in a message are not shown correctly #41110
Comments
Triggered auto assignment to Contributor-plus team member for initial proposal review - @sobitneupane ( |
Triggered auto assignment to @slafortune ( |
Duplicated issue #40571 |
So this happens because of I had discussion with @ikevin127 for this. https://expensify.slack.com/archives/C01GTK53T8Q/p1713721057329569 So solution is to change the parsing logic. (ie using cc @jjcoffee |
@slafortune, @sobitneupane, @thienlnam Whoops! This issue is 2 days overdue. Let's get this updated quick! |
closing duplicate |
@slafortune I am not very confident that #40571 will solve this issue. @jjcoffee Will this issue be solved by the selected proposal in #40571? |
@slafortune @sobitneupane I made a mistake... This is related to ExpensiMark parsing Markdown to HTML, and above duplicated ticket is to parsing HTML to Markdown... So it is not a duplicated issue... I am sorry for this and will submit the proposal now. |
@sobitneupane Yeah this isn't a duplicate as far as I can tell. |
ProposalPlease re-state the problem that we are trying to solve in this issue.Multiple italics markdown in a message are not shown correctly What is the root cause of that problem?
This regex does not parse following italics when there is And found one more thing, What changes do you think we should make in order to solve the problem?My solution is to ignore I already completed this and passed all tests. What alternative solutions did you explore? (Optional)n/a |
@slafortune, @sobitneupane, @thienlnam Huh... This is 4 days overdue. Who can take care of this? |
Will review the proposal shortly |
Thanks for your proposal @skyweb331 What will be the result of following input after applying your solution? |
Results are here. Live editor still does not work and it seems this is duplicated issue - #41107 |
@skyweb331 |
@tomekzaw Maybe, because my update is not applied to Will you let me know how can I update |
Will check on this internally and update. |
|
@slafortune, @skyweb331, @sobitneupane, @thienlnam Huh... This is 4 days overdue. Who can take care of this? |
@sobitneupane looks like this was deployed to production last week. |
@skyweb331 |
Did you test it on production? I tested it but it does not work on production. Maybe because of cache??? |
@slafortune, @skyweb331, @sobitneupane, @thienlnam Uh oh! This issue is overdue by 2 days. Don't forget to update your issues! |
@sobitneupane Do we have to wait for regression period or already passed it? |
The 18th will cover the regression period - so I can pay this out tomorrow. |
@skyweb331 I am not able to locate your UpWorks profile - can you please link that here? |
@slafortune My upwork profile link is https://www.upwork.com/freelancers/~019e5171478d2a22f7 |
@skyweb331 offer sent - https://www.upwork.com/nx/wm/offer/102797646 |
@skyweb331 paid $250 via upworks |
$250 approved for @sobitneupane |
Actual
Expected
All the phrases in between
_message_
should be italicized correctlycc @tomekzaw
Issue Owner
Current Issue Owner: @sobitneupaneThe text was updated successfully, but these errors were encountered: