Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[$250] Track expense- Unable to close Track expense RHP with ESC key after dismissing education modal #41134

Closed
2 of 6 tasks
m-natarajan opened this issue Apr 27, 2024 · 31 comments
Closed
2 of 6 tasks

[$250] Track expense- Unable to close Track expense RHP with ESC key after dismissing education modal #41134

m-natarajan opened this issue Apr 27, 2024 · 31 comments
Assignees
@dragnoir @rushatgabhane @jasperhuangg @lschurr @srikarparsi
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor

Comments

@m-natarajan
Copy link

m-natarajan commented Apr 27, 2024 •
edited by jasperhuangg
Loading

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Issue found when validating #40675
Version Number: 1.4.67-0
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail: n/a
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause internal team
Slack conversation:

Action Performed:

  1. Go to staging.new.expensify.com
  2. Go to FAB.
  3. Select Track Expense.
  4. Press ESC to dismiss the education modal.
  5. Press ESC again.

Expected Result:

Track expense RHP will be dismissed.

Actual Result:

Unable to dismiss Track expense RHP with ESC key after dismissing the education modal.

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6463572_1714204673665.20240427_155503.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01e2861236b6929afb
  • Upwork Job ID: 1784977082974711808
  • Last Price Increase: 2024-04-29
Issue OwnerCurrent Issue Owner: @lschurr
@m-natarajan m-natarajan added DeployBlockerCash This issue or pull request should block deployment Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Apr 27, 2024
@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Apr 27, 2024

Triggered auto assignment to @youssef-lr (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Apr 27, 2024

Triggered auto assignment to @lschurr (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@github-actions github-actions bot added Engineering Hourly KSv2 and removed Daily KSv2 labels Apr 27, 2024
@github-actions GitHub Actions
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@m-natarajan
Copy link
Author

@lschurr FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

@github-actions github-actions bot mentioned this issue Apr 27, 2024
Closed
63 tasks
@m-natarajan
Copy link
Author

We think this bug might be related to #vip-vsb

@thienlnam
Copy link
Contributor

Doesn't seem like it needs to be a blocker

@thienlnam thienlnam added Daily KSv2 and removed DeployBlockerCash This issue or pull request should block deployment Hourly KSv2 labels Apr 28, 2024
@lschurr lschurr added the External Added to denote the issue can be worked on by a contributor label Apr 29, 2024
@melvin-bot melvin-bot bot changed the title Track expense- Unable to close Track expense RHP with ESC key after dismissing education modal [$250] Track expense- Unable to close Track expense RHP with ESC key after dismissing education modal Apr 29, 2024
@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Apr 29, 2024

Job added to Upwork: https://www.upwork.com/jobs/~01e2861236b6929afb

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Apr 29, 2024
@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Apr 29, 2024

Triggered auto assignment to Contributor-plus team member for initial proposal review - @allroundexperts (External)

@thienlnam
Copy link
Contributor

Also added from #40675
cc @tienifr @rushatgabhane @srikarparsi

@thienlnam thienlnam removed External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors labels Apr 29, 2024
@mallenexpensify mallenexpensify added the Awaiting Payment Auto-added when associated PR is deployed to production label Jun 13, 2024
@mallenexpensify mallenexpensify added Daily KSv2 and removed Weekly KSv2 Overdue labels Jun 13, 2024
@mallenexpensify
Copy link
Contributor

Unsure why automation wasn't working, this is due, can you pay @lschurr ? Thx
#41866 (comment)

@lschurr
Copy link
Contributor

lschurr commented Jun 13, 2024 •
edited
Loading

Payment summary:

@melvin-bot melvin-bot bot removed the Overdue label Jun 13, 2024
@lschurr
Copy link
Contributor

lschurr commented Jun 13, 2024

All set!

@lschurr lschurr closed this as completed Jun 13, 2024
@JmillsExpensify
Copy link

$250 approved for @rushatgabhane

@allroundexperts
Copy link
Contributor

Hm... I was actually assigned this issue and reviewed the proposal as well. Does someone know why I wasn't assigned the PR?

@jasperhuangg
Copy link
Contributor

Based on the history in this issue it looks like this issue was never linked in the PR which is probably why the automation failed? @rushatgabhane @dragnoir Do you guys mind updating the PR to link this issue please?

cc @thienlnam

@jasperhuangg jasperhuangg reopened this Jul 20, 2024
@melvin-bot melvin-bot bot added the Overdue label Jul 20, 2024
@jasperhuangg
Copy link
Contributor

Not overdue just sorting out some payment/automation weirdness

@lschurr
Copy link
Contributor

lschurr commented Jul 22, 2024

Just a bump on this @jasperhuangg @thienlnam

@melvin-bot melvin-bot bot removed the Overdue label Jul 22, 2024
@jasperhuangg
Copy link
Contributor

@lschurr I think we just need to pay out @allroundexperts and close this out. They reviewed proposals for this issue. Since something went wrong with the Github automation then they couldn't have done anything differently.

@mallenexpensify
Copy link
Contributor

I think 50% for payment to @allroundexperts makes sense, since they only reviewed the initial proposals and didn't have to work on and test the PR.

@allroundexperts
Copy link
Contributor

Agreed with Matt!

@lschurr
Copy link
Contributor

lschurr commented Jul 22, 2024

Great, I updated the payment summary here: #41134 (comment)

@melvin-bot melvin-bot bot added the Overdue label Jul 25, 2024
@lschurr
Copy link
Contributor

lschurr commented Jul 25, 2024

Closing since the payment summary is complete.

@lschurr lschurr closed this as completed Jul 25, 2024
@melvin-bot melvin-bot bot removed the Overdue label Jul 25, 2024
@JmillsExpensify
Copy link

$125 approved for @allroundexperts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dragnoir dragnoir

@rushatgabhane rushatgabhane

@jasperhuangg jasperhuangg

@lschurr lschurr

@srikarparsi srikarparsi

Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor
Projects
No open projects
[#whatsnext] #vip-vsb
Status: CRITICAL
Milestone
No milestone
Development

No branches or pull requests