[HOLD for payment 2024-05-09] [HOLD for payment 2024-05-08] Thread - Chat flickers after clicking on link in thread header

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.68-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4524207
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team

Action Performed:

1. Open the app and log in
2. Open a report with a long history
3. Send a message and start a thread or assign a task
4. Click on the link in the header to return to the chat

Expected Result:

There should be no flickering when returning to the chat

Actual Result:

The chat flickers when user is returned from thread

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6466139_1714443571994.Recording__448.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @isabelastisser

[melvin-bot]

Triggered auto assignment to @Gonals (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

Triggered auto assignment to @isabelastisser (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[izarutskaya]

@isabelastisser I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

[izarutskaya]

We think this issue might be related to the #vip-vsb.

[izarutskaya]

Production

bandicam.2024-04-30.10-26-58-142.mp4

[francoisl]

I think this comes from #40624, reverting that PR locally fixes the issue.
cc @bernhardoj @abdulrahuman5196 if you have an idea how to resolve without reverting.

[francoisl]

Going to go ahead with a revert to unblock the deploy for now, let's look into a long-term solution down the line.

[abdulrahuman5196]

Going to go ahead with a revert to unblock the deploy for now, let's look into a long-term solution down the line.

Thank you for taking care of revert. We will circle back on the GH to fix the regression issue.
cc: @bernhardoj

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.68-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] Revert PR #40624, fix flickering when switching from task to parent #41352

If no regressions arise, payment will be issued on 2024-05-08. 🎊

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.69-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] Revert PR #40624, fix flickering when switching from task to parent #41352

If no regressions arise, payment will be issued on 2024-05-09. 🎊

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@francoisl] The PR that introduced the bug has been identified. Link to the PR: Fix multiple open report call when report screen is mounted #40624
• [@francoisl] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@francoisl] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@francoisl] Determine if we should create a regression test for this bug. - No
• [@francoisl] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@isabelastisser] Link the GH issue for creating/updating the regression test once above steps have been agreed upon: N/A

[isabelastisser]

@francoisl, can I close this issue, or do you need to complete the BZ list above first?

[francoisl]

All good, there's already a follow-up PR to address the regression, let's close.