-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[$250] iOS - Thread - Chat is scrolled up when opening message in thread #41532
Comments
Triggered auto assignment to @francoisl ( |
Triggered auto assignment to @kevinksullivan ( |
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
|
@kevinksullivan FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors |
Something kind of similar is already happening on the production version, where the view doesn't scroll down after you send a new message. The keyboard not opening in this case looks is not reproducible on production though, let's see if we can identify the root cause. Screen.Recording.2024-05-02.at.1.12.29.PM.mov |
Job added to Upwork: https://www.upwork.com/jobs/~01d93082b948cabfef |
Triggered auto assignment to Contributor-plus team member for initial proposal review - @thesahindia ( |
Tested locally against the current production version 1.4.69-2 and the keyboard also doesn't open on new threads, so it doesn't appear to be a regression in the current checklist. I also can't consistently reproduce the issue where the initial thread view isn't scrolled, which makes it hard to identify when the issue started happening. Going to demote for now and keep open as an external issue. |
Thread - Chat is scrolled up when opening message in thread
|
📣 @mosesbabu! 📣
|
Contributor details |
✅ Contributor details stored successfully. Thank you for contributing to Expensify! |
@francoisl the keyboard doesn't open is being handled in #41402 |
So is the issue being looked into or I can take a look as a contributor
…On Friday 3 May 2024, Bernhard Owen Josephus ***@***.***> wrote:
@francoisl <https://github.com/francoisl> the keyboard doesn't open is
being handled in #41402 <#41402>
—
Reply to this email directly, view it on GitHub
<#41532 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AKQTBI4PFHGE7FMV5KI2UTDZAM237AVCNFSM6AAAAABHEKJF4SVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAOJSGQ2DMMJSGI>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Contributor details |
✅ Contributor details stored successfully. Thank you for contributing to Expensify! |
@francoisl, @kevinksullivan, @thesahindia Huh... This is 4 days overdue. Who can take care of this? |
I can take on it
…On Wed, May 8, 2024, 9:15 PM melvin-bot[bot] ***@***.***> wrote:
@francoisl <https://github.com/francoisl>, @kevinksullivan
<https://github.com/kevinksullivan>, @thesahindia
<https://github.com/thesahindia> Huh... This is 4 days overdue. Who can
take care of this?
—
Reply to this email directly, view it on GitHub
<#41532 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AKQTBI6N3T3GAFDEKFRMDO3ZBJTVJAVCNFSM6AAAAABHEKJF4SVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMBRGE2TIMZVGU>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
@thesahindia , can you review the above and provide an update plz? |
Also @mosesbabu can you please use the proposal template format and repost your proposal? |
Not overdue melv. |
@francoisl, @kevinksullivan, @thesahindia 6 days overdue. This is scarier than being forced to listen to Vogon poetry! |
Can we confirm if this is still reproducible? It looks like it's fixed for me on v1.4.72-1 Screen.Recording.2024-05-10.at.3.11.19.PM.mov |
Issue not reproducible during KI retests. (First week) |
@francoisl, @kevinksullivan, @thesahindia 10 days overdue. Is anyone even seeing these? Hello? |
Is it assigned if not I can look at it
…On Tue, May 14, 2024, 9:17 PM melvin-bot[bot] ***@***.***> wrote:
@francoisl <https://github.com/francoisl>, @kevinksullivan
<https://github.com/kevinksullivan>, @thesahindia
<https://github.com/thesahindia> 10 days overdue. Is anyone even seeing
these? Hello?
—
Reply to this email directly, view it on GitHub
<#41532 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AKQTBIYDO2SQ3VS7KF4J7FTZCJIMBAVCNFSM6AAAAABHEKJF4SVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMJQHA2DANRWGM>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Hi @mosesbabu, no the issue is not assigned, but for the future please review https://github.com/Expensify/App/blob/main/contributingGuides/CONTRIBUTING.md to see how to make proposals. Thanks! That said, the issue can't be reproduced anymore, so I'm going to close this. |
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 1.4.70-0
Reproducible in staging?: y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @danielrvidal
Slack conversation: expensify.slack.com/archives/C049HHMV9SM/p1714137578957479
Action Performed:
Launch New Expensify app.
Go to chat.
Send a message.
Long tap on the message > Reply in thread.
Expected Result:
The chat will be scrolled down with keyboard open and compose box focussed
Actual Result:
The chat view is at the top in the thread and keyboard is not open
Workaround:
unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop
Screenshots/Videos
Add any screenshot/video evidence
Bug6469277_1714677182947.RPReplay_Final1714676988.mp4
View all open jobs on GitHub
Issue Owner
Current Issue Owner: @thesahindiaThe text was updated successfully, but these errors were encountered: