Taxes - Tapping on Save button does not save the tax name when keyboard is up

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.71-0
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause internal team
Slack conversation:

Action Performed:

1. Go to staging.new.expensify.com
2. Go to workspace settings.
3. Go to Taxes.
4. Tap Add rate.
5. Tap Name.
6. Enter a name.
7. With keyboard still up, tap Save button.

Expected Result:

The name is saved.

Actual Result:

The keyboard is dismissed but app remains on the same page.

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6473652_1715080173288.tax_save.mp4

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @iwiznia (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

Triggered auto assignment to @sonialiap (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[m-natarajan]

@sonialiap FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

[m-natarajan]

We think this bug might be related to #wave-collect - Release 1

[Krishna2323]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Taxes - Tapping on Save button does not save the tax name when keyboard is up

What is the root cause of that problem?

The TextInput is inside ScrollView and the child won't receive won't receive the tap when input is focused, only the text input will get blurred. This is due to keyboardShouldPersistTaps prop.

App/src/components/TextPicker/TextSelectorModal.tsx

Lines 43 to 46 in 222419b

	<ScrollView contentContainerStyle={[styles.flex1, styles.mh5, styles.mb5]}>
	<View style={styles.flex1}>
	<TextInput
	// eslint-disable-next-line react/jsx-props-no-spreading

What changes do you think we should make in order to solve the problem?

We need to pass keyboardShouldPersistTaps="always/handled" to ScrollView. Or we can add keyboardShouldPersistTaps="always/handled" in ScrollView as default and can accept a prop to change it.

What alternative solutions did you explore? (Optional)

[Krishna2323]

I don't think this is a regression, previously the save button was hidden behind the keyboard and this PR fixed it and now we are able see the save button and click it.

[iwiznia]

It seems like that PR was not implemented right, since it should be saving the data when tapping on the save button, even with the keyboard open, otherwise the PR is kind of useless if you still need to tap twice. cc @dukenv0307

I agree though that this does not need to be a blocker.

[iwiznia]

Closing in favor of the OG issue #38497