Deploy Checklist: New Expensify 2024-05-07

[github-actions]

Release Version: 1.4.71-6
Compare Changes: production...staging

This release contains changes from the following pull requests:

• Make Store.subscribe return a simple ID like subscribeToState #12
• Fix - Domain Card - User can edit the date in expenses related to the assigned domain card  #39244
• Fixes for redesign thread ancestry feature #39343
• Polish for one-transaction view  #39472
• Infinite loading on video preview before sending video #39755
• Use 'isSearchingForReports' to control green circular loading #39865
• Create Remove-Members.md #39961
• feature: silently update desktop app #40253
• [HOLD] Implement Uneven Splits #40386
• [TS migration] Improve ref types #40698
• implement offline behaviour for updateGroupChatMemberRole #40700
• Improve UX of modifying single line text inputs #40757
• Fix receipt preview in confirmation page #40763
• Save logs data in downloads and show meaningful path #40777
• implement offline behaviour for updateGroupChatAvatar #40884
• [App PR #41278] Prevent users from disabling accounting feature if there is active accounting connection #40940
• Allow searching new user in chat finder page #40962
• fix: iOS - Profile - Missing circle at the center of avatar preview when uploading new avatar. #40972
• Move Leave button into a row of the Report Details page #40979
• Add automatic test for tag API commands #41016
• Add support for DISMISSED_VIOLATION system message #41051
• fix: restore sensor animation #41103
• [Fix]: Regex and Limit of Room Title were limited to 79 characters due to BE constraints #41123
• Fix cannot create task for new user via [] method #41171
• Fix scan in progress isn't shown in room LHN last message when there is a scan in progress report preview #41187
• Fixed terms visualization on mweb android #41234
• [No QA] Update rates to match backend for latest research #41269
• Don't render money request description as markdown in money request preview #41291
• Fix main composer shows briefly when opening emoji picker #41298
• Implement Search ListItems and table header #41347
• fix: Can't drag mouse to select text in input. #41381
• fix: Status expiry time does not show correctly when hovering the user in the chat report #41383
• Save button does not move above the keyboard when keyboard is up #41392
• Update order of onboarding choices #41400
• Fix a left group chat still shows in the search page #41405
• [Feat] Implement room mention actionable whisper #41406
• fix app does not go offline when Force offline #41412
• Handle Xero beta in NewDot #41416
• Modify the condition to calculate amount again #41430
• DOCS: Create Set-timezone.md #41439
• DOC: Create Change-or-add-email-address.md #41447
• DOCS: Create Add-personal-information.md #41450
• DOCS: Create Update-your-profile-status.md #41454
• DOCS: Create Update-your-name.md #41456
• DOCS: Create Update-your-pronouns.md #41457
• Fix QBO config types + fix inputs in config pages #41463
• feat: create workspace at the end of the actionable whisper #41465
• Update Quick Action Button icons #41469
• [HelpDot] add connections hub for newDot #41470
• Handle deleted reports for Quick Actions #41474
• [Wave Collect][Xero] Main advanced settings page #41475
• Fix Mapbox open to ocean on the first render #41480
• Fix blank space remains in place after deleting the last message in a chat #41482
• Fix group chat last message doesn't show the sender display name #41483
• [VIP-Travel] Create a New Travel Page and Terms and Conditions Modal (NewDot) #41493
• Update redirects.csv #41498
• [Fix]: Inconsistency in saving values ending with decimal point in distance rate and IOU #41503
• Feat: Invoice collection account selector page #41511
• Remove a custom hook and usage of unnecessary HOC #41513
• Prevent deletion of categories and tags #41517
• fix: show category picker when creating invoices #41524
• Fix Preferred exporter page + country crash #41530
• Fix/improve chart of accounts import page #41547
• Exclude guides from preferred exporter #41548
• Fix patch for new rnmapbox-maps version #41556
• [Wave Collect] [Xero] Fix padding issue in ConnectionLayout #41561
• Update Billing-Overview.md #41576
• [Group Chats] - Fix: Invalid group chat name error still persists after clearing group name text #41588
• Add simple sorting #41590
• Fix: Group counter in split preview and invite member page blends with the background #41592
• Update onboarding flow #41593
• Create Unlock-a-Business-Bank-Account.md #41605
• fix - Chat - "No activity yet" is seen under a thread with replies #41608
• Using dismissModal function instead of goBack If It is the RHP #41611
• Fix layout on ios #41615
• [No QA] Remove unused code from DateUtils #41616
• Allow user to navigate to detail page for transaction thread #41639
• fix Top and bottom borders of header status #41643
• fix: When creating a new workspace Categories section is animated. #41646
• [Wave Collect][Xero] Fix disconnect Xero #41657
• Fix policy accounting connection title #41660
• Add import text input clear button #41661
• Revert "fix: show category picker when creating invoices" #41671
• Add request time in logs #41709
• [CP Staging] Uneven splits follow up #41717
• [CP Staging] fix: Expense - Console error shows up when opening date editor in transaction thread #41788
• [CP Staging] Revert "Move Leave button into a row of the Report Details page" #41818
• [CP Staging] Reverts #41187 #41820
• [CP Staging] Use whisperedTo instead of whisperedToAccountIDs #41856
• [CP Staging] Fix typo #41871

Internal QA:

• Add support for MERGED_WITH_CASH_TRANSACTION system message #41477 - @francoisl
• [QAB] Store GPS coordinate when using the QAB to scan a receipt #41208 - @blimpich

Deploy Blockers:

• [HOLD for payment 2024-06-11] [$250] [Uneven Splits] [Polish] Android - Split amount input does not animate smoothly #41751
• [HOLD] Split - Split preview shows 0 instead of "Your split $0.00" when split amount is 0.00 #41752
• [HOLD for payment 2024-05-22] [HOLD for payment 2024-05-20] Group chat - Group chat preview in LHN shows __ fake __ #41753
• [QBO] Chart of accounts page does not fit in RHP properly #41754
• Taxes - Tapping on Save button does not save the tax name when keyboard is up #41755
• Track expense - New workspace name created from whisper changes to "New policy" #41756
• [HOLD for payment 2024-05-20] Split scan - Split preview does not show individual split amount under "Split amounts" list #41758
• New Search - Header changes from Expensify/Search to Expenses when opening an expense #41759
• [HOLD for payment 2024-05-20] [$250] Expense - Console error shows up when opening date editor in transaction thread #41760
• [HOLD for payment 2024-05-20] Split - Split amount does not automatically recalculate afte reselecting split members #41761
• [HOLD for payment 2024-06-20] [$250] [Uneven Splits] [Polish] Android - Cursor appears in front of digit when highlighting amount and entering digit #41762
• [HOLD for payment 2024-07-24] [$250] [Uneven Splits] [Polish] Android - Split amount is not reset when tapping Reset button when keyboard is up #41763
• [HOLD for payment 2024-06-05] [$250] mweb - Split - Split amount input is partially input and scrollable horizontally #41766
• [HOLD for payment 2024-06-03] [$250] Track expense - Categorize it - No search bar in category list when there is no workspace #41773
• [HOLD for payment 2024-08-02] [HOLD for payment 2024-07-25] [$500] iOS - Room - Send message button stops functioning after leaving room #41780
• [$250] mWeb - Search - Tapping expensify via switcher from new search page directed to hmm not here page #41790
• iOS - Track expense - Categorize - Scroll bar is on the left in category list #41791
• [Search v1] "__fake__" is displayed at From and To fields for split expenses #41796
• [HOLD #41020] New search - Console error shows up when returning to previous page from Hold request in RHP #41797
• Expense - Share code option is missing in expense report and transaction thread #41799
• [HOLD for payment 2024-06-13] [$250] [Uneven Splits] [Polish] - User profile opens every time the cursor is dragged outside input and released #41803
• Split - Inconsistency in currency symbol in confirmation page and split details page #41824
• [HOLD on 40768] [$250] Task - Background overlaps task details after deleting task #41825
• [HOLD for payment 2024-06-06] [$250] IOU - "Members" appears in IOU details page and then disappears after a few seconds #41832
• Chat - Mention whisper returns, incorrect mention buttons #41833
• [$250] [HOLD for payment 2024-06-03] [Guided Setup Stage 2] Multiple workspaces are created when navigating back and changing the business name #41838
• [QBO] "must categorize all expenses" toggle is off and Tags are not imported #41844
• [HOLD for payment 2024-08-27] [$250] Web - Split - Enter and CMD+Enter open user profile instead of splitting expense #41848
• [HOLD for payment 2024-06-13] [$250] Connect Bank account - Background is slightly touching "Numbers" in Onfido Flow #41851

Deployer verifications:

• I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
• I checked Firebase Crashlytics and verified that this release does not introduce any new crashes. More detailed instructions on this verification can be found here.
• I checked GitHub Status and verified there is no reported incident with Actions.

cc @Expensify/applauseleads

[OSBotify]

🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/1.4.71-0 🚀

[kbecciv]

Prod PRs #41439, #41447, #41450, #41454, #41456, #41457, #41470, #41605, checking Off

[grgia]

Closed #41759

[amyevans]

Demoted #41766

[blimpich]

Demoted #41773

[jasperhuangg]

Closed #41791

[marcaaron]

Checking off #41752 as it's a new feature and @youssef-lr is tracking

[roryabraham]

Demoted #41796, not a blocker

[marcaaron]

Checking off #41756 as it is minor and unable to repro

[marcaaron]

Checking off #41762 as it is polish for Uneven Splits project

[marcaaron]

Checking off #41780 as it is an uncommon user action

[francoisl]

Tagging @yuwenmemon to internal QA #41477 because he has a card linked already

[marcaaron]

Why did melvin assign @blimpich ? 🤔

[marcaaron]

Checking off #41803 as it seems minor

[francoisl]

Why did melvin assign @blimpich ? 🤔

It was because of the internal QA issues.

[marcaaron]

Ohhh ok, makes sense 🤦

[marcaaron]

Checking off #41797 as the feature is not really publicly accessible in any obvious way yet

[marcaaron]

Checking off #41754 as the feature is under a beta

[kbecciv]

TR is 33% left

#39244 is failing with #37728
#39343 - pending verification on Desktop and IOS app
#39472 is failing with #39450, left comment #39472 (comment)
#39865 - pending verification on mWeb and IOS app
#40253 - pending verification on all platforms
#40386 - pending verification on mWeb and Desktop
#40763 - pending verification on Android app
#40777 - pending verification on Web and Desktop
#40884 is failing with #41770
#40940 - pending verification on all platforms
#41051 - pending verification
#41187 - pending verification on mWeb
#41234 - pending verification on all platforms
#41291 - pending verification on mWeb, Desktop and IOS app
#41347 - pending verification on mWeb and Android
#41406 - pending verification
#41416 - pending verification on mWeb and Android
#41465 - pending verification on Web, mWeb and Desktop
#41474 - pending verification on all platforms
#41475 - pending verification all platforms
#41480 - pending verification on mWeb
#41511 - pending verification all platforms
#41513 - pending verification all platforms
#41524 is failing with #41281, left comment #41524 (comment)
#41561 - pending verification all platforms
#41615 is failing with #41796 on Web, mWeb, Android and IOS app
#41639 is pending verification

Deploy Blockers:
#41753
#41758
#41760
#41761
#41799

[gijoe0295]

#41524 was reverted. Can be checked off.

[yuwenmemon]

SmartScan is taking forever for the internalQA of: #41477

[marcaaron]

Checking off #41760 as we CP'd a fix

[marcaaron]

Checking off 41761 and 41758

[yuwenmemon]

Checking off #41477 - internal QA passed

[marcaaron]

Reverted the PR that caused #41799

[marcaaron]

Checking off #41753 as we reverted the offending PR

[mvtglobally]

TR is 10% left. We will provide summary in the morning EST

#39244 is failing with #37728
#39343 - pending verification on Desktop and IOS app
#39472 is failing with #39450, left comment #39472 (comment)
#39865 - Is failing with #41787. repro in PROD checking off
#40253 - pending verification on Desktop with build push
#40386 - pending verification on Desktop
#40884 is failing with #41770
#41051 - pending verification
#41406 - pending verification
#41465 - pending verification on Web, mWeb and Desktop
#41474 - pending verification on all platforms
#41475 - pending verification all platforms
#41511 - pending verification all platforms
#41513 - pending verification all platforms
#41524 is failing with #41281, left comment #41524 (comment)
#41561 - pending verification all platforms
#41615 is failing with #41796 on Web, mWeb, Android and IOS app
Checking CPs too

[youssef-lr]

Checking off #41717 after testing it

[cristipaval]

Demoted #41824

[kbecciv]

TR is completed!

#39244 is failing with #37728
#39472 is failing with #39450, left comment #39472 (comment)
#40253 left comment #40253 (comment)
#40884 is failing with #41770
#41051 left comment #41051 (comment)
#41406 is failing with #41833
#41513 is failing with #41844
#41524 is failing with #41281, left comment #41524 (comment)
#41615 is failing with #41796 on Web, mWeb, Android and IOS app

Deploy Blockers:
#41825
#41832
#41833
#41838
#41844

[rlinoz]

Demoting #41832

[amyevans]

Demoted #41838

[yuwenmemon]

Checking off #41051

[carlosmiceli]

Checking off #41851

[marcaaron]

Closed #41833

[marcaaron]

Demoted #41825

[marcaaron]

Demoting #41848

[marcaaron]

Checking off #41844 as it's behind a beta

[marcaaron]

There's some new crash here. I don't believe we've made any changes to live markdown. Not blocking on it, but putting it on your radar @thienlnam.

[marcaaron]

Almost ready to send. Holding the deploy so we can get this urgent fix out.

[thienlnam]

Thanks, going to create an issue to track it - #41867

[marcaaron]