Allow searching new user in chat finder page #40962

nkdengineer · 2024-04-25T06:29:59Z

Details

Allow searching new user in chat finder page

Fixed Issues

$ #40731
PROPOSAL: #40731 (comment)

Tests

Click search icon in LHN to open the finder page
Type any email address of a new user who does not have expensify account
Verify that an option is appeared
Click on this option and verify that a new report is created and we're able to start chat with this user

Verify that no errors appear in the JS console

Offline tests

Same as above

QA Steps

Click search icon in LHN to open the finder page
Type any email address of a new user who does not have expensify account
Verify that an option is appeared
Click on this option and verify that a new report is created and we're able to start chat with this user

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

Screen.Recording.2024-04-25.at.13.20.21.mov

iOS: Native

Screen.Recording.2024-04-25.at.13.26.52.mov

iOS: mWeb Safari

Screen.Recording.2024-04-25.at.13.19.49.mov

MacOS: Chrome / Safari

Screen.Recording.2024-04-25.at.13.18.30.mov

MacOS: Desktop

Screen.Recording.2024-04-25.at.13.28.48.mov

melvin-bot · 2024-04-25T06:30:13Z

@sobitneupane Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

sobitneupane · 2024-04-25T07:03:37Z

Over to you @DylanDylann

DylanDylann · 2024-04-25T07:08:46Z

This PR is my son, I will take it

DylanDylann · 2024-04-25T07:13:43Z

@nkdengineer lint error

nkdengineer · 2024-04-25T08:47:23Z

@DylanDylann Fixed.

src/libs/OptionsListUtils.ts

DylanDylann · 2024-04-25T12:41:24Z

@nkdengineer I give some comments, Let's address it

nkdengineer · 2024-04-26T10:19:05Z

@DylanDylann Updated, please help to check again.

DylanDylann · 2024-04-29T06:58:30Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Screen.Recording.2024-04-30.at.23.21.39.mov

Android: mWeb Chrome

Screen.Recording.2024-04-30.at.23.20.38.mov

iOS: Native

Screen.Recording.2024-04-30.at.23.21.11.mov

iOS: mWeb Safari

Screen.Recording.2024-04-30.at.23.19.53.mov

MacOS: Chrome / Safari

Screen.Recording.2024-04-30.at.23.17.31.mov

MacOS: Desktop

Screen.Recording.2024-04-30.at.23.18.40.mov

DylanDylann · 2024-04-29T06:59:36Z

src/libs/OptionsListUtils.ts

-            },
-        };
-        userToInvite = createOption([optimisticAccountID], personalDetailsExtended, null, reportActions, {
+    if (noOptions || noOptionsMatchExactly) {


@nkdengineer Should we move this check to getUserToInviteOption?

I think we shouldn't because this check is not the same in filterOptions function.

@nkdengineer
We can pass one more param like

shouldGetOptionToInvite={noOptions || noOptionsMatchExactly}

similar to another place

@DylanDylann Agree, updated to add this param.

DylanDylann · 2024-04-29T07:08:13Z

src/libs/OptionsListUtils.ts

+     */
+    if (recentReports.length === 0) {
+        userToInvite = getUserToInviteOption({
+            searchValue,


Why other params is unnecessary here?

This is unnecessary here because when we get the search option via getSearchOptions, the other params is default value.

nkdengineer · 2024-04-30T14:49:43Z

@DylanDylann Please help to check again when you have time.

marcaaron · 2024-04-30T22:39:32Z

src/libs/OptionsListUtils.ts

+     * - The searchValue is a valid email or phone number
+     * - The searchValue isn't the current personal detail login
+     * - We can use chronos or the search value is not the chronos email
+     */


Can you please move this to a method doc instead of in the middle of the function?

src/libs/OptionsListUtils.ts

marcaaron · 2024-04-30T22:42:21Z

src/libs/OptionsListUtils.ts

+            (parsedPhoneNumber.possible && Str.isValidE164Phone(LoginUtils.getPhoneNumberWithoutSpecialChars(parsedPhoneNumber.number?.input ?? '')))) &&
+        !optionsToExclude.find((optionToExclude) => 'login' in optionToExclude && optionToExclude.login === PhoneNumber.addSMSDomainIfPhoneNumber(searchValue).toLowerCase()) &&
+        (searchValue !== CONST.EMAIL.CHRONOS || Permissions.canUseChronos(betas)) &&
+        !excludeUnknownUsers


Could we clean this up a bit more? This condition is hard to read as is. And we could avoid the comment block entirely by creating some variables that are a bit easier to parse.

@marcaaron I updated, please help to check again.

marcaaron · 2024-04-30T22:44:46Z

src/libs/OptionsListUtils.ts

+    const userToInvite = getUserToInviteOption({
+        searchValue,
+        betas,
+        shouldGetOptionToInvite: recentReports.length === 0,


Methods usually should not have "canceling" arguments (maybe there are some extreme exceptions). But it looks like we can just set userToInvite to null?

It's like having a method called eatFood(doNotEatFood) (can you tell it's lunch time for me?) 😄

Methods usually should not have "canceling" arguments (maybe there are some extreme exceptions). But it looks like we can just set userToInvite to null?

Yes we can just set userToInvite to null.

Co-authored-by: Marc Glasser <marc.aaron.glasser@gmail.com>

marcaaron · 2024-05-03T01:18:10Z

src/libs/OptionsListUtils.ts

+    const isValidPhoneNumber = parsedPhoneNumber.possible && Str.isValidE164Phone(LoginUtils.getPhoneNumberWithoutSpecialChars(parsedPhoneNumber.number?.input ?? ''));
+    const isInOptionToExclude =
+        optionsToExclude.findIndex((optionToExclude) => 'login' in optionToExclude && optionToExclude.login === PhoneNumber.addSMSDomainIfPhoneNumber(searchValue).toLowerCase()) !== -1;
+    const isChronosEmail = searchValue === CONST.EMAIL.CHRONOS;


Thanks looks soooooo much better ❤️

OSBotify · 2024-05-03T01:26:32Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-05-09T02:10:31Z

🚀 Deployed to production by https://github.com/marcaaron in version: 1.4.71-6 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

Allow searching new user in chat finder page

a3809cb

nkdengineer marked this pull request as ready for review April 25, 2024 06:30

nkdengineer requested a review from a team as a code owner April 25, 2024 06:30

melvin-bot bot requested review from sobitneupane and removed request for a team April 25, 2024 06:30

nkdengineer mentioned this pull request Apr 25, 2024

[$500] HIGH: [Reliability] Unable to search and start chat with a new user #40731

Closed

6 tasks

fix lint

ddac1ef

DylanDylann reviewed Apr 25, 2024

View reviewed changes

src/libs/OptionsListUtils.ts Outdated Show resolved Hide resolved

src/libs/OptionsListUtils.ts Outdated Show resolved Hide resolved

nkdengineer added 2 commits April 26, 2024 16:58

Merge branch 'main' into fix/40731

00c1f3e

dry create user to invite option

2b37da2

DylanDylann reviewed Apr 29, 2024

View reviewed changes

nkdengineer added 2 commits April 30, 2024 21:44

merge main

a2c2f8e

fix ts check

d9f71f1

add shouldGetOptionToInvite param

73fe334

DylanDylann approved these changes Apr 30, 2024

View reviewed changes

melvin-bot bot requested a review from marcaaron April 30, 2024 17:00

marcaaron requested changes Apr 30, 2024

View reviewed changes

nkdengineer and others added 3 commits May 2, 2024 12:29

Update src/libs/OptionsListUtils.ts

2bd5401

Co-authored-by: Marc Glasser <marc.aaron.glasser@gmail.com>

Merge branch 'main' into fix/40731

9cac55c

refactor getUserToInviteOption function

23960ac

marcaaron approved these changes May 3, 2024

View reviewed changes

marcaaron assigned nkdengineer May 3, 2024

marcaaron merged commit a6299a1 into Expensify:main May 3, 2024
17 checks passed

github-actions bot mentioned this pull request May 7, 2024

Deploy Checklist: New Expensify 2024-05-07 #41716

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Allow searching new user in chat finder page #40962

Allow searching new user in chat finder page #40962

nkdengineer commented Apr 25, 2024

melvin-bot bot commented Apr 25, 2024

sobitneupane commented Apr 25, 2024

DylanDylann commented Apr 25, 2024

DylanDylann commented Apr 25, 2024

nkdengineer commented Apr 25, 2024

DylanDylann commented Apr 25, 2024

nkdengineer commented Apr 26, 2024

DylanDylann commented Apr 29, 2024 •

edited

Loading

DylanDylann Apr 29, 2024

nkdengineer Apr 30, 2024

DylanDylann Apr 30, 2024 •

edited

Loading

nkdengineer Apr 30, 2024

DylanDylann Apr 29, 2024

nkdengineer Apr 30, 2024

nkdengineer commented Apr 30, 2024

marcaaron Apr 30, 2024

marcaaron Apr 30, 2024

nkdengineer May 2, 2024

marcaaron Apr 30, 2024

nkdengineer May 2, 2024

marcaaron May 3, 2024

OSBotify commented May 3, 2024

OSBotify commented May 9, 2024

Allow searching new user in chat finder page #40962

Allow searching new user in chat finder page #40962

Conversation

nkdengineer commented Apr 25, 2024

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Apr 25, 2024

sobitneupane commented Apr 25, 2024

DylanDylann commented Apr 25, 2024

DylanDylann commented Apr 25, 2024

nkdengineer commented Apr 25, 2024

DylanDylann commented Apr 25, 2024

nkdengineer commented Apr 26, 2024

DylanDylann commented Apr 29, 2024 • edited Loading

Reviewer Checklist

Screenshots/Videos

Choose a reason for hiding this comment

Choose a reason for hiding this comment

DylanDylann Apr 30, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

nkdengineer commented Apr 30, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

OSBotify commented May 3, 2024

OSBotify commented May 9, 2024

DylanDylann commented Apr 29, 2024 •

edited

Loading

DylanDylann Apr 30, 2024 •

edited

Loading