Update onboarding flow #41593

DylanDylann · 2024-05-03T15:38:32Z

Details

Fixed Issues

$ #41589
PROPOSAL: NA

Tests

Verify that no errors appear in the JS console

Offline tests

QA Steps

Sign up with a new account
Click Manage my team's Expenses in the onboarding modal
Verify that the next question you're asked is for your business name
Enter your business name
Verify that the next question you're asked is for your personal name

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Screen.Recording.2024-05-03.at.22.47.13.mov

Android: mWeb Chrome

Screen.Recording.2024-05-03.at.22.45.32.mov

iOS: Native

Screen.Recording.2024-05-03.at.22.45.14.mov

iOS: mWeb Safari

Screen.Recording.2024-05-03.at.22.43.25.mov

MacOS: Chrome / Safari

Screen.Recording.2024-05-03.at.22.33.58.mov

MacOS: Desktop

Screen.Recording.2024-05-03.at.22.41.18.mov

melvin-bot · 2024-05-03T15:38:37Z

@ishpaul777 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

ishpaul777 · 2024-05-03T15:47:24Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

WhatsApp.Video.2024-05-03.at.10.54.52.PM.mp4

Android: mWeb Chrome

WhatsApp.Video.2024-05-03.at.10.55.02.PM.mp4

iOS: Native

Screen.Recording.2024-05-03.at.10.37.48.PM.mov

iOS: mWeb Safari

Screen.Recording.2024-05-03.at.10.40.40.PM.mov

MacOS: Chrome / Safari

Screen.Recording.2024-05-04.at.1.06.48.AM.mov

MacOS: Desktop

Screen.Recording.2024-05-03.at.10.58.31.PM.mov

DylanDylann · 2024-05-03T15:48:13Z

@ishpaul777 Uploaded all videos. All yours

DylanDylann · 2024-05-03T15:56:32Z

Oh wait a minute, I need to update something

DylanDylann · 2024-05-03T16:01:36Z

@ishpaul777 Explain for new commit: The business name is only visible if the user select the Manage Team option

github-actions · 2024-05-03T16:13:31Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/41593/index.html	https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/41593/index.html

Desktop 💻	Web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/41593/NewExpensify.dmg	https://41593.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

src/pages/OnboardingWork/BaseOnboardingWork.tsx

trjExpensify · 2024-05-03T16:21:34Z

Agreed with @ishpaul777, testing the adhoc build of this PR the CreateWorkspace command isn't fired at all:

2024-05-03_17-18-02.mp4

We want CreateWorkspace to be triggered when they hit confirm on the "Where do you work?" page.
Then we want the CompleteGuidedSetup command to be triggered when they confirm on the "What's your name?" page.

DylanDylann · 2024-05-03T16:38:25Z

@ishpaul777 Updated

trjExpensify · 2024-05-03T17:11:14Z

@DylanDylann can you record a quick video with the network tab open in the console with these latest changes? Thanks!

francoisl · 2024-05-03T17:18:03Z

Workspace is created at the right time for me (haven't reviewed the code in detail yet)

Screen.Recording.2024-05-03.at.10.16.16.AM.mov

DylanDylann · 2024-05-03T17:20:50Z

@trjExpensify

Screen.Recording.2024-05-04.at.00.19.52.mov

src/pages/OnboardingWork/BaseOnboardingWork.tsx

ishpaul777 · 2024-05-03T18:09:57Z

hey i just noticed we have to pass adminsChatReportID to Report.completeOnboarding in displayname page (where flow is completed)

DylanDylann · 2024-05-03T18:23:19Z

@ishpaul777 What do you think about creating a new field called ONBOARDING_ADMINS_CHAT_REPORT_ID like we did with ONBOARDING_PURPOSE_SELECTED?

ishpaul777 · 2024-05-03T18:37:57Z

as long as we clear it after its usage, i think it should be fine, cc @francoisl

francoisl · 2024-05-03T18:39:24Z

Yeah works for me 👍

DylanDylann · 2024-05-03T19:35:35Z

@ishpaul777 @francoisl Updated

ishpaul777

Looks good, Works well!

Screen.Recording.2024-05-04.at.1.06.48.AM.mov

OSBotify · 2024-05-03T19:58:47Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-05-09T02:13:19Z

🚀 Deployed to production by https://github.com/marcaaron in version: 1.4.71-6 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

ishpaul777 · 2024-05-28T21:05:03Z

There was a uninteded sideeffect of this PR- #41838

update onboarding flow

cd19f31

DylanDylann requested a review from a team as a code owner May 3, 2024 15:38

melvin-bot bot removed the request for review from a team May 3, 2024 15:38

melvin-bot bot requested a review from ishpaul777 May 3, 2024 15:38

trjExpensify assigned DylanDylann May 3, 2024

trjExpensify added the Ready To Build label May 3, 2024

only go to business page if the selected purpose is manage team

99357f6

ishpaul777 reviewed May 3, 2024

View reviewed changes

src/pages/OnboardingWork/BaseOnboardingWork.tsx Outdated Show resolved Hide resolved

should create ws before navigating

3363534

francoisl self-requested a review May 3, 2024 16:49

ishpaul777 reviewed May 3, 2024

View reviewed changes

src/pages/OnboardingWork/BaseOnboardingWork.tsx Outdated Show resolved Hide resolved

DylanDylann added 2 commits May 4, 2024 00:57

remove redundant

47d4ad8

lint fix

86cf7a2

DylanDylann added 2 commits May 4, 2024 01:27

lint fix

6d22d28

lin fix

0eaa2ba

DylanDylann added 3 commits May 4, 2024 01:58

add new ONYX field

25c9858

TS error

7d4d045

fix lint

7bb2cff

ishpaul777 approved these changes May 3, 2024

View reviewed changes

francoisl approved these changes May 3, 2024

View reviewed changes

francoisl merged commit d38fb99 into Expensify:main May 3, 2024
16 checks passed

github-actions bot mentioned this pull request May 7, 2024

Deploy Checklist: New Expensify 2024-05-07 #41716

Closed

izarutskaya mentioned this pull request May 8, 2024

[$250] [HOLD for payment 2024-06-03] [Guided Setup Stage 2] Multiple workspaces are created when navigating back and changing the business name #41838

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update onboarding flow #41593

Update onboarding flow #41593

DylanDylann commented May 3, 2024 •

edited

Loading

melvin-bot bot commented May 3, 2024

ishpaul777 commented May 3, 2024 •

edited

Loading

DylanDylann commented May 3, 2024

DylanDylann commented May 3, 2024

DylanDylann commented May 3, 2024

github-actions bot commented May 3, 2024

trjExpensify commented May 3, 2024

DylanDylann commented May 3, 2024

trjExpensify commented May 3, 2024

francoisl commented May 3, 2024

DylanDylann commented May 3, 2024

ishpaul777 commented May 3, 2024 •

edited

Loading

DylanDylann commented May 3, 2024

ishpaul777 commented May 3, 2024

francoisl commented May 3, 2024

DylanDylann commented May 3, 2024

ishpaul777 left a comment

OSBotify commented May 3, 2024

OSBotify commented May 9, 2024

ishpaul777 commented May 28, 2024

Update onboarding flow #41593

Update onboarding flow #41593

Conversation

DylanDylann commented May 3, 2024 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented May 3, 2024

ishpaul777 commented May 3, 2024 • edited Loading

Reviewer Checklist

Screenshots/Videos

DylanDylann commented May 3, 2024

DylanDylann commented May 3, 2024

DylanDylann commented May 3, 2024

github-actions bot commented May 3, 2024

trjExpensify commented May 3, 2024

DylanDylann commented May 3, 2024

trjExpensify commented May 3, 2024

francoisl commented May 3, 2024

DylanDylann commented May 3, 2024

ishpaul777 commented May 3, 2024 • edited Loading

DylanDylann commented May 3, 2024

ishpaul777 commented May 3, 2024

francoisl commented May 3, 2024

DylanDylann commented May 3, 2024

ishpaul777 left a comment

Choose a reason for hiding this comment

OSBotify commented May 3, 2024

OSBotify commented May 9, 2024

ishpaul777 commented May 28, 2024

DylanDylann commented May 3, 2024 •

edited

Loading

ishpaul777 commented May 3, 2024 •

edited

Loading

ishpaul777 commented May 3, 2024 •

edited

Loading