[Awaiting Payment 20th May] [Guided Setup Stage 1] Ask for business name before asking for display name

[trjExpensify]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v1.4.70-1
Reproducible in staging?: Y
Reproducible in production?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @trjExpensify
Slack conversation: https://expensify.slack.com/archives/C036QM0SLJK/p1714746065450189?thread_ts=1714400621.865599&cid=C036QM0SLJK

Action Performed:

1. Sign up with a new account
2. Click Manage my team's Expenses in the onboarding modal
3. Observe the next question you're asked is for your display name
4. Enter your display name
5. Observe the next question you're asked is for your business name

Expected Result:

When a new user selects the Manage my team's expenses onboarding intent:

1. The next question we ask should be for their Business name
2. Upon clicking the confirmation button on the business name page we should trigger the CreateWorkspace API command immediately

Actual Result:

We ask for business name last, so as a result, we trigger the CreateWorkspace command at the end of the onboarding flow.

Workaround:

N/A

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

2024-05-03_15-23-09.mp4

View all open jobs on GitHub

CC: @anmurali @francoisl @NikkiWines @mountiny @danielrvidal

Issue Owner

Current Issue Owner: @thesahindia

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @thesahindia (External)

[melvin-bot]

Current assignee @trjExpensify is eligible for the Bug assigner, not assigning anyone new.

[ishpaul777]

When a new user selects the Manage my team's expenses onboarding intent:

• The next question we ask should be for their Business name
• Upon clicking the confirmation button on the business name page we should trigger the CreateWorkspace API command immediately

@trjExpensify Is this behaviour specific to "Manage my team's expenses" option or for all other options?

[trjExpensify]

Yes, just that option. None of the other options ask for a business name. 👍

[ishpaul777]

ohk, i asked becuase with current PR changes it was asking for bussiness name for all options

[trjExpensify]

Yeah, I see the commit to not do that 😅

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[DylanDylann]

@trjExpensify The PR was deployed to production 2 weeks ago. Could you help to move forward with this issue

[trjExpensify]

Ah, the automation didn't run. Annoying! Payment summary as follows:

• $250 to @DylanDylann for the fix
• $250 to @ishpaul777 for the C+ review

Offers sent!

[ishpaul777]

Thanks! offer accepted

[trjExpensify]

@ishpaul777, paid!

[trjExpensify]

@DylanDylann paid! Closing!