[$250] [HOLD for payment 2024-06-03] [Guided Setup Stage 2] Multiple workspaces are created when navigating back and changing the business name

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v1.4.71-0
Reproducible in staging?: Y
Reproducible in production?: N
Found when validating PR : #41593
Email or phone of affected tester (no customers): shussain+acjhn1@applausemail.com
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team

Action Performed:

1. Sign up with a new account
2. Click Manage my team's Expenses in the onboarding modal
3. Verify that the next question you're asked is for your business name
4. Enter your business name
5. Verify that the next question you're asked is for your personal name
6. Click back button and change business name
7. Notice in background multiple workspace created

Expected Result:

Changing the business name after navigating back should not create multiple workspaces; it should only update the existing workspace with the new name

Actual Result:

Multiple workspaces are created when navigating back and changing the business name

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6474073_1715104367577.2024-05-07_22-38-41.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~014ce1c5b54ab34e82
• Upwork Job ID: 1795924034789011456
• Last Price Increase: 2024-05-29

Issue Owner

Current Issue Owner: @

[melvin-bot]

Triggered auto assignment to @amyevans (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open Staging deploy checklist to see the list of PRs included in this release, then work quickly on the following:

1. If you find which PR caused the issue/bug, you can reassign it to the person responsible for it.
   • If the author is OOO or won’t get online before the daily deploy is due, you are responsible for finding the best fix/path forward. Don’t hesitate to ask for help!
2. Try to reproduce the issue, if the bug is on production, remove the DeployBlocker label but stay assigned to fix it (or find out which PR broke it to get help from the author).
   • You can adjust the urgency of the issue to better represent the gravity of the bug.
   • If the issue is super low priority, feel free to un-assign yourself.
   • Be careful with PHP warnings, sometimes it is more complex than just adding a null coalescing operator as they might be uncovering some bigger bug.
   • If it was a one-off issue that requires no action (for example, Bedrock was down or it is a duplicated issue), you can close it.

Remember rule #2: Never un-assign yourself from a real DeployBlocker unless you are 100% sure someone else is assigned and will take care of it.

[melvin-bot]

Triggered auto assignment to @puneetlath (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[izarutskaya]

@puneetlath I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

[izarutskaya]

We think this issue might be related to the #collect project.

[izarutskaya]

Production

Recording.2433.mp4

[amyevans]

This is an unintended side effect of the changes in #41593 - @francoisl @DylanDylann @ishpaul777 shall we revert or are one of you available to get a fix PR together soon?

[ishpaul777]

Agree that this is sideeffect but this was this expected behviour in the issue

i can't think of any other solution than delaying a workspace creation until the flow is completed, mean we only call createWorkspace at the end of flow.

cc @trjExpensify

[trjExpensify]

@mountiny @rezkiy37 might have some ideas as well. I think it's a bit of an edge case to confirm the business name and then go back and change it, so I'm not sure I'd call it a deploy blocker per se, but we should see what we can do about it.

[mountiny]

Discussed with Tom and I think this does not have to be a deploy blocker as its a rare flow. The UX is not great, but not a blocker.

If we want to keep this behaviour of creating a workspace before the flow is completed (that is to be able to create correct guide calendar link in the message), we should probably consider adding some flag to the optimistic policy data so that when user goes back in the flow, we would not call CreateWorkspace but API to update the existing workspace name instead

[amyevans]

Sounds good, I'll demote it. I agree the approach would be to call UpdateWorkspaceGeneralSettings with the new name if the user navigated back and then forward again, but I haven't looked at the code to see how achievable that is. @francoisl mind if I reassign you as CME since you've got more context?

[cretadn22]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Multiple instances of the workspace are being created

What is the root cause of that problem?

App/src/pages/OnboardingWork/BaseOnboardingWork.tsx

Line 44 in e0b6a06

const {adminsChatReportID} = Policy.createWorkspace(undefined, true, work);

We consistently generate a fresh workspace upon finishing the business name page during the onboarding process

What changes do you think we should make in order to solve the problem?

As @amyevans's suggestion, I propose adding a new field to ONYX called "onboardingPolicyID"

App/src/pages/OnboardingWork/BaseOnboardingWork.tsx

Line 44 in e0b6a06

const {adminsChatReportID} = Policy.createWorkspace(undefined, true, work);

And we'll configure the onboardingPolicyID accordingly.

if (!onboardingPolicyID) { // Get from ONYX
  const {adminsChatReportID, policyID} = Policy.createWorkspace(undefined, true, work);
  Welcome.setOnboardingAdminsChatReportID(adminsChatReportID);
  Welcome.setOnboardingPolicyID(policyID);
}
Policy.updateGeneralSettings(onboardingPolicyID, work, onboardingPolicy.outputCurrency ||  CONST.CURRENCY.USD)
            

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[trjExpensify]

PR merged today!

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.75-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Dont create multiple policy #41990

If no regressions arise, payment will be issued on 2024-06-03. 🎊

For reference, here are some details about the assignees on this issue:

• @ishpaul777 requires payment (Needs manual offer from BZ)
• @cretadn22 requires payment (Needs manual offer from BZ)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@ishpaul777] The PR that introduced the bug has been identified. Link to the PR:
• [@ishpaul777] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@ishpaul777] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@ishpaul777] Determine if we should create a regression test for this bug.
• [@ishpaul777] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[ishpaul777]

• [@ishpaul777] The PR that introduced the bug has been identified. Link to the PR: Update onboarding flow #41593
• [@ishpaul777] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: Update onboarding flow #41593 (comment)
• [@ishpaul777] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: not required
• [@ishpaul777] Determine if we should create a regression test for this bug.- Yes if there isn't already one, this flow should be tested to make sure there are no regressions and its bug free.
• [@ishpaul777] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

Regression Test Proposal:

1. Sign up with a new account
2. Click Manage my team's Expenses in the onboarding modal
3. Verify that the next question you're asked is for your business name
4. Enter your business name
5. Verify that the next question you're asked is for your personal name
6. Click back button and change business name
7. Verify Changing the business name after navigating back should not create multiple workspaces; it should only update the existing workspace with the new name.

Do we 👍 or 👎 ?

[francoisl]

Sounds good. Internal issue to create the regression test created, I'm going to assign a BZ to handle payments.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~014ce1c5b54ab34e82

[melvin-bot]

Current assignee @ishpaul777 is eligible for the External assigner, not assigning anyone new.

[MitchExpensify]

Reminder set to pay tomorrow

[MitchExpensify]

Payment summary:

• $250 @ishpaul777 requires payment (Needs manual offer from BZ)
• $250 @cretadn22 requires payment (Needs manual offer from BZ)

Offers sent in Upwork

[cretadn22]

@MitchExpensify Accepted 🙏

[MitchExpensify]

paid and contract ended, thank you!