Fix/improve chart of accounts import page #41547

aldo-expensify · 2024-05-02T23:45:10Z

Details

Implements new design:

In the main import page, the value of "Chart of accounts" shows "Imported, displayed as categories" always now:

Fixed Issues

New design proposed here: https://expensify.slack.com/archives/C036QM0SLJK/p1714692855908009?thread_ts=1714400674.229349&cid=C036QM0SLJK
PROPOSAL:

Tests

With a Workspace with a QBO connection
Go to Import page
Check that the first item (Chart of accounts) looks like this:
Click "Chart of accounts"
Verify that the page looks like this:
Disable the checkbox at the bottom
Go back to the import page
Verify that "Chart of accounts" still shows "Imported, displayed as categories"

Verify that no errors appear in the JS console

Offline tests

QA Steps

With a Workspace with a QBO connection
Go to Import page
Check that the first item (Chart of accounts) looks like this:
Click "Chart of accounts"
Verify that the page looks like this:
Disable the checkbox at the bottom
Go back to the import page
Verify that "Chart of accounts" still shows "Imported, displayed as categories"

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

melvin-bot · 2024-05-02T23:45:36Z

@Gonals Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

hayata-suenaga · 2024-05-03T10:24:25Z

src/languages/es.ts

@@ -1913,8 +1913,8 @@ export default {
            customers: 'Clientes/Proyectos',
            displayedAs: 'Mostrado como',
            accountsDescription: 'Los planes de cuentas se importan como categorías cuando está conectado con una integración de contaduría, esto no se puede desactivar.',


maybe you forgot to update this translation?

I think the existing Spanish translation is already pretty close to what the new English copy says

Don't have the Spanish understanding, but when I pasted this key in Google translate, it showed the old English copy. (noob feedback, don't see words like Expensify and Quickbooks Online)

Lol, I guess that shows from where the Spanish translation came from. I'll see if I can come up with something closer to the current english translation.

I updated the translation

mananjadhav · 2024-05-03T13:51:42Z

@aldo-expensify @hayata-suenaga By any chance does this need C+ review?

src/pages/workspace/accounting/qbo/import/QuickbooksChartOfAccountsPage.tsx

hayata-suenaga · 2024-05-03T16:27:26Z

@mananjadhav yes we want to have your review for this PR 🙇 😄

mananjadhav · 2024-05-03T17:10:27Z

src/pages/workspace/accounting/qbo/import/QuickbooksChartOfAccountsPage.tsx

+                        <View style={[styles.flex1, styles.alignItemsEnd, styles.pl3]}>
+                            <Switch
+                                accessibilityLabel={translate('workspace.accounting.accounts')}
+                                isOn={true}


Can we fix this lint error?

mananjadhav

Small comments, rest of it looks good.

aldo-expensify · 2024-05-03T23:53:25Z

This is ready for review again.

mananjadhav

Code changes look fine, working on the checklist now.

mananjadhav · 2024-05-04T16:19:43Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

melvin-bot · 2024-05-04T16:20:26Z

@Julesssss Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

melvin-bot · 2024-05-04T16:20:29Z

🎯 @mananjadhav, thanks for reviewing and testing this PR! 🎉

An E/App issue has been created to issue payment here: #41642.

hayata-suenaga · 2024-05-06T22:14:18Z

src/pages/workspace/accounting/qbo/import/QuickbooksChartOfAccountsPage.tsx

+                        accessibilityLabel={translate('workspace.accounting.accounts')}
+                        isOn
+                        disabled
+                        onToggle={() => {}}


@aldo-expensify, are you going to update this line in your PR here?

What update does it need? I think onToggle is mandatory and this toggle is permanently disabled, so it doesn't have to do anything.

ah this is the switch for importing Chats of accounts! and Switch doesn't accept undefined...

anyway, thank you for reminding me of that 🙇

OSBotify · 2024-05-09T02:12:55Z

🚀 Deployed to production by https://github.com/marcaaron in version: 1.4.71-6 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

aldo-expensify added 2 commits May 2, 2024 16:06

Fix Chart of accounts translation

dbe3b21

Improve chart of accounts import

a6b35b1

aldo-expensify self-assigned this May 2, 2024

aldo-expensify requested a review from a team as a code owner May 2, 2024 23:45

aldo-expensify requested a review from hayata-suenaga May 2, 2024 23:45

melvin-bot bot removed the request for review from a team May 2, 2024 23:45

melvin-bot bot requested a review from Gonals May 2, 2024 23:45

Prettier

ce4e2f1

lakchote mentioned this pull request May 3, 2024

[HOLD for Payment 2024-05-29][Wave Collect] [Xero] [Import Flow] Create the Chart of Accounts page #39731

Closed

hayata-suenaga reviewed May 3, 2024

View reviewed changes

mananjadhav reviewed May 3, 2024

View reviewed changes

src/pages/workspace/accounting/qbo/import/QuickbooksChartOfAccountsPage.tsx Outdated Show resolved Hide resolved

mananjadhav reviewed May 3, 2024

View reviewed changes

aldo-expensify added 3 commits May 3, 2024 16:28

Fix lint

55412eb

Refactor using ConnectionLayout

0c8c0a7

Improve spanish translation

c1942c8

aldo-expensify requested a review from hayata-suenaga May 3, 2024 23:53

mananjadhav reviewed May 4, 2024

View reviewed changes

mananjadhav approved these changes May 4, 2024

View reviewed changes

melvin-bot bot requested a review from Julesssss May 4, 2024 16:20

melvin-bot bot mentioned this pull request May 4, 2024

[PAYMENT 5/15] Payment issue for E/App PR#41547 #41642

Closed

Gonals approved these changes May 6, 2024

View reviewed changes

aldo-expensify merged commit 9d235c8 into main May 6, 2024
16 of 20 checks passed

aldo-expensify deleted the aldo_fix-chart-of-accounts-and-exporter branch May 6, 2024 17:52

hayata-suenaga reviewed May 6, 2024

View reviewed changes

github-actions bot mentioned this pull request May 7, 2024

Deploy Checklist: New Expensify 2024-05-07 #41716

Closed

arosiclair mentioned this pull request May 7, 2024

[QBO] Chart of accounts page does not fit in RHP properly #41754

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix/improve chart of accounts import page #41547

Fix/improve chart of accounts import page #41547

aldo-expensify commented May 2, 2024 •

edited

Loading

melvin-bot bot commented May 2, 2024

hayata-suenaga May 3, 2024

aldo-expensify May 3, 2024

mananjadhav May 3, 2024 •

edited

Loading

aldo-expensify May 3, 2024

aldo-expensify May 3, 2024

mananjadhav commented May 3, 2024

hayata-suenaga commented May 3, 2024

mananjadhav May 3, 2024

aldo-expensify May 3, 2024

mananjadhav left a comment

aldo-expensify commented May 3, 2024

mananjadhav left a comment

mananjadhav commented May 4, 2024

melvin-bot bot commented May 4, 2024

melvin-bot bot commented May 4, 2024

hayata-suenaga May 6, 2024

aldo-expensify May 6, 2024 •

edited

Loading

hayata-suenaga May 7, 2024

OSBotify commented May 9, 2024

Fix/improve chart of accounts import page #41547

Fix/improve chart of accounts import page #41547

Conversation

aldo-expensify commented May 2, 2024 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented May 2, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mananjadhav May 3, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mananjadhav commented May 3, 2024

hayata-suenaga commented May 3, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mananjadhav left a comment

Choose a reason for hiding this comment

aldo-expensify commented May 3, 2024

mananjadhav left a comment

Choose a reason for hiding this comment

mananjadhav commented May 4, 2024

Reviewer Checklist

Screenshots/Videos

melvin-bot bot commented May 4, 2024

melvin-bot bot commented May 4, 2024

Choose a reason for hiding this comment

aldo-expensify May 6, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

OSBotify commented May 9, 2024

aldo-expensify commented May 2, 2024 •

edited

Loading

mananjadhav May 3, 2024 •

edited

Loading

aldo-expensify May 6, 2024 •

edited

Loading