[Fix]: Regex and Limit of Room Title were limited to 79 characters due to `BE` constraints #41123

allgandalf · 2024-04-26T23:19:53Z

Details

Due to BE constraints 1.5 years back, we limited the room title to only 79 character (total 80 including the #), but now with this PR we see the room title to 99 characters

Fixed Issues

$ #40968
PROPOSAL: #40968 (comment)

Tests

Same as QA steps

Verify that no errors appear in the JS console

Offline tests

Same as QA steps

QA Steps

Go to FAB > Start chat.
Go to Room tab.
Try to enter more than 79 characters.
Click create room
Verify that it's able to add upto 99 characters and create the room successfully.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

MacOS: Chrome / Safari

Screen.Recording.2024-04-27.at.4.54.58.AM.mov

MacOS: Desktop

Screen.Recording.2024-04-27.at.4.59.06.AM.mov

Android: Native

Screen.Recording.2024-04-27.at.5.04.14.AM.mov

Android: mWeb Chrome

Screen.Recording.2024-04-29.at.4.18.00.PM.mov

iOS: Native

Screen.Recording.2024-04-27.at.5.14.43.AM.mov

iOS: mWeb Safari

Screen.Recording.2024-04-27.at.5.06.15.AM.mov

melvin-bot · 2024-04-26T23:19:58Z

@eh2077 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

allgandalf · 2024-04-26T23:24:16Z

src/CONST.ts

@@ -843,7 +843,7 @@ const CONST = {
        },
        RESERVED_ROOM_NAMES: ['#admins', '#announce'],
        MAX_PREVIEW_AVATARS: 4,
-        MAX_ROOM_NAME_LENGTH: 79,
+        MAX_ROOM_NAME_LENGTH: 99,


@eh2077 @dangrous, we use MAX_ROOM_NAME_LENGTH only to create a room, also we need to have it limited to 99 because during room creation, we prefix # as a extra character.

Do let me know if you have any doubt about this, thanks have a great weekend

I think it makes sense to set the limit to 99.

eh2077 · 2024-04-29T06:07:05Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

0-android.mp4

Android: mWeb Chrome

0-mobile-chrome.mp4

iOS: Native

0-ios.mp4

iOS: mWeb Safari

0-mobile-safari.mp4

MacOS: Chrome / Safari

0-web.mp4

MacOS: Desktop

0-desktop.mp4

eh2077 · 2024-04-29T06:14:28Z

@GandalfGwaihir Can you confirm whether you have uploaded the right recording for Android: mWeb Chrome ?

eh2077 · 2024-04-29T06:17:00Z

@GandalfGwaihir Can you also update the 5th step of QA to

5. Verify that it's able to add upto 99 characters and create the room successfully.

allgandalf · 2024-04-29T10:49:44Z

Can you confirm whether you have uploaded the right recording for Android: mWeb Chrome ?

My bad, updated the correct video @eh2077

eh2077

LGTM

allgandalf · 2024-05-02T17:31:29Z

friendly bump @dangrous for review

dangrous

lgtm!

OSBotify · 2024-05-03T15:45:27Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-05-09T02:10:49Z

🚀 Deployed to production by https://github.com/marcaaron in version: 1.4.71-6 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

Update Regex and titile limit for rooms

a02d5dc

allgandalf requested a review from a team as a code owner April 26, 2024 23:19

melvin-bot bot requested review from eh2077 and removed request for a team April 26, 2024 23:19

allgandalf commented Apr 26, 2024

View reviewed changes

eh2077 approved these changes Apr 30, 2024

View reviewed changes

melvin-bot bot requested a review from dangrous April 30, 2024 05:10

allgandalf added 2 commits May 1, 2024 00:21

update unit test

65bf525

update unit test

9862f92

dangrous approved these changes May 3, 2024

View reviewed changes

dangrous merged commit aa9c279 into Expensify:main May 3, 2024
15 checks passed

github-actions bot mentioned this pull request May 7, 2024

Deploy Checklist: New Expensify 2024-05-07 #41716

Closed

allgandalf mentioned this pull request May 10, 2024

HOLD for Payment [2024-05-16] [$250] Room - Room name character limit is 79 characters instead of 100 #40968

Closed

6 tasks

dominictb mentioned this pull request Aug 29, 2024

[Awaiting Payment Sept 15th][$125] Room-mWeb-Inconsistency in Character allowed to create room from fab & via mentions #48168

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Fix]: Regex and Limit of Room Title were limited to 79 characters due to `BE` constraints #41123

[Fix]: Regex and Limit of Room Title were limited to 79 characters due to `BE` constraints #41123

allgandalf commented Apr 26, 2024 •

edited

Loading

melvin-bot bot commented Apr 26, 2024

allgandalf Apr 26, 2024

eh2077 Apr 29, 2024

eh2077 commented Apr 29, 2024 •

edited

Loading

eh2077 commented Apr 29, 2024

eh2077 commented Apr 29, 2024

allgandalf commented Apr 29, 2024

eh2077 left a comment

allgandalf commented May 2, 2024

dangrous left a comment

OSBotify commented May 3, 2024

OSBotify commented May 9, 2024

[Fix]: Regex and Limit of Room Title were limited to 79 characters due to BE constraints #41123

[Fix]: Regex and Limit of Room Title were limited to 79 characters due to BE constraints #41123

Conversation

allgandalf commented Apr 26, 2024 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Apr 26, 2024

allgandalf Apr 26, 2024

Choose a reason for hiding this comment

eh2077 Apr 29, 2024

Choose a reason for hiding this comment

eh2077 commented Apr 29, 2024 • edited Loading

Reviewer Checklist

Screenshots/Videos

eh2077 commented Apr 29, 2024

eh2077 commented Apr 29, 2024

allgandalf commented Apr 29, 2024

eh2077 left a comment

Choose a reason for hiding this comment

allgandalf commented May 2, 2024

dangrous left a comment

Choose a reason for hiding this comment

OSBotify commented May 3, 2024

OSBotify commented May 9, 2024

[Fix]: Regex and Limit of Room Title were limited to 79 characters due to `BE` constraints #41123

[Fix]: Regex and Limit of Room Title were limited to 79 characters due to `BE` constraints #41123

allgandalf commented Apr 26, 2024 •

edited

Loading

eh2077 commented Apr 29, 2024 •

edited

Loading