[$250] mWeb - Search - Tapping expensify via switcher from new search page directed to hmm not here page

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.71
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Action Performed:

1. Go to https://staging.new.expensify.com/home

2. Tap profile

3. Tap troubleshoot-- new search page

4. Tap expensify switcher

5. Tap expensify

Expected Result:

Tapping expensify via switcher from new search page must not direct to hmm not here page

Actual Result:

Tapping expensify via switcher from new search page directed to hmm not here page

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6473928_1715097495658.expen.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01225e08d98c91386d
• Upwork Job ID: 1787910838599999488
• Last Price Increase: 2024-05-07

Issue Owner

Current Issue Owner: @s77rt

[melvin-bot]

Triggered auto assignment to @marcochavezf (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open Staging deploy checklist to see the list of PRs included in this release, then work quickly on the following:

1. If you find which PR caused the issue/bug, you can reassign it to the person responsible for it.
   • If the author is OOO or won’t get online before the daily deploy is due, you are responsible for finding the best fix/path forward. Don’t hesitate to ask for help!
2. Try to reproduce the issue, if the bug is on production, remove the DeployBlocker label but stay assigned to fix it (or find out which PR broke it to get help from the author).
   • You can adjust the urgency of the issue to better represent the gravity of the bug.
   • If the issue is super low priority, feel free to un-assign yourself.
   • Be careful with PHP warnings, sometimes it is more complex than just adding a null coalescing operator as they might be uncovering some bigger bug.
   • If it was a one-off issue that requires no action (for example, Bedrock was down or it is a duplicated issue), you can close it.

Remember rule #2: Never un-assign yourself from a real DeployBlocker unless you are 100% sure someone else is assigned and will take care of it.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[lanitochka17]

@marcochavezf FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[marcochavezf]

Looks like this feature is still in beta (can only be enabled in staging), since we don't have the option to enable it in production:

So, I don't think this should be a blocker, and it can be external.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01225e08d98c91386d

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @s77rt (External)

[tienifr]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Tapping expensify via switcher from new search page directed to hmm not here page

What is the root cause of that problem?

Here, in the case the user was not in any particular route when making the switch, the screen will be undefined. This causes the issue because then we'll be navigating to the first path that was found in the stack, which is the Search_Bottom_Tab and this will show the not found page.

What changes do you think we should make in order to solve the problem?

Here, if screen does not exist, we'll default to HOME

name: screen || SCREENS.HOME,

What alternative solutions did you explore? (Optional)

NA

[s77rt]

@tienifr I believe this is a feature request. We should not redirect the user to HOME instead the search list should reflect only reports for the selected policy.

cc @luacmartins since you are involved in the new search page, do we have an issue/plan to add the workspace switcher support to the search page?

[luacmartins]

Thanks for the ping. Yea, this is not implemented yet. We'll work on it as part of this issue. We can close this one.