[HOLD for payment 2024-06-03] [$250] Track expense - Categorize it - No search bar in category list when there is no workspace

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.71-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Issue found when executing PR #41465

Action Performed:

Precondition:

• Account has no workspace

1. Go to staging.new.expensify.com
2. Go to FAB > Track expense
3. Track a manual expense
4. In 1:1 DM, click Categorize it

Expected Result:

There will be a search bar in Category list (production behavior)

Actual Result:

There is no search bar in Category list

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6473828_1715092581854.20240507_223159.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~013cf40a4b960e3a87
• Upwork Job ID: 1787878825294028800
• Last Price Increase: 2024-05-07
• Automatic offers:
• tienifr | Contributor | 0

Issue Owner

Current Issue Owner: @isabelastisser

[melvin-bot]

Triggered auto assignment to @blimpich (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open Staging deploy checklist to see the list of PRs included in this release, then work quickly on the following:

1. If you find which PR caused the issue/bug, you can reassign it to the person responsible for it.
   • If the author is OOO or won’t get online before the daily deploy is due, you are responsible for finding the best fix/path forward. Don’t hesitate to ask for help!
2. Try to reproduce the issue, if the bug is on production, remove the DeployBlocker label but stay assigned to fix it (or find out which PR broke it to get help from the author).
   • You can adjust the urgency of the issue to better represent the gravity of the bug.
   • If the issue is super low priority, feel free to un-assign yourself.
   • Be careful with PHP warnings, sometimes it is more complex than just adding a null coalescing operator as they might be uncovering some bigger bug.
   • If it was a one-off issue that requires no action (for example, Bedrock was down or it is a duplicated issue), you can close it.

Remember rule #2: Never un-assign yourself from a real DeployBlocker unless you are 100% sure someone else is assigned and will take care of it.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[lanitochka17]

@blimpich FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~013cf40a4b960e3a87

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mananjadhav (External)

[blimpich]

Demoted, minor enough that I don't think it needs to block the deploy. Also unlikely this is a webx deploy blocker since its simply the absence of a UI component.

[tienifr]

Proposal

Please re-state the problem that we are trying to solve in this issue.

There is no search bar in Category list

What is the root cause of that problem?

When counting the policy categories here, we're not falling back to policyCategoriesDraft. Since the policyCategories is not available when there's no workspace, the count here will be 0, thus below CATEGORY_LIST_THRESHOLD and the Search functionality will not show

What changes do you think we should make in order to solve the problem?

When counting the policy categories here, fall back to policyCategoriesDraft

const policiesCount = OptionsListUtils.getEnabledCategoriesCount(policyCategories ?? policyCategoriesDraft ?? {});

Just like what we did when getting the categories to display here

Since that part is reused, we can assign const categories = policyCategories ?? policyCategoriesDraft ?? {} and reuse in both places.

Also I notice the variable name policiesCount here is wrong, it should be categoriesCount

What alternative solutions did you explore? (Optional)

NA

[mananjadhav]

@tienifr's proposal looks good to me.

🎀 👀 🎀 C+ reviewed.

[melvin-bot]

Current assignee @blimpich is eligible for the choreEngineerContributorManagement assigner, not assigning anyone new.

[melvin-bot]

📣 @tienifr 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[mananjadhav]

Reviewed the PR and updated checklist.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.75-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix: no search bar in category list while categorizing #41827

If no regressions arise, payment will be issued on 2024-06-03. 🎊

For reference, here are some details about the assignees on this issue:

• @mananjadhav requires payment through NewDot Manual Requests
• @tienifr requires payment automatic offer (Contributor)

[mananjadhav]

Because this was founding during the QA of another PR, I am assuming the regression tests exists for the same? @lanitochka17 Can you confirm?

I couldn't find the offending PR for this one. I can see we refactored to Typescript as the last change. But the change existed even before that.

@blimpich Can you assign a BZ member for the payout.

[melvin-bot]

Triggered auto assignment to @isabelastisser (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[isabelastisser]

Payment summary:

$250 for C+ review @mananjadhav requires payment through NewDot Manual Requests PENDING
$250 for contributor work @tienifr requires payment automatic offer (Contributor) - Paid in Upwork.

All set.

[mananjadhav]

Thanks @isabelastisser

[JmillsExpensify]

$250 approved for @mananjadhav