[HOLD for payment 2024-06-13] [$250] Connect Bank account - Background is slightly touching "Numbers" in Onfido Flow

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.71-4
Reproducible in staging?: Y
Reproducible in production?: Unable to check
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): applausetester+emilio@applause.expensifail.com
Issue reported by: Applause - Internal Team

Issue found when executing PR #41234

Action Performed:

1. Open the New Expensify app or go to staging.new.expensify.com
2. Sign into a valid account
3. Go to Workspace > Enable Workflow > Connect Bank account
4. Select "Connect manually" and use the testing routing number and account number
5. On Personal info page, enter "First" and "Last" for first name and last name
6. Enter any other information on the rest of the Personal info pages and confirm
7. Observe the page when the user is redirected to the "Terms" page

Expected Result:

User expects correct distancing in between elements

Actual Result:

The Terms "Frame" is slightly touching with the "numbers" in the header

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6474960_1715182296616.Border_is_touching_the_numbered_steps_in_Onfido_flow_.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01fc1107f6a76f2e7b
• Upwork Job ID: 1788283293391118336
• Last Price Increase: 2024-05-15
• Automatic offers:
• ShridharGoel | Contributor | 0

Issue Owner

Current Issue Owner: @thesahindia

[melvin-bot]

Triggered auto assignment to @carlosmiceli (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open Staging deploy checklist to see the list of PRs included in this release, then work quickly on the following:

1. If you find which PR caused the issue/bug, you can reassign it to the person responsible for it.
   • If the author is OOO or won’t get online before the daily deploy is due, you are responsible for finding the best fix/path forward. Don’t hesitate to ask for help!
2. Try to reproduce the issue, if the bug is on production, remove the DeployBlocker label but stay assigned to fix it (or find out which PR broke it to get help from the author).
   • You can adjust the urgency of the issue to better represent the gravity of the bug.
   • If the issue is super low priority, feel free to un-assign yourself.
   • Be careful with PHP warnings, sometimes it is more complex than just adding a null coalescing operator as they might be uncovering some bigger bug.
   • If it was a one-off issue that requires no action (for example, Bedrock was down or it is a duplicated issue), you can close it.

Remember rule #2: Never un-assign yourself from a real DeployBlocker unless you are 100% sure someone else is assigned and will take care of it.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[lanitochka17]

@carlosmiceli FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[ShridharGoel]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Bottom margin is missing under the step numbers.

What is the root cause of that problem?

Bottom margin is missing here:

App/src/pages/ReimbursementAccount/VerifyIdentity/VerifyIdentity.tsx

Lines 69 to 74 in e0b6a06

	<View style={[styles.ph5, styles.mt3, {height: CONST.BANK_ACCOUNT.STEPS_HEADER_HEIGHT}]}>
	<InteractiveStepSubHeader
	startStepIndex={2}
	stepNames={CONST.BANK_ACCOUNT.STEP_NAMES}
	/>
	</View>

What changes do you think we should make in order to solve the problem?

Add styles.mb5.

<View style={[styles.ph5, styles.mb5, styles.mt3, {height: CONST.BANK_ACCOUNT.STEPS_HEADER_HEIGHT}]}>
    <InteractiveStepSubHeader
        startStepIndex={2}
        stepNames={CONST.BANK_ACCOUNT.STEP_NAMES}
    />
</View>

This would be same as it is being done below and in other pages in this flow:

App/src/pages/EnablePayments/PersonalInfo/PersonalInfo.tsx

Lines 107 to 112 in e0b6a06

	<View style={[styles.ph5, styles.mb5, styles.mt3, {height: CONST.BANK_ACCOUNT.STEPS_HEADER_HEIGHT}]}>
	<InteractiveStepSubHeader
	startStepIndex={1}
	stepNames={CONST.WALLET.STEP_NAMES}
	/>
	</View>

[carlosmiceli]

Looking at it @lanitochka17, will let you know asap!

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01fc1107f6a76f2e7b

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @thesahindia (External)

[melvin-bot]

Triggered auto assignment to @sonialiap (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[thesahindia]

@ShridharGoel, the bottom margin will also increase the gap here -

Can we do something about it?

[ShridharGoel]

@thesahindia That header is used to show the back button on the next step when "Accept" is clicked. I don't think we can do something about it.

[thesahindia]

I think we should get some input from the design team.

cc: @carlosmiceli

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[carlosmiceli]

@thesahindia To confirm, are we waiting for an updated proposal from @ShridharGoel?

[thesahindia]

Looks like we are okay with the extra padding. Let's go with @ShridharGoel's proposal.

🎀 👀 🎀 C+ reviewed

[melvin-bot]

Current assignee @carlosmiceli is eligible for the choreEngineerContributorManagement assigner, not assigning anyone new.

[melvin-bot]

@carlosmiceli @shawnborton @sonialiap @thesahindia this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[melvin-bot]

📣 @ShridharGoel 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[carlosmiceli]

@ShridharGoel @thesahindia What's the status of this?

[ShridharGoel]

Will open PR soon.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.79-11 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Add bottom margin below header in Onfido step #42746

If no regressions arise, payment will be issued on 2024-06-13. 🎊

For reference, here are some details about the assignees on this issue:

• @ShridharGoel requires payment automatic offer (Contributor)
• @thesahindia requires payment through NewDot Manual Requests

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@thesahindia] The PR that introduced the bug has been identified. Link to the PR:
• [@thesahindia] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@thesahindia] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@thesahindia] Determine if we should create a regression test for this bug.
• [@thesahindia] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@sonialiap] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[sonialiap]

Payment summary
@ShridharGoel $250 - paid ✔️
@thesahindia $250 - please request in ND and complete the checklist

[thesahindia]

We weren't using margin at the bottom of the header. I believe it was intentional at that time. We just made an improvement.

I don't think we need a test case for this.

[JmillsExpensify]

$250 approved for @thesahindia