Split - Inconsistency in currency symbol in confirmation page and split details page

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.71-0
Reproducible in staging?: Y
Reproducible in production?: N
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team

Action Performed:

1. Go to staging.new.expensify.com
2. Go to FAB > Split expense.
3. Select MYR - RM as currency (required for next step)>
4. Enter amount and select a few users.
5. On confirmation page, note that the currency is RM.
6. Split the expense.
7. In group chat, click on the split preview.

Expected Result:

The currency in confirmation page and split details page should be consistent.

Actual Result:

The currency in confirmation page (Step 5) is RM, while it shows MYR in split details page (Step 7).
RM is the correct currency symbol, but it is not used anywhere else across the app.
This issue also happens with a few currency like SGD - S$ and THB.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6474283_1715117759822.20240508_053110.mp4

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @mallenexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open Staging deploy checklist to see the list of PRs included in this release, then work quickly on the following:

1. If you find which PR caused the issue/bug, you can reassign it to the person responsible for it.
   • If the author is OOO or won’t get online before the daily deploy is due, you are responsible for finding the best fix/path forward. Don’t hesitate to ask for help!
2. Try to reproduce the issue, if the bug is on production, remove the DeployBlocker label but stay assigned to fix it (or find out which PR broke it to get help from the author).
   • You can adjust the urgency of the issue to better represent the gravity of the bug.
   • If the issue is super low priority, feel free to un-assign yourself.
   • Be careful with PHP warnings, sometimes it is more complex than just adding a null coalescing operator as they might be uncovering some bigger bug.
   • If it was a one-off issue that requires no action (for example, Bedrock was down or it is a duplicated issue), you can close it.

Remember rule #2: Never un-assign yourself from a real DeployBlocker unless you are 100% sure someone else is assigned and will take care of it.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[izarutskaya]

@mallenexpensify I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

[izarutskaya]

We think this issue might be related to the #vip-split.

[melvin-bot]

Triggered auto assignment to @grgia (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[izarutskaya]

Production

Recording.2431.mp4

[melvin-bot]

Triggered auto assignment to @Beamanator (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[nkdengineer]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The currency in confirmation page (Step 5) is RM, while it shows MYR in split details page (Step 7).
RM is the correct currency symbol, but it is not used anywhere else across the app.
This issue also happens with a few currency like SGD - S$ and THB.

What is the root cause of that problem?

In the create flow, we use currencySymbol which is the correct currency symbol of currency code to display

App/src/components/MoneyRequestConfirmationList.tsx

Line 486 in e0b6a06

const currencySymbol = currencyList?.[iouCurrencyCode ?? '']?.symbol ?? iouCurrencyCode;

But in split bill detail page, we use iouCurrencyCode. That is an inconsistent

App/src/components/MoneyRequestConfirmationList.tsx

Line 481 in e0b6a06

descriptiveText: amount ? CurrencyUtils.convertToDisplayString(amount, iouCurrencyCode) : '',

What changes do you think we should make in order to solve the problem?

We should use iouCurrencyCode as prefixCharacter here instead of currencySymbol

App/src/components/MoneyRequestConfirmationList.tsx

Line 497 in e0b6a06

prefixCharacter: currencySymbol,

Or we can use currencySymbol to display the amount text here

App/src/components/MoneyRequestConfirmationList.tsx

Line 481 in e0b6a06

descriptiveText: amount ? CurrencyUtils.convertToDisplayString(amount, iouCurrencyCode) : '',

What alternative solutions did you explore? (Optional)

NA

[cristipaval]

This seems to be a super minor issue. Demoting and assigning @youssef-lr as the original author.

[youssef-lr]

This is intentional so we can use a smaller symbol in the amount inputs. We'd like to display $ and € for example in the inputs vs USD & EUR. I think we can close.