[HOLD App #43133] Search-Navigating to new search page app crashes

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.72-0
Reproducible in staging?: Y
Reproducible in production?: Unable to check
Email or phone of affected tester (no customers): Reproducible only in this accounts vincenzoddragon@gmail.com, jaihanumanblog@gmail.com, vincenzoddragon+life@gmail.com
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team

Action Performed:

1. Go to https://staging.new.expensify.com/
2. Login with gmail account with many transactions (not a new account)
3. Tap profile -- troubleshoot
4. Navigate to new search page

Expected Result:

Navigating to new search page app must not crash.

Actual Result:

Navigating to new search page app crashes

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6475531_1715233311628.crash.mp4

logs.txt

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @Christinadobrzyn

[melvin-bot]

Triggered auto assignment to @Julesssss (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

Triggered auto assignment to @Christinadobrzyn (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open Staging deploy checklist to see the list of PRs included in this release, then work quickly on the following:

1. If you find which PR caused the issue/bug, you can reassign it to the person responsible for it.
   • If the author is OOO or won’t get online before the daily deploy is due, you are responsible for finding the best fix/path forward. Don’t hesitate to ask for help!
2. Try to reproduce the issue, if the bug is on production, remove the DeployBlocker label but stay assigned to fix it (or find out which PR broke it to get help from the author).
   • You can adjust the urgency of the issue to better represent the gravity of the bug.
   • If the issue is super low priority, feel free to un-assign yourself.
   • Be careful with PHP warnings, sometimes it is more complex than just adding a null coalescing operator as they might be uncovering some bigger bug.
   • If it was a one-off issue that requires no action (for example, Bedrock was down or it is a duplicated issue), you can close it.

Remember rule #2: Never un-assign yourself from a real DeployBlocker unless you are 100% sure someone else is assigned and will take care of it.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[izarutskaya]

@Christinadobrzyn I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

[izarutskaya]

We think this issue might be related to the #vip-vsb.

[Christinadobrzyn]

I'm not able to get the crash on iOS Safari or Android Native v1.4.72-0 (I did wait longer after the recordings and nothing crashed)

Asking QA if they can double-check - https://expensify.slack.com/archives/C9YU7BX5M/p1715246754402309

iOS Safari v1.4.72-0

RPReplay_Final1715246455.MP4

[Julesssss]

Same here. I can't reproduce on Android or mWeb.

As this is related to a new hidden feature this is not a blocker, so I'm removing the label.

[MelvinBot]

This has been labelled "Needs Reproduction". Follow the steps here: https://stackoverflowteams.com/c/expensify/questions/16989

[Christinadobrzyn]

QA said they can reproduce with these emails:

• jaihanumanblog@gmail.com
• vincenzoddragon@gmail.com

Since we don't have access to those accounts and we are not getting the bug on any other available gmail accounts, I think we should add a Needs Reproduction & Retest weekly label so QA can check next week. I suspect this is related to our staging/outage from the past two days.

@Julesssss what do you think of this plan?

[Julesssss]

@Christinadobrzyn sounds good to me 👍

[Christinadobrzyn]

awesome, move to weekly - I'll watch the restests

[mvtglobally]

Issue not reproducible during KI retests. (First week)

[Christinadobrzyn]

Asking for a retest - https://expensify.slack.com/archives/C9YU7BX5M/p1716276983920909

[kavimuru]

Issue is not reproducible.

az_recorder_20240521_172751_compress_1.mp4

[mvtglobally]

Issue not reproducible during KI retests. (Second week)

[Christinadobrzyn]

Awesome! Closing

[kbecciv]

QA team is able to reproduce the issue consistently on build 1.4.75.0, @Christinadobrzyn Can you please review the issue again? Thank you

20240523_220929.mp4

[melvin-bot]

@Julesssss @Christinadobrzyn this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[luacmartins]

@kbecciv can you share the test account credentials?

[luacmartins]

From the latest video, seems like we have an invalid currency here. I wanna take a look at the data we're passing in to confirm where the issue is.

[mvtglobally]

Issue not reproducible during KI retests. (Third week)

[Christinadobrzyn]

I'm also not able to reproduce this - @luacmartins can you test and let us know if this can be closed?

[Julesssss]

I'm not sure where we can locate the PW to these users, but happy to test these.

I'm not data on the new search page in my personal Gmail account, but I don't get a crash either.

[luacmartins]

RangeError: Malformed currency code

It seems like one of the transactions had a bad currency code stored in, which is being handled here and will be fixed in this PR.

[luacmartins]

Let's retest once that PR is merged

[mvtglobally]

Issue not reproducible during KI retests. (Fourth week)

[luacmartins]

I think we are good to close this issue given that we haven't been able to reproduce this in four weeks and we have another issue that solves the currency crash. Thanks everyone!