fix currency breaking issue with currency conversion #43133

b4s36t4 · 2024-06-05T16:55:17Z

Details

Fixed Issues

$ #43004
PROPOSAL: #43004 (comment)

Tests

Maybe a technical testing is required than manual QA

Open any report
Click (+) icon > Submit expense then submit an expense
Open the expense report that you created it in step 2 and Verify the app is not crashed

extra steps for Web and Desktop only

Open your browser console and type Onyx.merge("report_<your_report_id>",{currency: null}) then press Enter. You can get your_report_id from browser link.
Verify the app is not crashed

Verify that no errors appear in the JS console

Offline tests

Same as above

QA Steps

Same as Above

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Kapture.2024-06-06.at.01.21.00.mp4

Android: mWeb Chrome

Kapture.2024-06-06.at.01.45.31.mp4

iOS: Native

Kapture.2024-06-06.at.00.49.17.mp4

iOS: mWeb Safari

Kapture.2024-06-06.at.01.02.36.mp4

MacOS: Chrome / Safari

Kapture.2024-06-05.at.21.43.29.mp4

MacOS: Desktop

Kapture.2024-06-05.at.22.21.38.mp4

melvin-bot · 2024-06-05T16:55:22Z

@ahmedGaber93 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

b4s36t4 · 2024-06-05T16:55:35Z

I'll update the recordings shortly.

b4s36t4 · 2024-06-05T16:58:50Z

@ahmedGaber93 can you take latest pull from main and execute the Onyx.merge command on a IOU report please?

I'm getting the following error, wanted to know if it's because of my commits or it's on latest itself.

I tried on main but wanted to make sure again, so asking you.

ahmedGaber93 · 2024-06-05T17:04:47Z

@b4s36t4 I don't think this related to your PR.

b4s36t4 · 2024-06-05T17:05:29Z

Thanks for checking @ahmedGaber93 .

b4s36t4 · 2024-06-05T19:54:36Z

@ahmedGaber93 Please go ahead with your review and testing. I have uploaded the videos as well (except android chrome, setting up ssl certificated would be done soon).

Commit verification is also being handled, just wanted to unblock you.

ahmedGaber93 · 2024-06-05T20:07:45Z

@b4s36t4 I think you missed those two places

App/src/libs/ReportUtils.ts

Line 2897 in afe64e5

    
           const formattedAmount = CurrencyUtils.convertToDisplayString(transactionDetails?.amount ?? 0, transactionDetails?.currency ?? '');

App/src/libs/ReportUtils.ts

Line 2919 in afe64e5

    
           const formattedAmount = CurrencyUtils.convertToDisplayString(transactionDetails?.amount ?? 0, transactionDetails?.currency ?? '');

Also why typescript not catch this?

b4s36t4 · 2024-06-05T20:19:21Z

because keyof CurrencyList is of type string. which itself again leaves it to string.

Although typescript doesn't catch this I had a validation condition inside the function which will catch there even if we miss here.

b4s36t4 · 2024-06-05T20:23:33Z

@ahmedGaber93 please check now updated, sorry for missing it out!.

ahmedGaber93 · 2024-06-05T20:26:31Z

App/src/types/onyx/Currency.ts

Line 24 in fcfef92

type CurrencyList = Record<string, Currency | null>;

Yes, CurrencyList key is string as the list seem come from backend and save to onyx not static in the code

src/libs/CurrencyUtils.ts

ahmedGaber93 · 2024-06-05T20:48:03Z

src/libs/CurrencyUtils.ts

+    let validatedCurrency = currency;
+    if (!currency || currency.length === 0 || currency.length > 3) {
+        validatedCurrency = CONST.CURRENCY.USD;
+    }


I think we can simplify this condition to !currency and this will check for undefined or ''

let currencyWithFallback = currency; if (!currency) { currencyWithFallback = CONST.CURRENCY.USD; }

Also, I think it is self-explanatory

Yea, but my idea is to make it explain the value shouldn't be empty string as well.

Yea, but my idea is to make it explain the value shouldn't be empty string as well.

Ok, we can simplify the comment, maybe like this // Fallback currency to USD if it empty string or undefined

Done, updated.!

@b4s36t4 I think this syntax is better than the new one you pushed

let currencyWithFallback = currency; if (!currency) { currencyWithFallback = CONST.CURRENCY.USD; }

ahmedGaber93 · 2024-06-05T21:21:01Z

@b4s36t4 I think we need to simplify Tests to

Open any report
Click (+) icon > Submit expense then submit an expense
Open the expense report that you created it in step 2 and Verify the app is not crashed

extra steps for Web and Desktop only

Open your browser console and type Onyx.merge("report_<your_report_id>",{currency: null}) then press Enter. You can get your_report_id from browser link.
Verify the app is not crashed

b4s36t4 · 2024-06-05T21:23:30Z

Agree, updating.!

ahmedGaber93 · 2024-06-05T22:16:49Z

@b4s36t4 We still need to update #43133 (comment) and #43133 (comment).
And please remove this part as it already cover by step 4 and maybe misleads QA team as it should be null not INR.

Thanks for your patience.

ahmedGaber93 · 2024-06-05T22:19:46Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

a.mp4

Android: mWeb Chrome

aw.mp4

iOS: Native

ios.mp4

iOS: mWeb Safari

iw.mp4

MacOS: Chrome / Safari

20240606012640236.mp4

MacOS: Desktop

d.mp4

ahmedGaber93 · 2024-06-05T22:31:49Z

@b4s36t4 this issue is urgent, are you able to update this #43133 (comment) today?

b4s36t4 · 2024-06-06T05:05:26Z

@ahmedGaber93 Sorry I went to sleep at that time. I have updated the changes you requested can you please check again?

src/libs/CurrencyUtils.ts

ahmedGaber93

LGTM!

srikarparsi

code looks good and tests well, thanks for the quick changes

srikarparsi · 2024-06-06T06:33:29Z

QA, if you're not able to follow the test steps (deals with the browser console), please tag me and I can help QA it.

OSBotify · 2024-06-06T06:41:03Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-06-11T23:35:22Z

🚀 Deployed to production by https://github.com/luacmartins in version: 1.4.81-11 🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

b4s36t4 requested a review from a team as a code owner June 5, 2024 16:55

melvin-bot bot removed the request for review from a team June 5, 2024 16:55

melvin-bot bot requested a review from ahmedGaber93 June 5, 2024 16:55

luacmartins mentioned this pull request Jun 5, 2024

[HOLD App #43133] Search-Navigating to new search page app crashes #41883

Closed

6 tasks

fix currency breaking issue with currency conversion

26f5d45

b4s36t4 force-pushed the fix/empty-currency-break branch from bc69faf to 26f5d45 Compare June 5, 2024 20:22

ahmedGaber93 reviewed Jun 5, 2024

View reviewed changes

update comment

6ce5244

This comment was marked as outdated.

Sign in to view

update changes

850f3fa

ahmedGaber93 reviewed Jun 6, 2024

View reviewed changes

src/libs/CurrencyUtils.ts Outdated Show resolved Hide resolved

remove import

54ddb2d

ahmedGaber93 approved these changes Jun 6, 2024

View reviewed changes

melvin-bot bot requested a review from srikarparsi June 6, 2024 05:24

srikarparsi approved these changes Jun 6, 2024

View reviewed changes

srikarparsi merged commit 90dee7a into Expensify:main Jun 6, 2024
16 of 17 checks passed

b4s36t4 deleted the fix/empty-currency-break branch June 6, 2024 08:09

github-actions bot mentioned this pull request Jun 6, 2024

Deploy Checklist: New Expensify 2024-06-06 #43168

Closed

melvin-bot bot mentioned this pull request Jun 11, 2024

[HOLD for payment 2024-06-20] [HOLD for payment 2024-06-18] [$500] [CRITICAL] [UX Reliability] App Crash with Invalid Currency code #43004

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix currency breaking issue with currency conversion #43133

fix currency breaking issue with currency conversion #43133

b4s36t4 commented Jun 5, 2024 •

edited

Loading

melvin-bot bot commented Jun 5, 2024

b4s36t4 commented Jun 5, 2024

b4s36t4 commented Jun 5, 2024

ahmedGaber93 commented Jun 5, 2024

b4s36t4 commented Jun 5, 2024

b4s36t4 commented Jun 5, 2024

ahmedGaber93 commented Jun 5, 2024 •

edited

Loading

b4s36t4 commented Jun 5, 2024

b4s36t4 commented Jun 5, 2024

ahmedGaber93 commented Jun 5, 2024

ahmedGaber93 Jun 5, 2024

b4s36t4 Jun 5, 2024

ahmedGaber93 Jun 5, 2024

b4s36t4 Jun 5, 2024

ahmedGaber93 Jun 5, 2024 •

edited

Loading

ahmedGaber93 commented Jun 5, 2024

b4s36t4 commented Jun 5, 2024

ahmedGaber93 commented Jun 5, 2024

This comment was marked as outdated.

ahmedGaber93 commented Jun 5, 2024 •

edited

Loading

ahmedGaber93 commented Jun 5, 2024

b4s36t4 commented Jun 6, 2024

ahmedGaber93 left a comment

srikarparsi left a comment

srikarparsi commented Jun 6, 2024 •

edited

Loading

OSBotify commented Jun 6, 2024

OSBotify commented Jun 11, 2024

fix currency breaking issue with currency conversion #43133

fix currency breaking issue with currency conversion #43133

Conversation

b4s36t4 commented Jun 5, 2024 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Jun 5, 2024

b4s36t4 commented Jun 5, 2024

b4s36t4 commented Jun 5, 2024

ahmedGaber93 commented Jun 5, 2024

b4s36t4 commented Jun 5, 2024

b4s36t4 commented Jun 5, 2024

ahmedGaber93 commented Jun 5, 2024 • edited Loading

b4s36t4 commented Jun 5, 2024

b4s36t4 commented Jun 5, 2024

ahmedGaber93 commented Jun 5, 2024

ahmedGaber93 Jun 5, 2024

Choose a reason for hiding this comment

b4s36t4 Jun 5, 2024

Choose a reason for hiding this comment

ahmedGaber93 Jun 5, 2024

Choose a reason for hiding this comment

b4s36t4 Jun 5, 2024

Choose a reason for hiding this comment

ahmedGaber93 Jun 5, 2024 • edited Loading

Choose a reason for hiding this comment

ahmedGaber93 commented Jun 5, 2024

b4s36t4 commented Jun 5, 2024

ahmedGaber93 commented Jun 5, 2024

This comment was marked as outdated.

ahmedGaber93 commented Jun 5, 2024 • edited Loading

Reviewer Checklist

Screenshots/Videos

ahmedGaber93 commented Jun 5, 2024

b4s36t4 commented Jun 6, 2024

ahmedGaber93 left a comment

Choose a reason for hiding this comment

srikarparsi left a comment

Choose a reason for hiding this comment

srikarparsi commented Jun 6, 2024 • edited Loading

OSBotify commented Jun 6, 2024

OSBotify commented Jun 11, 2024

b4s36t4 commented Jun 5, 2024 •

edited

Loading

ahmedGaber93 commented Jun 5, 2024 •

edited

Loading

ahmedGaber93 Jun 5, 2024 •

edited

Loading

ahmedGaber93 commented Jun 5, 2024 •

edited

Loading

srikarparsi commented Jun 6, 2024 •

edited

Loading