[HOLD for payment 2024-06-20] [HOLD for payment 2024-06-18] [$250] Login - "The email entered is invalid" error isn't appearing when you tap away

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.72.1
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers):
Issue reported by: Applause - Internal Team

Action Performed:

1. Log out
2. Tap inside the email field
3. Enter an invalid email
4. Tap away so the field loses focus

Expected Result:

The message should appear as shown in mWeb and Web.

Actual Result:

"The email entered is invalid" error isn't appearing when you tap away from the email field that contains an invalid email address

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6479028_1715585189954.az_recorder_20240513_092158.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~016e7c19b20c3fa187
• Upwork Job ID: 1790156414947115008
• Last Price Increase: 2024-05-27
• Automatic offers:
• nkdengineer | Contributor | 102514414

Issue Owner

Current Issue Owner: @mollfpr

[melvin-bot]

Triggered auto assignment to @sonialiap (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[lanitochka17]

@sonialiap FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[lanitochka17]

We think that this bug might be related to #vip-vsp

[Krishna2323]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Login - "The email entered is invalid" error isn't appearing when you tap away

What is the root cause of that problem?

willBlurTextInputOnTapOutside is false for native devices.

App/src/libs/willBlurTextInputOnTapOutside/index.native.ts

Line 3 in 3bdb08d

const willBlurTextInputOnTapOutside: WillBlurTextInputOnTapOutside = () => false;

What changes do you think we should make in order to solve the problem?

Remove the willBlurTextInputOnTapOutside check from BaseLoginForm.

PS: I checked the behaviour on native devices, the input doesn't get blurred when we click on signin buttons (Apple/Google), we can safely remove willBlurTextInputOnTapOutside check and all file inside willBlurTextInputOnTapOutside folder.

What alternative solutions did you explore? (Optional)

Result

android_native.mp4

ios_native.mp4

[nkdengineer]

Proposal

Please re-state the problem that we are trying to solve in this issue.

• "The email entered is invalid" error isn't appearing when you tap away from the email field that contains an invalid email address

What is the root cause of that problem?

• In here, we only call validate if willBlurTextInputOnTapOutside: true, that leads to the bug.

• With native device, we assumed that As we have only two signin buttons (Apple/Google) other than the text input, for natives onBlur is called only when the buttons are pressed and we don't need to validate in those case as the user has opted for other signin flow.

• But, onBlur is also called if we click outside the input in Android like mentioned in OP (to reproduce it: 1. We need to focus on the input. 2. Then the keyboard is shown up. 3. Then click outside the input. Note that in this step, we need to make sure before clicking outside the input, the keyboard is still shown up)

What changes do you think we should make in order to solve the problem?

• We need to create the global variable, named didPressGoogleOrIOSButton to know whether the input is blurred because user clicked on Google or IOS buttons or not. It will be set once we press on Google or IOS button.

• Then, update this to:

 setTimeout(() => {
                                if (didPressGoogleOrIOSButton || firstBlurred.current || !Visibility.isVisible() || !Visibility.hasFocus()) {
                                    setDidPressGoogleOrIOSButton(false);
                                    return;
                                }
                                firstBlurred.current = true;
                                validate(login);
                               
                            }, 500)

• Then we need to clean-up the didPressGoogleOrIOSButton

What alternative solutions did you explore? (Optional)

• NA

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~016e7c19b20c3fa187

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mollfpr (External)

[Krishna2323]

Proposal Updated

• Added result video and note

[melvin-bot]

@sonialiap, @mollfpr Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[sonialiap]

@mollfpr what do you think of the updated proposal?

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[sonialiap]

@mollfpr gentle bump for reviewing the proposal

[mollfpr]

@Krishna2323 Removing willBlurTextInputOnTapOutside check will work on native but not on web. The error will appear on pressing the google/apple sign in.

[mollfpr]

We need to create the global variable, named didPressGoogleOrIOSButton to know whether the input is blurred because user clicked on Google or IOS buttons or not.

@nkdengineer Why do we need a global variable for that? Could the local state be enough?

Then we need to clean-up the didPressGoogleOrIOSButton

What does this step mean?

Also, you have 23 open PRs right now. Do you have the bandwidth for another issue?

[Krishna2323]

@mollfpr, willBlurTextInputOnTapOutside is already true for web.

App/src/libs/willBlurTextInputOnTapOutside/index.ts

Line 3 in e8ae3c5

const willBlurTextInputOnTapOutside: WillBlurTextInputOnTapOutside = () => true;

[nkdengineer]

Could the local state be enough?

Yes, I think so.

What does this step mean?

This step is redundant so I removed it from my proposal

[nkdengineer]

Also, you have 23 open PRs right now. Do you have the bandwidth for another issue?

There are a lot of PRs that are pending actions from the internal team, contributors plus, ... Also, I always try to update all the PRs before posting proposals for other issues.

[melvin-bot]

@sonialiap, @mollfpr Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[melvin-bot]

@sonialiap @mollfpr this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[melvin-bot]

📣 @nkdengineer 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[nkdengineer]

@mollfpr PR #42830 can be reviewed

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.81-11 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix Login error isn't appearing when you tap away #42830

If no regressions arise, payment will be issued on 2024-06-18. 🎊

For reference, here are some details about the assignees on this issue:

• @mollfpr requires payment through NewDot Manual Requests
• @nkdengineer requires payment automatic offer (Contributor)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@mollfpr] The PR that introduced the bug has been identified. Link to the PR:
• [@mollfpr] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@mollfpr] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@mollfpr] Determine if we should create a regression test for this bug.
• [@mollfpr] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@sonialiap] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.82-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix Login error isn't appearing when you tap away #42830

If no regressions arise, payment will be issued on 2024-06-20. 🎊

For reference, here are some details about the assignees on this issue:

• @mollfpr requires payment through NewDot Manual Requests
• @nkdengineer requires payment automatic offer (Contributor)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@mollfpr] The PR that introduced the bug has been identified. Link to the PR:
• [@mollfpr] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@mollfpr] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@mollfpr] Determine if we should create a regression test for this bug.
• [@mollfpr] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@sonialiap] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[sonialiap]

Payment summary:
@mollfpr reviewer $250 - please request in ND - please complete the checklist
@nkdengineer contributor $250 - paid ✔️

[melvin-bot]

@sonialiap, @mollfpr, @stitesExpensify, @nkdengineer Eep! 4 days overdue now. Issues have feelings too...

[mollfpr]

[@mollfpr] The PR that introduced the bug has been identified. Link to the PR:

#34863

[@mollfpr] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:

https://github.com/Expensify/App/pull/34863/files#r1653356984

[@mollfpr] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:

The regression step should be enough.

[@mollfpr] Determine if we should create a regression test for this bug.
[@mollfpr] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

Test case 1:

1. Go to sign-in page
2. Tap inside the email field
3. Enter an invalid email
4. Tap away so the field loses focus
5. Verify that the validate error is appear

Test case 2:

1. Go to sign-in page
2. Focus on the text input
3. Click on the Google sign-in button
4. Verify that the validate error doesn't appear

[JmillsExpensify]

$250 approved for @mollfpr