[HOLD for payment 2024-06-13] [HOLD for payment 2024-06-11] [QBO] Accounting - Multi tag - Not here page opens instead of subtag settings

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Issue found when validating #41351

Version Number: 1.4.73-0
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause Internal Team
Slack conversation:

Action Performed:

1. Go to staging.new.expensify.com
2. Go to workspace settings.
3. Go to Accounting.
4. Connect to QBO.
5. Click Import and import Classes and Customers/Projects.
6. Go to Tags.
7. Click Customers/Projects.
8. Click on any subtag.

Expected Result:

RHP for subtag settings will open.

Actual Result:

Not here page opens instead of subtag settings.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6479259_1715600425351.bandicam_2024-05-13_19-37-03-789.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @trjExpensify

[melvin-bot]

Triggered auto assignment to @greg-schroeder (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @youssef-lr (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open Staging deploy checklist to see the list of PRs included in this release, then work quickly on the following:

1. If you find which PR caused the issue/bug, you can reassign it to the person responsible for it.
   • If the author is OOO or won’t get online before the daily deploy is due, you are responsible for finding the best fix/path forward. Don’t hesitate to ask for help!
2. Try to reproduce the issue, if the bug is on production, remove the DeployBlocker label but stay assigned to fix it (or find out which PR broke it to get help from the author).
   • You can adjust the urgency of the issue to better represent the gravity of the bug.
   • If the issue is super low priority, feel free to un-assign yourself.
   • Be careful with PHP warnings, sometimes it is more complex than just adding a null coalescing operator as they might be uncovering some bigger bug.
   • If it was a one-off issue that requires no action (for example, Bedrock was down or it is a duplicated issue), you can close it.

Remember rule #2: Never un-assign yourself from a real DeployBlocker unless you are 100% sure someone else is assigned and will take care of it.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[m-natarajan]

@youssef-lr @greg-schroeder FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[m-natarajan]

We think that this bug might be related to #wave-collect - Release 1

[youssef-lr]

Removing blocker as QBO stuff is still behind a beta.

[youssef-lr]

cc @aldo-expensify @hayata-suenaga

[hayata-suenaga]

@s77rt, I think this is a regression from this PR. could you open a follow up issue?

[s77rt]

@hayata-suenaga As far as I know this is a backend issue, can you check if this PR is deployed https://github.com/Expensify/Web-Expensify/pull/41894

cc @MonilBhavsar

[MonilBhavsar]

The PR is merged and deployed. We should investigate root cause, and confirm if issue is caused by encoded tag name

[trjExpensify]

Hm, I don't think this is an encoding issue.

The tester looks to have used this QBO account (credentials in 1Password): Applause QBO & applausetester+qbo@applause.expensifail.com

Here's the customer record they clicked, which contains both a + operator and @ symbol: applausetester+0117mvt@applause.expensifail.com

That imports into a policy like so:

Displays like so in the tag list in OldDot:

On NewDot:

• any of the tag values in the Customers/Projects list can't be accessed, not just ones that may contains special character
• you can access the values of the first tag level of Classes fine:

2024-05-14_12-18-06.mp4

• if I disable the import of Classes and "Sync now" the connection such that Customers/Projects is the single level of tags on the workspace, I can access the individual tag values that are not accessible when they are in a multi tag list:

2024-05-14_12-22-43.mp4

Then, when I re-enable Classes and "Sync now" the connection such that Classes are now in the second level position for tags, I can't access any of the individual tag values in Classes:

2024-05-14_12-26-41.mp4

So I think this has something to do with accessing tag values when they are in the second level position in the tags list, @s77rt. Whichever tag list is in the second position on the tags page results in the tag values not being accessible. I.e

• Classes (tag values accessible)
• Customers/Projects (tag values not accessible)

OR

• Customers/Projects (tag values accessible)
• Classes (tag values not accessible)

[s77rt]

Yes! I need to pass the orderWeight in the url

[s77rt]

But now I'm seeing another problem, the renamePolicyTag API only supports changing tag names for the first tag list

[s77rt]

Raised a draft PR that fixes the not found issue but still need API commands to make it functional

Screen.Recording.2024-05-14.at.1.44.09.PM.mov

[hayata-suenaga]

@s77rt, thank you for raising the front end fix

Can you confirm the APIs that need to be changed in the backend?

• RenamePolicyTag
• RenamePolicyTaglist
• SetPolicyRequiresTag

I think we don't need changes for the DeletePolicyTags as the user cannot delete or create tags when there is accounting connection and we only have multi level tags when there is an accounting connection?

[s77rt]

RenamePolicyTaglist works already. We need:

• RenamePolicyTag
• SetPolicyRequiresTag (issue)
• SetPolicyTagsEnabled

[trjExpensify]

I think we don't need changes for the DeletePolicyTags as the user cannot delete or create tags when there is accounting connection and we only have multi level tags when there is an accounting connection?

That's correct on collect that multi-level tags will only be supported via an accounting integration, but on control workspaces we will support manual multi-level tags. That said, I think on OldDot the only way we support adding or deleting multi-level tags is via a CSV import to read/replace the lists. So I think I agree Add/Delete are out of scope for this here.

[trjExpensify]

Merged into the feature branch. 👍

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.78-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [NoQA] Add orderWeight to tag view and tag edit routes #42149

If no regressions arise, payment will be issued on 2024-06-11. 🎊

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@youssef-lr] The PR that introduced the bug has been identified. Link to the PR:
• [@youssef-lr] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@youssef-lr] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@youssef-lr] Determine if we should create a regression test for this bug.
• [@youssef-lr] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@trjExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.79-11 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [NoQA] Add orderWeight to tag view and tag edit routes #42149

If no regressions arise, payment will be issued on 2024-06-13. 🎊

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@youssef-lr] The PR that introduced the bug has been identified. Link to the PR:
• [@youssef-lr] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@youssef-lr] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@youssef-lr] Determine if we should create a regression test for this bug.
• [@youssef-lr] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@trjExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[trjExpensify]

This was a regression issue, right? So we can just close this? Feel free to let me know if that's inaccurate and we can reopen.