Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploy Checklist: New Expensify 2024-05-13 #42040

Closed
74 tasks done
github-actions bot opened this issue May 13, 2024 · 25 comments
Closed
74 tasks done

Deploy Checklist: New Expensify 2024-05-13 #42040

github-actions bot opened this issue May 13, 2024 · 25 comments
Assignees
Labels
🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging StagingDeployCash

Comments

@github-actions
Copy link
Contributor

github-actions bot commented May 13, 2024

Release Version: 1.4.73-7
Compare Changes: production...staging

This release contains changes from the following pull requests:

Deploy Blockers:

Deployer verifications:

  • I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
  • I checked Firebase Crashlytics and verified that this release does not introduce any new crashes. More detailed instructions on this verification can be found here.
  • I checked GitHub Status and verified there is no reported incident with Actions.

cc @Expensify/applauseleads

@Beamanator Beamanator added the 🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging label May 13, 2024
@OSBotify
Copy link
Contributor

🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/1.4.73-0 🚀

@kbecciv
Copy link

kbecciv commented May 13, 2024

Prod QA- #41710, #41715, #41858, #41863, #41992, #41993 - checking off

@rlinoz
Copy link
Contributor

rlinoz commented May 13, 2024

Demoting #42066

@Julesssss
Copy link
Contributor

Checking off #42045 as we have just CP'd a fix.

@tgolen
Copy link
Contributor

tgolen commented May 13, 2024

Checking off #42062 as NAB.

@tgolen
Copy link
Contributor

tgolen commented May 13, 2024

Checking off #42083 as NAB.

@kbecciv
Copy link

kbecciv commented May 13, 2024

TR is 45% left

#40020 - pending verification
#40336 - pending verification on Desktop and IOS app
#40443 - pending verification on mWeb, Desktop and IOS app
#40912 - pending verification
#40997 - pending verification
#41351 is failing with #42056
#41448 - pending verification on Desktop and IOS app
#41552 - pending verification
#41669 - pending verification
#41720 - pending verification
#41802 - pending verification on Android app
#42051 - pending verification

Deploy Blockers:
#42047
#42049
#42052
#42055
#42056
#42063
#42068
#42092

@kbecciv
Copy link

kbecciv commented May 13, 2024

TR is 15% left

#40336 - pending verification on IOS app
#40443 is failing with #42049 and #42052
#40997 - pending verification
#41351 is failing with #42056
#41448 - pending verification on Desktop and IOS app
#41552 is failing with #42113 on Desktop and IOS app
#41720 - pending verification in mWeb
#41802 - pending verification in Android app

Deploy Blockers:
#42047
#42049
#42052
#42056
#42063
#42068
#42090
#42092
#42096
#42100
#42113
#42114
#42115

@jasperhuangg
Copy link
Contributor

Demoted #42113 because it is for new functionality that doesn't exist on production yet.

@yuwenmemon
Copy link
Contributor

Checking off #42115 as it's not a blocker.

@mvtglobally
Copy link

TR is 4% left. Will provide next update morning EST

#40336 - is failing with #42070. repro in PROD. checking off
#40443 is failing with #42049 and #42052
#40997 - pending verification on mWeb
#41351 is failing with #42056
#41448 - pending verification on IOS app
#41552 is failing with #42113 on Desktop and IOS app
#41720 - is failing with KI #41720 (comment). Repro in PROD, checking off
#41802 - Is failing on Android with #42103. repro in PROD. checking off. One of the testers seeing crash #37469, but we were not able to repro (in case of any logs).

Deploy Blockers:
#42047
#42049
#42052
#42090
#42092
#42096
#42100
#42114
#42120

@Beamanator
Copy link
Contributor

Beamanator commented May 14, 2024

Looks like testrail is complete 👍

#42047 was fixed by #42064

@Beamanator
Copy link
Contributor

#42092 was fixed by #42106

@kbecciv
Copy link

kbecciv commented May 14, 2024

TR is completed!

#40443 is failing with #42049 and #42052
#40997 is failing with #40044, left comment #40997 (comment)
#41351 is failing with #42056
#41448 is failing with #42148 - issue is inconsistent, some testers able to reproduce, some doesn't.
#41552 is failing with #42113 on Desktop and IOS app
CP #42065 is validating now

Deploy Blockers:
#42049
#42052
#42063
#42090
#42096
#42100
#42114
#42120
#42148

@Julesssss
Copy link
Contributor

Checking off #42148 as a blocker. It's an edgecase (offline) and is related to a new feature.

@Beamanator
Copy link
Contributor

#42052 fixed by #42065 👍

@Beamanator
Copy link
Contributor

Checking off #42090 b/c it was reproduced in prod

@Beamanator
Copy link
Contributor

#42114 marked NAB, checked it off

@marcaaron
Copy link
Contributor

Demoting #42120

@Beamanator
Copy link
Contributor

Demoting #42096 b/c it's a pretty rare flow and the performance gains are valuable

@yuwenmemon
Copy link
Contributor

Checking off #42100

@jasperhuangg
Copy link
Contributor

Checking off #42063, was fixed by #42095

@Beamanator
Copy link
Contributor

#42171 fixed, checking off

@Beamanator
Copy link
Contributor

#42049 was fixed by #42128, checking off both

@Beamanator
Copy link
Contributor

:shipit:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging StagingDeployCash
Projects
None yet
Development

No branches or pull requests