[HOLD for payment 2024-07-26] [HOLD for payment 2024-07-10] [HOLD for payment 2024-07-02] IOU - Dismissing the error for corrupted PDF scan request does not delete the expense

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.73-1
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4556935
Email or phone of affected tester (no customers): applausetester+vd_ios051324@applause.expensifail.com
Issue reported by: Applause - Internal Team

Action Performed:

Pre-requisite: the user mist be logged in and be an employee of a workspace

1. Go to workspace chat
2. Submit an expense with scan option, select a corrupted PDF (can be found attached to this report)
3. Verify a red dot appears on the preview
4. Tap on the preview, verify the error "The receipt didn't upload. Download the file or dismiss this error and lose it." is displayed
5. Dismiss the error
6. Verify the expense is not deleted and is apparently still scanning

Expected Result:

The expense should be deleted after dismissing the error

Actual Result:

After dismissing the error, the expense is not deleted and is apparently still scanning

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6479957_1715637482134.Dpsq0122_1_.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @dylanexpensify

[melvin-bot]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open Staging deploy checklist to see the list of PRs included in this release, then work quickly on the following:

1. If you find which PR caused the issue/bug, you can reassign it to the person responsible for it.
   • If the author is OOO or won’t get online before the daily deploy is due, you are responsible for finding the best fix/path forward. Don’t hesitate to ask for help!
2. Try to reproduce the issue, if the bug is on production, remove the DeployBlocker label but stay assigned to fix it (or find out which PR broke it to get help from the author).
   • You can adjust the urgency of the issue to better represent the gravity of the bug.
   • If the issue is super low priority, feel free to un-assign yourself.
   • Be careful with PHP warnings, sometimes it is more complex than just adding a null coalescing operator as they might be uncovering some bigger bug.
   • If it was a one-off issue that requires no action (for example, Bedrock was down or it is a duplicated issue), you can close it.

Remember rule #2: Never un-assign yourself from a real DeployBlocker unless you are 100% sure someone else is assigned and will take care of it.

[melvin-bot]

Triggered auto assignment to @marcaaron (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[lanitochka17]

@marcaaron FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[melvin-bot]

Triggered auto assignment to @dylanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[marcaaron]

Not sure if it's External but does not seem worth blocking the deploy over.

[nkdengineer]

Proposal

Please re-state the problem that we are trying to solve in this issue.

• After dismissing the error, the expense is not deleted and is apparently still scanning

What is the root cause of that problem?

• In here, we do not delete the expense if the error is isReceiptError.

What changes do you think we should make in order to solve the problem?

• We need to check if the dismissed error is isReceiptError. If true, we should delete that expense like we delete the expense using deleteTransaction in here

• To do it, in here, we can add the below logic:

if(Object.values(transaction?.errors ?? {})?.find((error)=>isReceiptError(error))){
                                deleteTransaction()
                            }

with deleteTransaction is the same as here orand here

What alternative solutions did you explore? (Optional)

NA

[melvin-bot]

@dylanexpensify Whoops! This issue is 2 days overdue. Let's get this updated quick!

[melvin-bot]

@dylanexpensify Still overdue 6 days?! Let's take care of this!

[dylanexpensify]

@lanitochka17 can you re-upload the repro video? Seems not to be working in OP

[lanitochka17]

Bug6479957_1715637482134.Dpsq0122_1_.1.mp4

[melvin-bot]

@dylanexpensify this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[melvin-bot]

@dylanexpensify Huh... This is 4 days overdue. Who can take care of this?

[dylanexpensify]

@lanitochka17 still not working!

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.9-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix: remove receipt when upload fail #45574

If no regressions arise, payment will be issued on 2024-07-26. 🎊

For reference, here are some details about the assignees on this issue:

• @eh2077 requires payment (Needs manual offer from BZ)
• @nkdengineer requires payment (Needs manual offer from BZ)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@eh2077] The PR that introduced the bug has been identified. Link to the PR:
• [@eh2077] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@eh2077] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@eh2077] Determine if we should create a regression test for this bug.
• [@eh2077] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@dylanexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[dylanexpensify]

Payment coming up!

[melvin-bot]

Triggered auto assignment to @bfitzexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[dylanexpensify]

@bfitzexpensify I'm heading OOO starting this afternoon, so reassigning for payment! TY!

[melvin-bot]

Payment Summary

Upwork Job

• ROLE: @eh2077 paid $(AMOUNT) via Upwork (LINK)
• ROLE: @nkdengineer paid $(AMOUNT) via Upwork (LINK)

BugZero Checklist (@bfitzexpensify)

• I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
• I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
• I have paid out the Upwork contracts or cancelled the ones that are incorrect
• I have verified the payment summary above is correct

[eh2077]

Checklist

• [@eh2077] The PR that introduced the bug has been identified. Link to the PR: This is actually a new feature, so there isn't a PR causes it.
• [@eh2077] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: N/A
• [@eh2077] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
• [@eh2077] Determine if we should create a regression test for this bug. Yes

Regression test

1. Submit a manual expense
2. Click QAB
3. Choose Quick Action
4. Click Scan
5. Select a corrupted PDF
6. Tap on the preview, verify the error "The receipt didn't upload. Download the file or dismiss this error and lose it." is displayed
7. Dismiss the error
8. Verify that: The expense should be deleted

Do we agree 👍 or 👎

[bfitzexpensify]

Regression test proposed and offers sent.

[eh2077]

Hi @bfitzexpensify, can you please issue the payment as well? It seems you just ended the contract without approving the payment

[bfitzexpensify]

Weird, thanks for flagging - should be all sorted now.

[bfitzexpensify]

Payments complete.