[DEV] FAB menu items broken

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: Main
Reproducible in staging?: N/A
Reproducible in production?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @thienlnam
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1715715895936109

Action Performed:

1. Launch the app
2. Tap the plus icon

Expected Result:

Context menu displayed without any issues

Actual Result:

Context menu broken

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @abekkala (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @NikkiWines (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[thienlnam]

Currently on main only, but something we should fix before we even ship to staging

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[allgandalf]

This is not a deploy blocker @thienlnam , I have the staging app on physical iOS device , I don't see the bug there, the bug seems to be on main and not yet merged on staging environment

Sorry my bad, saw your comment now

[ishpaul777]

Offending PR https://github.com/Expensify/App/pull/41670/files#r1600629321, there's a extra View wrapping MenuItem content which caused this, commented on PR #41670 (comment)

cc @narefyev91 @s77rt

[s77rt]

Thanks @ishpaul777!

[s77rt]

Raised a PR #42178

[ishpaul777]

I am available for few hours let me know if we need ac c+ for checklist : )

[Beamanator]

This loooks like a small enough fix that we won't need a C+ review, thanks @ishpaul777 - I'll review shortly!

[Beamanator]

Merged - thanks for the quick fix @s77rt !

[abekkala]

Looks like the only payment here will be to @s77rt for the fix
(Internal PR Review)

@Beamanator can you confirm what that payout amount is for this quick fix?

[s77rt]

@abekkala No payment is required here since it was a regression from a PR that I reviewed

[s77rt]

We can close this issue