Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Web - Settings - Dropdown symbol overlaps with text in the box #4207

Closed
5 tasks done
kavimuru opened this issue Jul 24, 2021 · 11 comments
Closed
5 tasks done

Web - Settings - Dropdown symbol overlaps with text in the box #4207

kavimuru opened this issue Jul 24, 2021 · 11 comments
Assignees
Labels
Daily KSv2 DeployBlockerCash This issue or pull request should block deployment Engineering External Added to denote the issue can be worked on by a contributor Hourly KSv2

Comments

@kavimuru
Copy link

kavimuru commented Jul 24, 2021

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Go to https://staging.new.expensify.com/
  2. Go to Settings - Preferences
  3. Select any drop down

Expected Result:

Drop downs in Preferences page shouldn't overlap with text inside the box

Actual Result:

Drop downs in Preferences page are overlapping with text

Workaround:

Visual

Platform:

Where is this issue occurring?

  • Web
  • iOS
  • Android
  • Desktop App
  • Mobile Web

Version Number:
1.0.80-0
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:
Bug5164745_Langguage

Expensify/Expensify Issue URL:

View all open jobs on Upwork

@kavimuru kavimuru added the DeployBlockerCash This issue or pull request should block deployment label Jul 24, 2021
@OSBotify
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@MelvinBot
Copy link

Triggered auto assignment to @robertjchen (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@parasharrajat
Copy link
Member

parasharrajat commented Jul 24, 2021

it is a regression.

@robertjchen
Copy link
Contributor

I was able to reproduce this myself- seems like a visual issue, assigning to External for resolution.

@robertjchen robertjchen added the External Added to denote the issue can be worked on by a contributor label Jul 26, 2021
@MelvinBot
Copy link

Triggered auto assignment to @JmillsExpensify (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

@MelvinBot MelvinBot added the Daily KSv2 label Jul 26, 2021
@robertjchen robertjchen removed their assignment Jul 26, 2021
@parasharrajat
Copy link
Member

@robertjchen. This is a regression from #4180.

Root cause.

40f145e

@roryabraham
Copy link
Contributor

@robertjchen Generally issues labelled DeployBlockerCash should be treated as internal. In this case, since @parasharrajat has already tracked the source of the regression to #4180, I think we should just revert it, giving @helaoutar a chance to retry the PR without causing a regression.

@roryabraham
Copy link
Contributor

Revert PR here

@roryabraham
Copy link
Contributor

@helaoutar fixed this in this PR, so I closed the revert PR.

@roryabraham
Copy link
Contributor

@isagoico, I see you checked this off on the deploy checklist so I'm assuming this is fix is verified. Closing this out :)

@isagoico
Copy link

Yep! I thought I had left a comment here. I retested and it was a pass 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Daily KSv2 DeployBlockerCash This issue or pull request should block deployment Engineering External Added to denote the issue can be worked on by a contributor Hourly KSv2
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants