Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Web - Settings - Dropdown symbol overlaps with text in the box #4243

Merged
merged 1 commit into from
Jul 27, 2021
Merged

Web - Settings - Dropdown symbol overlaps with text in the box #4243

merged 1 commit into from
Jul 27, 2021

Conversation

helaoutar
Copy link
Contributor

@helaoutar helaoutar commented Jul 27, 2021 •
edited by roryabraham
Loading

Details

The PR that caused this issue changed a class that's being used in other places..

Fixed Issues

$ #4207

Tests

QA Steps

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

Screenshot 2021-07-27 at 01 33 54

Mobile Web

Screenshot 2021-07-27 at 01 33 59

Desktop

Screenshot 2021-07-27 at 01 37 43

iOS

image

Android

Screenshot_20210727-015523_Expensifycash

@helaoutar helaoutar requested a review from a team as a code owner July 27, 2021 00:38
@MelvinBot MelvinBot requested review from cead22 and removed request for a team July 27, 2021 00:39
@roryabraham
Copy link
Contributor

roryabraham commented Jul 27, 2021 •
edited
Loading

This failing check for Explain Cherry-Pick label... is totally unrelated and a red herring for this known GH Actions bug. That bug hasn't happened in a while, but when it does it fails consistently, and there's like nothing we can do about it 🤷 It's also not a test, just an automated comment, so it's safe to ignore

roryabraham
roryabraham approved these changes Jul 27, 2021
View reviewed changes
Copy link
Contributor

@roryabraham roryabraham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the quick fix!

@roryabraham
Copy link
Contributor

Merging this to fix a deploy blocker

@roryabraham roryabraham merged commit dbf4579 into Expensify:main Jul 27, 2021
This was referenced Jul 27, 2021
Closed
Merged
github-actions bot pushed a commit that referenced this pull request Jul 27, 2021
@roryabraham
Merge pull request #4243 from helaoutar/bugfix/center_new_expensify_i…
d29e304 
…con_in_about_page_

Web - Settings - Dropdown symbol overlaps with text in the box

(cherry picked from commit dbf4579)
This was referenced Jul 27, 2021
Merged
Closed
@OSBotify
Copy link
Contributor

🚀 Cherry-picked to staging in version: 1.0.80-1🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify OSBotify mentioned this pull request Jul 28, 2021
Closed
71 tasks
@OSBotify
Copy link
Contributor

🚀 Deployed to production in version: 1.0.80-2🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to staging in version: 1.0.80-3🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production in version: 1.0.81-4🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify OSBotify mentioned this pull request Jul 30, 2021
Closed
100 tasks
@helaoutar helaoutar mentioned this pull request Aug 2, 2021
Closed
This was referenced Aug 6, 2021
Closed
Closed
@OSBotify OSBotify mentioned this pull request Aug 17, 2021
Closed
This was referenced Aug 25, 2021
Closed
Closed
This was referenced Sep 2, 2021
Closed
Closed
@OSBotify OSBotify mentioned this pull request Aug 16, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roryabraham roryabraham roryabraham approved these changes

@cead22 cead22 Awaiting requested review from cead22

Assignees

@helaoutar helaoutar

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@helaoutar @roryabraham @OSBotify