[HOLD for payment 2024-08-02] [$250] Video - Change in playback speed is not reflected in thread report

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.75-0
Reproducible in staging?: Y
Reproducible in production?: N
**If this was caught during regression testing, add the test name, ID and link from TestRail:**N/A
Email or phone of affected tester (no customers): natnael.expensify+3@gmail.com
Issue reported by: Applause - Internal Team

Action Performed:

1. Navigate to a report
2. Send a video
3. Reply in a thread to the video
4. Navigate back to the main report
5. Change playback speed
6. Navigate to the thread report
7. Click on 'Three dots' > 'Playback speed'

Expected Result:

Changes in Playback speed from the main report should be reflected in the thread report

Actual Result:

Changes in playback speed from the main report is not reflected in the thread report

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6489315_1716463467872.Screen_Recording_2024-05-23_at_12.41.26_in_the_afternoon.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01aa9734a896a98cbf
• Upwork Job ID: 1793619475924013056
• Last Price Increase: 2024-06-06
• Automatic offers:
• situchan | Reviewer | 102822043
• tienifr | Contributor | 102822045

Issue Owner

Current Issue Owner: @situchan

[melvin-bot]

Triggered auto assignment to @Julesssss (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open Staging deploy checklist to see the list of PRs included in this release, then work quickly on the following:

1. If you find which PR caused the issue/bug, you can reassign it to the person responsible for it.
   • If the author is OOO or won’t get online before the daily deploy is due, you are responsible for finding the best fix/path forward. Don’t hesitate to ask for help!
2. Try to reproduce the issue, if the bug is on production, remove the DeployBlocker label but stay assigned to fix it (or find out which PR broke it to get help from the author).
   • You can adjust the urgency of the issue to better represent the gravity of the bug.
   • If the issue is super low priority, feel free to un-assign yourself.
   • Be careful with PHP warnings, sometimes it is more complex than just adding a null coalescing operator as they might be uncovering some bigger bug.
   • If it was a one-off issue that requires no action (for example, Bedrock was down or it is a duplicated issue), you can close it.

Remember rule #2: Never un-assign yourself from a real DeployBlocker unless you are 100% sure someone else is assigned and will take care of it.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[lanitochka17]

We think that this bug might be related to #vip-vsp

[lanitochka17]

@Julesssss FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[Julesssss]

Thanks.

This should not block deploy IMO. Removing the label.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01aa9734a896a98cbf

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @situchan (External)

[melvin-bot]

Triggered auto assignment to @mallenexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[tienifr]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Changes in playback speed from the main report is not reflected in the thread report

What is the root cause of that problem?

This starts happening after this PR

Assuming in the main report's video player, we set the playback speed to 2.

When we open the popover menu, we're setting the playback speed that the player is currently playing at here.

However, when we go to child report, the player's speed is not synced with the speed of the player in the main report (it's still playing 1). So when we open playback menu it shows 1.

What changes do you think we should make in order to solve the problem?

We should make sure if the video has the same source URL as the video in videoPopoverMenuPlayerRef, we'll set the playback speed to the current playback speed of VideoPopoverMenuContext

So below here

if (!videoPopoverMenuPlayerRef.current || videoPopoverMenuPlayerRef.current?.props?.source?.uri !== sourceURL) {
    return;
}

videoPlayerRef.current?.setStatusAsync?.({rate: currentPlaybackSpeed});

In there, the currentPlaybackSpeed should be exposed from VideoPopoverMenuContextProvider here

() => ({menuItems, videoPopoverMenuPlayerRef, updatePlaybackSpeed, setCurrentPlaybackSpeed, currentPlaybackSpeed}),

We could improve this further by creating a local cache of the playback speed, cached by sourceURL, so in the above, if we find that the cached playback speed of the same sourceURL is different from the current playback speed, we'll set the current playback speed to that cached value. We have the same pattern for caching the image dimensions.

What alternative solutions did you explore? (Optional)

NA

[mallenexpensify]

@situchan , 👀 on the proposal above plz

[situchan]

Proposals are in review

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.12-0 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix: video playback speed is not synced in thread #44234

If no regressions arise, payment will be issued on 2024-08-02. 🎊

For reference, here are some details about the assignees on this issue:

• @situchan requires payment automatic offer (Reviewer)
• @tienifr requires payment automatic offer (Contributor)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@situchan] The PR that introduced the bug has been identified. Link to the PR:
• [@situchan] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@situchan] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@situchan] Determine if we should create a regression test for this bug.
• [@situchan] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@mallenexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[Julesssss]

It seems that QA noticed the issue not fixed for Android, lets hold payment for now. @tienifr could you take a look please?

[tienifr]

I'm stuck on other issue, I'll try to fix that issue in one or two days

[tienifr]

The PR is ready for review cc @Julesssss @situchan

[mallenexpensify]

In the PR I'm not seeing that it was deployed to production.

• fix: do not update new rate when open popover #46800 (comment)

@situchan @tienifr , any idea what might be going on? I want to update the title to reflect the correct payment date

[mallenexpensify]

@situchan @tienifr 👀 on the comment above plz so I can get you paid (assuming it's needed)

[situchan]

There was bug on that deploy. Melvin didn't post deploy comment on all PRs in this checklist.
cc: @Beamanator

[Beamanator]

Agreed 👍 I posted in the PR about it being deployed to prod here - #46800 (comment)

[mallenexpensify]

d;oh, sorry, I should have seen that comment.
Contributor: @tienifr owed $250 via NewDot
Contributor+: @situchan paid $250 via NewDot.

@situchan plz complete the BZ checklist above? Thx

[situchan]

• The PR that introduced the bug has been identified. Link to the PR: Playback speed is not displayed correctly in video player #40646 #41055
• The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/41055/files#r1725293900
• A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A

Regression Test Steps

1. Send a video to any chat
2. Reply the video in thread
3. Navigate to parent report
4. Change playback speed
5. Navigate to thread
6. Open playback speed menu
7. Verify thread's playback speed is the same with parent's

[mallenexpensify]

Thanks @situchan
Test Case GH created

• https://github.com/Expensify/Expensify/issues/423309

[garrettmknight]

@tienifr paid $250 via NewDot