Deploy Checklist: New Expensify 2024-08-12

[github-actions]

Release Version: 9.0.19-11
Compare Changes: production...staging

This release contains changes from the following pull requests:

• fix Hide video playback controls on auto-playing videos #43349
• [Advanced approvals] Add optimistic steps for advanced approvals #44940
• [Held requests] Clean up the hold/unhold logic #45151
• fix: drop user to main chat screen after onboarding #45705
• fix: Split - Enter and CMD+Enter open user profile instead of splitting expense. #46278
• Fix flaky pod installs #46316
• Display optimistic fields violations for single expense reports #46425
• [No QA] Fix deploy comments to correctly identify CPs and non-CPs #46535
• Fix no error when saving same tag name in X:Y format #46556
• fix: archived reports are unable to mark as read #46569
• RBR display in LHN, Inbox and Workspace list #46575
• Fix the new message button doesn't work on some comment linkings #46627
• Fix missing join thread on system message #46640
• [No QA] Polish: Update Next Steps Copy to Match Backend #46686
• Fix app crashes when edit the video with text #46693
• fix: Attachment - A broken video file is loaded via action menu. #46701
• Fix get newer actions is called when going back from the expense page or scroll down to bottom #46787
• fix: update volume to 0.25 if unmute but volume is 0 #46795
• Composer: add clear command that bypasses the event count #46796
• Add keyword advanced filter for Search #46799
• fix: do not update new rate when open popover #46800
• Fix multiple console errors when login and in onboarding welcome video #46854
• Fix/46488 fix modal centering #46860
• Fix loading skeleton appears in the workspace expense thread after sending an IOU expense request #46864
• Make comment as optional of transaction and use optional chaining #46869
• Prevent submitters from editing forwarded reports on Control #46931
• fix: Initial value report field is present which leads to blank page #46938
• Fix company's website step is skipped #46940
• Display loading while image is resizing #46944
• Fix login page blinking on launch #46947
• feat: create usePolicy hook #46956
• [Ideal-nav] Fix navigate to search tab #46970
• fix: Sending a text+attachment displays text with ellipsis #46976
• fix: create expense with colon tag returns error #46977
• [No QA]Start using GitHub pre-releases for staging deploys #47008
• [No QA]Delete workflow tests #47012
• fix: Press enter key in Survey response page #47025
• Update error message for tasks #47032
• Fix checkmark show briefly when selecting item #47034
• fix: approve button doesn't show up #47040
• improve isConciergeChatReport performance #47043
• Bump Onyx to 2.0.64 #47045
• Show duplicate red dot error in conversation & report #47056
• Show receipt issue found when the amount/date mismatch the receipt #47094
• [No QA] Update CONTRIBUTING.md to link to working link list on Upwork #47102
• [No QA] Add Xero New Dot Images to the Image repo #47118
• Remove the note of cards from the settings menu to only leave domains #47119
• Update Export-expenses.md #47122
• Update Configure-Quickbooks-Online.md #47129
• Update Quickbooks-Online-Troubleshooting.md #47131
• When verifying secondary login, set it as the primary login if primary login isn't validated yet #47132
• Create Xero-Troubleshooting #47135
• Update Configure-Xero.md #47137
• fix: Share somewhere should have the required label. #47141
• [No QA]: Add safe check for policy id instead of -1 fallback #47165
• [NoQA] fix: e2e typing test #47176
• 🍒 Fix crash on staging #47180
• [No QA] Fix a console warning in search page #47185
• [NoQA] Modify the Deploy Blocker text #47188
• fix: Report fields - List values field does not show the content in alphabetical order. #47198
• [NoQA] Add token to the gh release call #47220
• [CP Staging] Fix reply in thread missing after rejoined system message thread #47234
• [CP Staging] fix: Report fields - App crashes when disabling/enabling list values via checkbox & dropdown button. #47244
• [No QA]Use github.event.release.tag_name instead of github.ref_name for releases #47250
• [No QA]Tag the staging branch instead of main for pre-release #47253
• [No QA]Add github token to each gh release upload #47266
• [No QA]Add a \ to fix iOS release upload #47267
• [CP Staging] Remove policyIDs route param when workspace is deleted #47269
• [No QA] Add better logs for verifying web deploys #47275
• [CP Staging] Temporarily returns "https://" as the default website #47345

Internal QA:

• [NoQA] Chore: Analytics - split SWITCH_REPORT event #46966 - @mountiny

Deploy Blockers:

• [HOLD for payment 2024-08-19] [$250] Expense - Receipt thumbnail shows a green receipt placeholder while it is uploading #47050
• [hold for payment 2024-08-26] [$250] Split - Unable to split expense with workspace via FAB #47159
• [HOLD for payment 2024-08-20] Expense - Reply in thread option is missing for system message after rejoining thread #47225
• [HOLD for payment 2024-08-20] Bank account - Unable to proceed after website step when website is auto populated #47227
• Report fields - App crashes when disabling/enabling list values via checkbox & dropdown button #47230
• [$250] Hold expense - RBR is not shown instantly when holding expense from main chat #47240
• [Held requests] Hold button on expense preview appears only if open the expense first #47241
• [$250] Scan - "Delete" and "Replace" options are displayed for an admin which causes an error #47242
• [Guided Setup] Sign in – Able to dismiss Onboarding modal when click on browser back button #47246
• LHN - Missing space between user and to in "invited 1 userto #room" when inviting user to room #47248
• [$250] Expense report -"Required" Error Not Triggered for Auto-Filled Report Field on Second Expense Submission #47251
• Workspace - Second Expense Submission Delayed in Workspace After Paying First Expense Elsewhere #47252
• [C+ Checklist Needs Completion] [$250] Search-Expenses tab does not update to show all expenses after deleting the filtered workspace #47263
• [$500] Approve button not disappear after approving report offline if advanced approval set #47264
• Expense - Employee can edit paid expense but error shows up when advanced approvals is enabled #47265
• [HOLD for Payment 2024-09-06] [$250] Tag-After unselecting state option, region selected is shown in state field. #47301

Deployer verifications:

• I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
• I checked Firebase Crashlytics and verified that this release does not introduce any new crashes. More detailed instructions on this verification can be found here.
• I checked GitHub Status and verified there is no reported incident with Actions.

cc @Expensify/applauseleads

[Beamanator]

Uhhhh where are the deploy blockers 🤣

• Aah, this is being discussed internally here: https://expensify.slack.com/archives/C07J32337/p1723478316279429

[francoisl]

Demoted #47241

[blimpich]

Demoted #47248

[Beamanator]

Some PRs got added to the checklist but aren't in staging yet. Examples:

• #46949: Fix Results, Loading and Empty state Search pages #47164
• Optimize isPendingRemove function #47228

I'm removing them from the checklist and I'll add them here - I also brought this up in Slack here

Update: Now it's looking like those PRs might actually be in staging even though they're not in the staging branch? So I added them back to the checklist

[Beamanator]

Checking off #47159 b/c it was somehow checked off in the previous checklist & now the root cause PR (#42302) is in Prod 😅

[kavimuru]

Regression is 41% progress

Unchecked PRs:

#44940 Validation pending in iOS android desktop and mweb
#45151 Validation pending in Desktop
#46425 Validation pending in iOS
#46556 #46556 (comment)
#46575 Validation pending in iOS
#46627 Validation pending in iOS and desktop
#46640 Validation pending in iOS
#46787 Validation pending in iOS and desktop
#46795 Validation pending in iOS and desktop
#46860 Validation pending in mweb and desktop
#46869 Validation pending in mweb
#46931 All platforms are pending validation
#47056 #47056 (comment)

[Beamanator]

Demoted #47246

[Beamanator]

Also demoting #47265

[kavimuru]

Regression is at 50%
Unchecked PRs:

#44940 Validation pending in iOS android desktop and mweb
#45151 Validation pending in Desktop
#46425 Validation pending in iOS
#46556 #46556 (comment)
#46575 Validation pending in iOS
#46627 Validation pending in iOS and desktop
#46640 Validation pending in iOS
#46787 Validation pending in iOS and desktop
#46795 Validation pending in iOS and desktop
#46860 Validation pending in mweb and desktop
#46931 Validation pending in iOS android desktop and mweb
#47056 #47056 (comment)
and cps

[Beamanator]

#47244 fixed #47230 on staging - checking both off

[Beamanator]

Demoted #47251 b/c report fields are behind a beta

[Beamanator]

^ similar w/ #47252

[Beamanator]

Checked off #46966 b/c "No QA"

[grgia]

demoting #47301

[kavimuru]

Regression is still 11% left.
#44940 Validation pending in iOS android desktop and mweb
#45151 Validation pending in Desktop
#46425 failing with #46215 and repro in production checking it off
#46556 #46556 (comment)
#46787 Validation pending in desktop
#46795 Validation pending in desktop
#46860 Validation pending in desktop
#46931 Validation pending in iOS android desktop and mweb
#47056 #47056 (comment)

[Beamanator]

#47234 fixed #47225 in staging! checking both off

[Beamanator]

#47269 fixed #47263 in staging, checking both off

[Beamanator]

#46556 (comment) handled in #47289 but doesn't need to be CP'd b/c the fix fixed a bug in prod 😅

[Beamanator]

Checking off #44940 b/c it's not available for most users on NewDot yet

[Beamanator]

Checking off #45151 b/c its related deploy blocker #47241 was demoted

[Beamanator]

Checking off #46795 b/c bug found is also on prod, so not related to this PR

[Beamanator]

Checking off #46860 b/c its related blocker #47239 was demoted

[Beamanator]

Checked off #47050 b/c it was an old blocker that was closed w/ the labels, and just reopened for payment... But it's not a blocker for this latest release

[Beamanator]

#47056 QA fail is NAB since it didn't introduce a new bug, it just didn't full fix the bug that already exists on prod

[Beamanator]

checking off #46944 b/c it looks good!

[Beamanator]

#46787 testing well so checking it off

[Beamanator]

Demoted #47242, which means also checking off #46931 - the potential bugs will still be considered by @youssef-lr when he's online, but shouldn't be considered blockers