[$250] Share somewhere should have the required label

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.17-0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @srikarparsi
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1722971070414349

Action Performed:

1. Click FAB
2. Click Assign Task
3. Enter in a title and click next

Expected Result:

Share somewhere should have a required label

Actual Result:

Share somewhere does not have a required label even though it’s a required field

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Recording.422.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~011e4b40febf7aafce
• Upwork Job ID: 1820902011151409529
• Last Price Increase: 2024-08-06
• Automatic offers:
• rayane-djouah | Reviewer | 103444475
• Krishna2323 | Contributor | 103444476

Issue Owner

Current Issue Owner: @RachCHopkins

[melvin-bot]

Triggered auto assignment to @RachCHopkins (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~011e4b40febf7aafce

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @rayane-djouah (External)

[Krishna2323]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Share somewhere should have the required label

What is the root cause of that problem?

Right label is not added.

App/src/pages/tasks/NewTaskPage.tsx

Line 196 in 6263c24

titleWithTooltips={shareDestination?.shouldUseFullTitleToDisplay ? undefined : shareDestination?.displayNamesWithTooltips}

What changes do you think we should make in order to solve the problem?

Add right label for required.

rightLabel={translate('common.required')}

Same can be done for assignee.

What alternative solutions did you explore? (Optional)

[rayane-djouah]

@Krishna2323 - Share somewhere is the only required one, Assignee is not required

[rayane-djouah]

@Krishna2323's proposal looks good to me.

🎀👀🎀 C+ reviewed

[melvin-bot]

Current assignee @srikarparsi is eligible for the choreEngineerContributorManagement assigner, not assigning anyone new.

[rayane-djouah]

Task title is also required.

App/src/pages/tasks/NewTaskPage.tsx

Lines 101 to 114 in 6263c24

	if (!task?.title && !task?.shareDestination) {
	setErrorMessage(translate('newTaskPage.confirmError'));
	return;
	}
	if (!task.title) {
	setErrorMessage(translate('newTaskPage.pleaseEnterTaskName'));
	return;
	}
	if (!task.shareDestination) {
	setErrorMessage(translate('newTaskPage.pleaseEnterTaskDestination'));
	return;
	}

[melvin-bot]

📣 @rayane-djouah 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[melvin-bot]

📣 @Krishna2323 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[srikarparsi]

Great thanks!

[Krishna2323]

@rayane-djouah, PR ready for review ^

[rayane-djouah]

Note

The production deploy automation failed: This should be on [HOLD for Payment 2024-08-20] according to #47219 prod deploy checklist, confirmed in #47141 (comment).

cc @RachCHopkins @srikarparsi

[rayane-djouah]

Checklist

• The PR that introduced the bug has been identified. Link to the PR: There is no offending PR. We were not displaying a required label on the new task page, so this is a new feature.
• The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: N/A
• A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
• Determine if we should create a regression test for this bug. Yes
• If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

Regression Test Proposal

1. Click FAB
2. Click Assign Task
3. Enter in a title and click next
4. Verify share somewhere field has a "Required" label.

Do we agree 👍 or 👎

cc @RachCHopkins

[Krishna2323]

@RachCHopkins, this is ready for payments :) #46919 (comment)

[RachCHopkins]

Payment Summary:

Contributor: @Krishna2323 paid $250 via Upwork
Contributor+: @rayane-djouah paid $250 via Upwork
Upwork job here

[RachCHopkins]

Contributors have been paid, the contract has been completed, and the Upwork post has been closed.