[CP Staging] Remove policyIDs route param when workspace is deleted #47269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
melvin-bot
bot
requested review from
alitoshmatov
and removed request for
a team
|
@alitoshmatov Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
marcochavezf
requested review from
allgandalf
and removed request for
alitoshmatov
Reviewer Checklist
Screenshots/VideosAndroid: Nativehttps://github.com/user-attachments/assets/f4911258-12cc-4771-89bf-e6df7877b547Android: mWeb ChromeScreen.Recording.2024-08-13.at.4.39.01.AM.moviOS: NativeScreen.Recording.2024-08-13.at.4.46.12.AM.moviOS: mWeb SafariMacOS: Chrome / SafariScreen.Recording.2024-08-13.at.4.04.46.AM.movMacOS: DesktopScreen.Recording.2024-08-13.at.4.10.45.AM.mov |
allgandalf
approved these changes
Aug 12, 2024
|
@aldo-expensify Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
iOS did built successfully, updated the video 🥳 |
aldo-expensify
approved these changes
Aug 12, 2024
Comment on lines
93
to
+95
| const {q, ...rest} = currentSearchParams; | ||
| Navigation.navigate(ROUTES.SEARCH_CENTRAL_PANE.getRoute({query: q, ...rest})); | ||
| const policy = PolicyUtils.getPolicy(currentSearchParams?.policyIDs); | ||
| Navigation.navigate(ROUTES.SEARCH_CENTRAL_PANE.getRoute({query: q, ...rest, policyIDs: policy ? currentSearchParams?.policyIDs : undefined})); |
There was a problem hiding this comment.
NAB: I think it would have been a bit cleaner/consistent if you had done:
++ const {q, policyIDs, ...rest} = currentSearchParams;
-- const {q, ...rest} = currentSearchParams;
|
This will need to be CP'd, right? |
marcochavezf
changed the title
Yup, I will request the CP now |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
OSBotify
pushed a commit
that referenced
this pull request
Aug 13, 2024
[CP Staging] Remove policyIDs route param when workspace is deleted (cherry picked from commit 4b30725) (CP triggered by Beamanator)
90 tasks
|
🚀 Cherry-picked to staging by https://github.com/Beamanator in version: 9.0.19-8 🚀
@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes. |
|
@marcochavezf @aldo-expensify @allgandalf anyone free to test this on staging? 🙏 |
Performance Comparison Report 📊Significant Changes To Duration
Show details
Meaningless Changes To DurationShow entries
Show details
|
github-actions
bot
added
the
DeployBlockerCash
|
@Expensify/mobile-deployers 📣 Please look into this performance regression as it's a deploy blocker. |
|
Note: This PR probably hasn't introduced the recession. The regression has been introduced at an earlier point, and the CI system will report any PR that follows this faulty PR as a regression. |
6 tasks
Beamanator
removed
the
DeployBlockerCash
|
Makes sense to me, removing the deploy blocker from this PR 👍 |
|
FYI I believe this was deployed to prod yesterday, from this checklist - #47219 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @nkdengineer
Details
Check if the workspace still exists before creating a route with the non-existent policyID
Fixed Issues
$ #47263
PROPOSAL: #47263 (comment)
Tests
Offline tests
N/A
QA Steps
Same as test steps
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)myBool && <MyComponent />.src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
Screen.Recording.2024-08-12.at.4.19.09.p.m.mov
MacOS: Desktop