[CP Staging] fix: Report fields - App crashes when disabling/enabling list values via checkbox & dropdown button. #47244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…via checkbox & dropdown button. Signed-off-by: krishna2323 <belivethatkg@gmail.com>
|
Recordings will be added in few minutes. cc: @mananjadhav |
|
@mananjadhav seems to be offline for today. Let me know if this is urgent. I can review. @mountiny |
|
PR ready. cc: @mountiny |
Beamanator
requested review from
allroundexperts
and removed request for
c3024
6 tasks
Beamanator
changed the title
Reviewer Checklist
Screenshots/VideosAndroid: NativeScreen.Recording.2024-08-13.at.5.49.05.AM.movAndroid: mWeb ChromeScreen.Recording.2024-08-13.at.5.47.38.AM.moviOS: NativeScreen.Recording.2024-08-13.at.5.45.59.AM.moviOS: mWeb SafariScreen.Recording.2024-08-13.at.5.44.39.AM.movMacOS: Chrome / SafariScreen.Recording.2024-08-13.at.5.39.09.AM.movMacOS: DesktopScreen.Recording.2024-08-13.at.5.41.18.AM.mov |
Beamanator
approved these changes
Aug 13, 2024
OSBotify
pushed a commit
that referenced
this pull request
Aug 13, 2024
[CP Staging] fix: Report fields - App crashes when disabling/enabling list values via checkbox & dropdown button. (cherry picked from commit 8cf898d) (CP triggered by Beamanator)
90 tasks
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Cherry-picked to staging by https://github.com/Beamanator in version: 9.0.19-9 🚀
@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes. |
|
Woop woop! @allroundexperts do you mind testing this on latest staging? 🙏 |
github-actions
bot
added
the
DeployBlockerCash
Performance Comparison Report 📊Significant Changes To Duration
Show details
Meaningless Changes To DurationShow entries
Show details
|
|
@Expensify/mobile-deployers 📣 Please look into this performance regression as it's a deploy blocker. |
Beamanator
removed
the
DeployBlockerCash
|
This doesn't look like it's a big enough blocker |
|
working great on staging! |
|
Note: This PR probably hasn't introduced the recession. The regression has been introduced at an earlier point, and the CI system will report any PR that follows this faulty PR as a regression. |
6 tasks
|
Thank you kind sir mister Hanno 🙏 |
|
FYI I believe this was deployed to prod yesterday, from this checklist - #47219 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Regression from #46278
Fixed Issues
$ #47230
PROPOSAL:
Tests
Go to staging.new.expensify.com
Go to workspace settings > Report fields
Click Add field
Select List from Type
Go to List values and add a few list values
Long press on the list value > Select.
Tap on the dropdown.
Tap Disable.
Offline tests
Go to staging.new.expensify.com
Go to workspace settings > Report fields
Click Add field
Select List from Type
Go to List values and add a few list values
Long press on the list value > Select.
Tap on the dropdown.
Tap Disable.
QA Steps
Go to staging.new.expensify.com
Go to workspace settings > Report fields
Click Add field
Select List from Type
Go to List values and add a few list values
Long press on the list value > Select.
Tap on the dropdown.
Tap Disable.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)myBool && <MyComponent />.src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
android_native.mp4
Android: mWeb Chrome
android_chrome.mp4
iOS: Native
ios_native.mp4
iOS: mWeb Safari
ios_safari.mp4
MacOS: Chrome / Safari
web_chrome.mp4
MacOS: Desktop
desktop_app.mp4