-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[No QA] Polish: Update Next Steps Copy to Match Backend #46686
[No QA] Polish: Update Next Steps Copy to Match Backend #46686
Conversation
@eVoloshchak Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Oh weird! I can't quite tell from the picture, is that account submitting to itself? And how is the workspace set up? Let me know the specifics of the setup for reproduction and I can try to fix that up on the backend. Thanks! |
@dangrous - I have a workspace with weekly submit and "Submit and Approve" approval mode. The account is submitting to itself. The bug is not happening when submitting the expense from new dot but happening when submitting it from old dot From new dot: Screen.Recording.2024-08-06.at.6.40.48.PM.movFrom old dot: Screen.Recording.2024-08-06.at.6.35.40.PM.mov |
Hi! I'll try to take a look at this tomorrow and make sure we're sorted! |
I think that copy looks right to me! I still need to look into that blank user bug, I will do that today! |
@eVoloshchak - Friendly reminder for reviewing this 😄 |
Okay fix is in review for the blank user! |
Reviewer Checklist
Screenshots/Videos |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we're good to go - I didn't see any differences between this and what's in the backend, so hopefully we caught everything.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for following up!
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
FYI I believe this was deployed to prod yesterday, from this checklist - #47219 |
cc @mountiny @dangrous @eVoloshchak
Details
This PR is a follow up to #45160 to address this comment: #45160 (comment)
Fixed Issues
$ #44784
Tests
Offline tests
QA Steps
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos