Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2024-08-01] [$500] [Report Next Steps Audit] Simplify the report next steps 4 - App optimistic next steps #44784

Closed
mountiny opened this issue Jul 3, 2024 · 20 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production External Added to denote the issue can be worked on by a contributor Internal Requires API changes or must be handled by Expensify staff NewFeature Something to build that is a new item. Reviewing Has a PR in review Weekly KSv2

Comments

@mountiny
Copy link
Contributor

mountiny commented Jul 3, 2024

Tracking issue

As part of the Update Report Next Steps design doc, implement these new report next steps:

  • optimistic App next steps

by combining a couple of the existing ones. Please refer to the design document for instructions on how to proceed on the PR.

This needs to be implemented once the backend tasks for this project are done, ideally along the same time to minimize the time when the next steps are showing something else optimistically and when the server response comes in

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~012d18ec8c8471d35f
  • Upwork Job ID: 1810833012866730830
  • Last Price Increase: 2024-07-10
  • Automatic offers:
    • rayane-djouah | Contributor | 103059681
Issue OwnerCurrent Issue Owner: @sakluger
@mountiny mountiny added Daily KSv2 Internal Requires API changes or must be handled by Expensify staff NewFeature Something to build that is a new item. labels Jul 3, 2024
@mountiny mountiny self-assigned this Jul 3, 2024
Copy link

melvin-bot bot commented Jul 3, 2024

Triggered auto assignment to @sakluger (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details. Please add this Feature request to a GH project, as outlined in the SO.

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Daily KSv2 labels Jul 3, 2024
@mountiny
Copy link
Contributor Author

Will look for a C+ to handle this one

@mountiny mountiny added the External Added to denote the issue can be worked on by a contributor label Jul 10, 2024
@melvin-bot melvin-bot bot changed the title [Report Next Steps Audit] Simplify the report next steps 4 - App optimistic next steps [$250] [Report Next Steps Audit] Simplify the report next steps 4 - App optimistic next steps Jul 10, 2024
Copy link

melvin-bot bot commented Jul 10, 2024

Job added to Upwork: https://www.upwork.com/jobs/~012d18ec8c8471d35f

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Jul 10, 2024
Copy link

melvin-bot bot commented Jul 10, 2024

Triggered auto assignment to Contributor-plus team member for initial proposal review - @eVoloshchak (External)

@melvin-bot melvin-bot bot added the Daily KSv2 label Jul 10, 2024
@mountiny mountiny changed the title [$250] [Report Next Steps Audit] Simplify the report next steps 4 - App optimistic next steps [$500] [Report Next Steps Audit] Simplify the report next steps 4 - App optimistic next steps Jul 10, 2024
@melvin-bot melvin-bot bot removed the Weekly KSv2 label Jul 10, 2024
@mountiny mountiny removed the Help Wanted Apply this label when an issue is open to proposals by contributors label Jul 10, 2024
Copy link

melvin-bot bot commented Jul 10, 2024

Upwork job price has been updated to $500

@mountiny
Copy link
Contributor Author

Not looking for proposals, going to pick some volunteer from the C+ team

@dukenv0307
Copy link
Contributor

dukenv0307 commented Jul 10, 2024

Seem like someone took this issue on Slack

Copy link

melvin-bot bot commented Jul 10, 2024

📣 @rayane-djouah 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

@rayane-djouah
Copy link
Contributor

The PR has been opened for review 🙂

@mountiny
Copy link
Contributor Author

PR is going to be merged soon, we will have some small follow-ups I think

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Jul 25, 2024
@melvin-bot melvin-bot bot changed the title [$500] [Report Next Steps Audit] Simplify the report next steps 4 - App optimistic next steps [HOLD for payment 2024-08-01] [$500] [Report Next Steps Audit] Simplify the report next steps 4 - App optimistic next steps Jul 25, 2024
Copy link

melvin-bot bot commented Jul 25, 2024

Reviewing label has been removed, please complete the "BugZero Checklist".

@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Jul 25, 2024
Copy link

melvin-bot bot commented Jul 25, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.11-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-08-01. 🎊

For reference, here are some details about the assignees on this issue:

Copy link

melvin-bot bot commented Jul 25, 2024

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

  • [@eVoloshchak / @rayane-djouah] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
  • [@sakluger] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Jul 31, 2024
@sakluger
Copy link
Contributor

sakluger commented Aug 1, 2024

Summarizing payment on this issue:

Contributor: @rayane-djouah $500, paid via Upwork
Contributor+: @eVoloshchak $500, please request on Newdot

@sakluger
Copy link
Contributor

sakluger commented Aug 1, 2024

@eVoloshchak @rayane-djouah do we need to add regression steps for this new feature?

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Daily KSv2 labels Aug 2, 2024
@rayane-djouah
Copy link
Contributor

@eVoloshchak @rayane-djouah do we need to add regression steps for this new feature?

Based on the design doc here, I think @dylanexpensify will update the test cases to match the new format

@dangrous
Copy link
Contributor

dangrous commented Aug 2, 2024

Yep I think that's right!

@dangrous
Copy link
Contributor

dangrous commented Aug 6, 2024

I think since regression tests are being handled elsewhere we're good to issue payment on this one right?

@JmillsExpensify
Copy link

$500 approve for @eVoloshchak

@mountiny
Copy link
Contributor Author

mountiny commented Aug 8, 2024

Yeah I think we can close this one out now that everyone was paid

@mountiny mountiny closed this as completed Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production External Added to denote the issue can be worked on by a contributor Internal Requires API changes or must be handled by Expensify staff NewFeature Something to build that is a new item. Reviewing Has a PR in review Weekly KSv2
Projects
Status: Done
Development

No branches or pull requests

7 participants