[HOLD for payment 2024-06-20] [HOLD for payment 2024-06-18] [$250] mweb-chat-Unable to type in compose box

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.75-0
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4569546
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: applause internal team
Slack conversation:

Action Performed:

1. Go to https://staging.new.expensify.com/
2. Open any report
3. Type random letters in compose

Expected Result:

User must be able to type in compose.

Actual Result:

User unable to type in compose. Compose is not functioning properly.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6489326_1716464220773.Screenrecorder-2024-05-23-17-03-59-903.1.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @adelekennedy

[melvin-bot]

Triggered auto assignment to @amyevans (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

Triggered auto assignment to @adelekennedy (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open Staging deploy checklist to see the list of PRs included in this release, then work quickly on the following:

1. If you find which PR caused the issue/bug, you can reassign it to the person responsible for it.
   • If the author is OOO or won’t get online before the daily deploy is due, you are responsible for finding the best fix/path forward. Don’t hesitate to ask for help!
2. Try to reproduce the issue, if the bug is on production, remove the DeployBlocker label but stay assigned to fix it (or find out which PR broke it to get help from the author).
   • You can adjust the urgency of the issue to better represent the gravity of the bug.
   • If the issue is super low priority, feel free to un-assign yourself.
   • Be careful with PHP warnings, sometimes it is more complex than just adding a null coalescing operator as they might be uncovering some bigger bug.
   • If it was a one-off issue that requires no action (for example, Bedrock was down or it is a duplicated issue), you can close it.

Remember rule #2: Never un-assign yourself from a real DeployBlocker unless you are 100% sure someone else is assigned and will take care of it.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[m-natarajan]

@adelekennedy FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[m-natarajan]

We think that this bug might be related to #vip-vsb

[amyevans]

I'm unable to reproduce:

screen-20240523-120314.mp4

@adelekennedy can you give it a try?

[amyevans]

Removed the DeployBlocker label because it's for sure not a backend issue

[samilabud]

Proposal

Please re-state the problem that we are trying to solve in this issue.

mweb-chat-Unable to type in compose box

What is the root cause of that problem?

It seems the new module "@expensify/react-native-live-markdown" is the root cause, when we pass it through our RNMarkDownTextInput component (markdownStyle={markdownStyle}):

App/src/components/Composer/index.tsx

Lines 324 to 332 in 84290e4

	<RNMarkdownTextInput
	autoComplete="off"
	autoCorrect={!Browser.isMobileSafari()}
	placeholderTextColor={theme.placeholderText}
	ref={(el) => (textInput.current = el)}
	selection={selection}
	style={[inputStyleMemo]}
	markdownStyle={markdownStyle}
	value={value}

What changes do you think we should make in order to solve the problem?

As the @expensify/react-native-live-markdown component is out of our control (externals) I suggest marking it as internal, meanwhile we can use the RNMarkDownTextInput without the new markdown styles, like:

<RNMarkdownTextInput
                autoComplete="off"
                autoCorrect={!Browser.isMobileSafari()}
                placeholderTextColor={theme.placeholderText}
                ref={(el) => (textInput.current = el)}
                selection={selection}
                style={[inputStyleMemo]}
                value={value}
                defaultValue={defaultValue}
                autoFocus={autoFocus}
                /* eslint-disable-next-line react/jsx-props-no-spreading */
                {...props}
                onSelectionChange={addCursorPositionToSelectionChange}
                onContentSizeChange={(e) => {
                    setTextInputWidth(`${e.nativeEvent.contentSize.width}px`);
                    updateIsFullComposerAvailable({maxLines, isComposerFullSize, isDisabled, setIsFullComposerAvailable}, e, styles);
                }}
                disabled={isDisabled}
                onKeyPress={handleKeyPress}
                onFocus={(e) => {
                    ReportActionComposeFocusManager.onComposerFocus(() => {
                        if (!textInput.current) {
                            return;
                        }

                        textInput.current.focus();
                    });

                    props.onFocus?.(e);
                }}
            />

Test before changes:

Screen.Recording.2024-05-23.at.12.19.09.PM.mov

Test after changes:

Screen.Recording.2024-05-23.at.11.55.07.AM.mov

[adelekennedy]

@amyevans I also can't reproduce

[amyevans]

Asked about it in #qa: https://expensify.slack.com/archives/C9YU7BX5M/p1716490376842399

[kavimuru]

@amyevans Reproduced with certain devices only.

• Issue reproducible on: Galaxy S10+ / Andriod 12, Fold 4 / Android 14(repro with samsung keyboard only and not with Gboard), Galaxy S10 / Android 11, Samsung Galaxy A50/Android11, Xiaomi Redmi Note 10S - Android 13
• Not reproducible on Pixel devices

Screen_Recording_20240524_031719_Settings.mp4

az_recorder_20240523_151900.1.mp4

video_2024-05-23_15-14-47.mp4

Not reproducible on Pixel devices

[amyevans]

As the @expensify/react-native-live-markdown component is out of our control (externals)

We do have some control, it's our open source repo 😄

@robertKozik would you be able to help look into this further?

[robertKozik]

Sadly I won't be able to help for now, but I'll pass it to my colleagues which are involved in react-native-live-markdown

[amyevans]

Thanks!

[amyevans]

Some discussion here: https://expensify.slack.com/archives/C06BDSWLDPB/p1716559779115879

[SzymczakJ]

Update: We need to wait for react-native-live-markdown fix to be merged. I've put out a PR with that fix Expensify/react-native-live-markdown#366. When the fix is merged I will reapply changes that Robert Kozik made, that were solving this room mentions issue, as they will no longer cause this "unable to type in compose box" bug. I think you can also assign me to that room mentions issue.

[amyevans]

Okay thanks for the update! Can you comment on that GH, I'm unable to assign otherwise

[SzymczakJ]

Update: we are still waiting to merge this fix in react-native-live-markdown Expensify/react-native-live-markdown#366, I'm pinging react-native-live-markdown team to merge this fix ASAP 😄

[melvin-bot]

@amyevans @mollfpr @adelekennedy @SzymczakJ this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[SzymczakJ]

I think this can be closed, since this bug was fixed with react-native–live-markdown bump and we are now working on #41597

[amyevans]

👍

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.81-11 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] Bump react-native-live-markdown to 0.1.82 #43255

If no regressions arise, payment will be issued on 2024-06-18. 🎊

For reference, here are some details about the assignees on this issue:

• @mollfpr requires payment through NewDot Manual Requests
• @SzymczakJ does not require payment (Contractor)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@mollfpr] The PR that introduced the bug has been identified. Link to the PR:
• [@mollfpr] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@mollfpr] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@mollfpr] Determine if we should create a regression test for this bug.
• [@mollfpr] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@adelekennedy] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.82-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] Bump react-native-live-markdown to 0.1.82 #43255

If no regressions arise, payment will be issued on 2024-06-20. 🎊

For reference, here are some details about the assignees on this issue:

• @mollfpr requires payment through NewDot Manual Requests
• @SzymczakJ does not require payment (Contractor)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@mollfpr] The PR that introduced the bug has been identified. Link to the PR:
• [@mollfpr] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@mollfpr] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@mollfpr] Determine if we should create a regression test for this bug.
• [@mollfpr] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@adelekennedy] Link the GH issue for creating/updating the regression test once above steps have been agreed upon: