[CP Staging] Bump `react-native-live-markdown` to 0.1.82 #43255

BartoszGrajdek · 2024-06-07T10:45:11Z

Details

This PR bumps the version of live markdown

Fixed Issues

$ #41696
$ #39255
$ #42160
$ #17767
$ #14445
$ #15640
$ #41137
$ #41567
$ #42523
$ #41078

Tests

The best course of action would be to go through each of the issues added above and verify if just the changes in react-native-live-markdown were needed to fix them. If so you can test if they are not happening anymore. Here's a list of some of the issues & testing steps:

[HOLD for payment 2024-06-28] [HOLD for payment 2024-06-20][$250] Room-User is allowed to invite via mentions invalid number. #41078
Check if only valid phone number mentions are allowed
[HOLD for payment 2024-06-20] [HOLD for payment 2024-06-18] [$250] mweb-chat-Unable to type in compose box #42523
Check if you are able to type in the composer on android mWeb
[HOLD for payment 2024-06-20] [HOLD for payment 2024-06-18] [$500] IOS - Task - Unable to scroll down task description #41567
Check if you are able to scroll task description input
[HOLD for payment 2024-06-28] [HOLD for payment 2024-06-20] [HOLD for payment 2024-06-18] [$500] mWeb - Chat-Pasting text in compose box makes page moves up and down #41137
Check if pasting on android mWeb
[HOLD for payment 2024-06-20] [HOLD for payment 2024-06-18] [HOLD for payment 2024-06-06] [HOLD #37374][$1000] Text in some languages gets cut off at the bottom in composer on ios #17767
Paste text from issue desc and check if it's displayed properly
[PAID] [HOLD for payment 2024-06-18] [$500] Unable to undo copy and pasted text #39255
Check if you are able to undo copy pasted text
[HOLD for payment 2024-06-20] [HOLD for payment 2024-06-18] Live Markdown treats > space and >nospace equally #41696
Check if markdown is treating >test and > test differently (the second one should be a quote, the first one just plain text)

Offline tests

QA Steps

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

android.mov

Android: mWeb Chrome

mweb.chrome.mov

iOS: Native

ios.mov

iOS: mWeb Safari

mweb.safari.mov

MacOS: Chrome / Safari

web.mov

MacOS: Desktop

desktop.mov

melvin-bot · 2024-06-07T11:32:28Z

@mollfpr Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

BartoszGrajdek · 2024-06-07T11:33:50Z

cc @luacmartins

BartoszGrajdek · 2024-06-07T11:34:05Z

cc @tomekzaw @SzymczakJ

ishpaul777 · 2024-06-07T13:54:34Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

ishpaul777 · 2024-06-07T13:59:42Z

[HOLD] Stop highlighting report mentions in non policy rooms in the Composer #41597

Check if report mentions in non policy rooms are not highlighted- Not fixed

Screen.Recording.2024-06-07.at.7.29.00.PM.mov

tomekzaw · 2024-06-07T14:03:42Z

#43255 (comment)

Actually, this wasn't supposed to be fixed, I think it's in the PR description by mistake. Thanks for pointing this out.

ishpaul777 · 2024-06-07T14:11:38Z

[HOLD for payment 2024-06-28] [HOLD for payment 2024-06-20][$250] Room-User is allowed to invite via mentions invalid number. #41078 Check if only valid phone number mentions are allowed - fixed

Macos Chrome -

Screen.Recording.2024-06-07.at.7.40.30.PM.mov

IOS native -

Screen.Recording.2024-06-07.at.8.29.28.PM.mov

IOS safari -

Screen.Recording.2024-06-07.at.9.00.48.PM.mov

mweb android -

Screen.Recording.2024-06-07.at.9.00.48.PM.mov

Desktop -

Screen.Recording.2024-06-07.at.9.34.43.PM.mov

ishpaul777 · 2024-06-07T14:15:43Z

[HOLD for payment 2024-06-20] [HOLD for payment 2024-06-18] [$250] mweb-chat-Unable to type in compose box #42523 - Check if you are able to type in the composer on android mWeb - fixed

Mweb - android chrome

WhatsApp.Video.2024-06-07.at.7.44.32.PM.mp4

iOS Native

Screen.Recording.2024-06-07.at.8.31.43.PM.mov

ios Safari -

Screen.Recording.2024-06-07.at.8.56.29.PM.mov

Mweb Safari -

WhatsApp.Video.2024-06-07.at.9.08.52.PM.mp4

Desktop -

Screen.Recording.2024-06-07.at.9.31.31.PM.mov

ishpaul777 · 2024-06-07T14:20:32Z

[HOLD for payment 2024-06-28] [HOLD for payment 2024-06-20] [HOLD for payment 2024-06-18] [$500] mWeb - Chat-Pasting text in compose box makes page moves up and down #41137 - Check if pasting on android mWeb - not fixed

WhatsApp.Video.2024-06-07.at.7.49.00.PM.mp4

github-actions · 2024-06-07T14:30:03Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/43255/index.html	https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/43255/index.html

Desktop 💻	Web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/43255/NewExpensify.dmg	https://43255.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

ishpaul777 · 2024-06-07T14:36:55Z

[HOLD for payment 2024-06-20] [HOLD for payment 2024-06-18] [$500] IOS - Task - Unable to scroll down task description #41567 - fixed

Desktop Chrome -

Screen.Recording.2024-06-07.at.8.34.41.PM.mov

IOS Native -

Screen.Recording.2024-06-07.at.8.05.17.PM.mov

IOS Safari -

Screen.Recording.2024-06-07.at.8.54.17.PM.mov

MWEB chrome -

VIDEO-2024-06-07-21-15-46.mp4

Desktop -

Screen.Recording.2024-06-07.at.9.31.31.PM.mov

Android -

WhatsApp.Video.2024-06-07.at.9.47.04.PM.mp4

ishpaul777 · 2024-06-07T14:44:13Z

[HOLD for payment 2024-06-20] [HOLD for payment 2024-06-18] [HOLD for payment 2024-06-06] [HOLD #37374][$1000] Text in some languages gets cut off at the bottom in composer on ios #17767 Paste text from issue desc and check if it's displayed properly - fixed

IOS Native -

Screen.Recording.2024-06-07.at.8.10.39.PM.mov

Chrome Desktop -

Screen.Recording.2024-06-07.at.8.35.49.PM.mov

Mweb safari -

Screen.Recording.2024-06-07.at.8.45.52.PM.mov

Mweb chrome

WhatsApp.Video.2024-06-07.at.9.08.52.PM.mp4

Desktop -

Screen.Recording.2024-06-07.at.9.29.36.PM.mov

Android -

WhatsApp.Video.2024-06-07.at.9.44.32.PM.mp4

ishpaul777 · 2024-06-07T14:49:13Z

[PAID] [HOLD for payment 2024-06-18] [$500] Unable to undo copy and pasted text #39255 - fixed

Chrome -

Screen.Recording.2024-06-07.at.8.17.08.PM.mov

Desktop -

Screen.Recording.2024-06-07.at.9.28.43.PM.mov

Native device cannot be tested.

ishpaul777 · 2024-06-07T14:53:50Z

[HOLD for payment 2024-06-20] [HOLD for payment 2024-06-18] Live Markdown treats > space and >nospace equally #41696 Check if markdown is treating >test and > test differently (the second one should be a quote, the first one just plain text) - fixed

Android Native -

WhatsApp.Video.2024-06-07.at.9.42.04.PM.mp4

Desktop Chrome -

Screen.Recording.2024-06-07.at.8.21.21.PM.mov

IOS native -

Screen.Recording.2024-06-07.at.8.39.12.PM.mov

IOS Mweb safari -

Screen.Recording.2024-06-07.at.8.42.50.PM.mov

Mweb Chrome -

WhatsApp.Video.2024-06-07.at.9.08.22.PM.mp4

Desktop -

Screen.Recording.2024-06-07.at.9.26.19.PM.mov

ishpaul777 · 2024-06-07T14:56:55Z

[HOLD for payment 2024-06-20] Stop highlighting report mentions in non policy rooms in the Composer #41597 ❌
[HOLD for payment 2024-06-28] [HOLD for payment 2024-06-20][$250] Room-User is allowed to invite via mentions invalid number. #41078 ✅
[HOLD for payment 2024-06-20] [HOLD for payment 2024-06-18] [$250] mweb-chat-Unable to type in compose box #42523 ✅
[HOLD for payment 2024-06-20] [HOLD for payment 2024-06-18] [$500] IOS - Task - Unable to scroll down task description #41567 ✅
[HOLD for payment 2024-06-28] [HOLD for payment 2024-06-20] [HOLD for payment 2024-06-18] [$500] mWeb - Chat-Pasting text in compose box makes page moves up and down #41137 ❌
[HOLD for payment 2024-06-20] [HOLD for payment 2024-06-18] [HOLD for payment 2024-06-06] [HOLD #37374][$1000] Text in some languages gets cut off at the bottom in composer on ios #17767 ✅
[PAID] [HOLD for payment 2024-06-18] [$500] Unable to undo copy and pasted text #39255 ✅
[HOLD for payment 2024-06-20] [HOLD for payment 2024-06-18] Live Markdown treats > space and >nospace equally #41696 ✅

luacmartins · 2024-06-07T15:17:27Z

Thanks @ishpaul777. It seems like #41597 shouldn't be fixed in this PR, so I removed it from the OP. As for #41137, that's no longer a blocker, so I think we can merge this and continue to work on a solution for #41137

ishpaul777 · 2024-06-07T15:19:55Z

Ohk! I have tested rest issues on mweb, ios native and chrome desktop will completed the rest videos as we speak.

…live-markdown-bump [CP Staging] Bump `react-native-live-markdown` to 0.1.82 (cherry picked from commit e8f8189)

OSBotify · 2024-06-07T16:28:22Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-06-07T16:57:44Z

🚀 Cherry-picked to staging by https://github.com/luacmartins in version: 1.4.80-14 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

kavimuru · 2024-06-07T22:07:42Z

Live Markdown treats > space and >nospace equally Not fixed and Failing in mweb , desktop and native apps

https://platform.utest.com/services/links/v1/internal/51620598?.mp4
https://platform.applause.com/services/links/v1/external/f916461c07391fd466e658254fcfb563574b41b84e21b539481ccd655dfeb380
https://platform.utest.com/services/links/v1/internal/51620643?.mp4
https://platform.applause.com/services/links/v1/external/78183abdc52fcd999d20dbe7c331e946b519afcab806a6d18b0b8f384b5def44

[$500] Unable to undo copy and pasted text - not fixed and failing in web

https://platform.applause.com/services/links/v1/external/c0c9dbe667126f8e96131d8f41281532421f41efd3242c21a9ff54f5bf240040

Found a blocker Chat - Emoji gets inserted in front of entered text when validating ([HOLD for payment 2024-06-20] [HOLD for payment 2024-06-18] [HOLD for payment 2024-06-10] [HOLD on #4114/#17767] [$500] iOS - Chat - When moving to another line, the word and emoji are close to each other. #14445)
mWeb - Chat-Pasting text in compose box makes page moves up and down not fixed and failing in mweb https://platform.utest.com/services/links/v1/internal/51618911?.mp4
App crashes after pressing R in metro bundler on iOS simulator can't be retested in staging

fabOnReact · 2024-06-10T07:02:51Z

Expensify Composer (When moving to another line, the word and emoji are close to each other):

All tests for Issue #14445 are successfull.

The difference of baseline is 1.15 (barely noticeable), maximumLineHeight 20, maximumFontLineHeight 17.69

Before	After

Before	After

The result below is achieved after setting textInputCompose.lineHeight: 40.

baseLineOffset is 11.15
maximumLineHeight is 40
maximumFontLineHeight is 17.69

Before	After

Before	After

Before	After

Issue #14445 requires also Meta team to merge PR facebook/react-native#44614.

OSBotify · 2024-06-11T23:36:28Z

🚀 Deployed to production by https://github.com/luacmartins in version: 1.4.81-11 🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

feat: bump react-native-live-markdown

7303041

BartoszGrajdek marked this pull request as ready for review June 7, 2024 11:32

BartoszGrajdek requested a review from a team as a code owner June 7, 2024 11:32

melvin-bot bot requested review from mollfpr and removed request for a team June 7, 2024 11:32

BartoszGrajdek mentioned this pull request Jun 7, 2024

[HOLD for payment 2024-06-21] [$250] mWeb - Chat - Quote markdown is not applied #43180

Closed

6 tasks

SzymczakJ mentioned this pull request Jun 7, 2024

[HOLD for payment 2024-06-20] Stop highlighting report mentions in non policy rooms in the Composer #41597

Closed

luacmartins approved these changes Jun 7, 2024

View reviewed changes

luacmartins requested a review from ishpaul777 June 7, 2024 13:44

hungvu193 mentioned this pull request Jun 7, 2024

[HOLD for payment 2024-06-20] [HOLD for payment 2024-06-18] [$500] IOS - Task - Unable to scroll down task description #41567

Closed

6 tasks

luacmartins changed the title ~~Bump react-native-live-markdown to 0.1.82~~ [CP Staging] Bump react-native-live-markdown to 0.1.82 Jun 7, 2024

luacmartins removed the request for review from mollfpr June 7, 2024 13:46

luacmartins added the Ready To Build label Jun 7, 2024

ishpaul777 approved these changes Jun 7, 2024

View reviewed changes

melvin-bot bot requested a review from blimpich June 7, 2024 16:12

luacmartins merged commit e8f8189 into Expensify:main Jun 7, 2024
23 of 24 checks passed

OSBotify pushed a commit that referenced this pull request Jun 7, 2024

Merge pull request #43255 from software-mansion-labs/@BartoszGrajdek/…

f6fdedd

…live-markdown-bump [CP Staging] Bump `react-native-live-markdown` to 0.1.82 (cherry picked from commit e8f8189)

github-actions bot mentioned this pull request Jun 7, 2024

Deploy Checklist: New Expensify 2024-06-06 #43168

Closed

luacmartins mentioned this pull request Jun 7, 2024

[HOLD for payment 2024-06-20] [HOLD for payment 2024-06-18] [$500] Chat - Emoji gets inserted in front of entered text #43312

Closed

6 tasks

mountiny mentioned this pull request Jun 20, 2024

[Awaiting checklist] [$250] Edit comment - Remaining text in the composer is highlighted after deleting text #43332

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[CP Staging] Bump `react-native-live-markdown` to 0.1.82 #43255

[CP Staging] Bump `react-native-live-markdown` to 0.1.82 #43255

BartoszGrajdek commented Jun 7, 2024 •

edited by luacmartins

Loading

melvin-bot bot commented Jun 7, 2024

BartoszGrajdek commented Jun 7, 2024

BartoszGrajdek commented Jun 7, 2024

ishpaul777 commented Jun 7, 2024 •

edited

Loading

ishpaul777 commented Jun 7, 2024

tomekzaw commented Jun 7, 2024

ishpaul777 commented Jun 7, 2024 •

edited

Loading

ishpaul777 commented Jun 7, 2024 •

edited

Loading

ishpaul777 commented Jun 7, 2024 •

edited

Loading

github-actions bot commented Jun 7, 2024

ishpaul777 commented Jun 7, 2024 •

edited

Loading

ishpaul777 commented Jun 7, 2024 •

edited

Loading

ishpaul777 commented Jun 7, 2024 •

edited

Loading

ishpaul777 commented Jun 7, 2024 •

edited

Loading

ishpaul777 commented Jun 7, 2024

luacmartins commented Jun 7, 2024

ishpaul777 commented Jun 7, 2024

OSBotify commented Jun 7, 2024

OSBotify commented Jun 7, 2024

kavimuru commented Jun 7, 2024 •

edited

Loading

fabOnReact commented Jun 10, 2024

OSBotify commented Jun 11, 2024

[CP Staging] Bump react-native-live-markdown to 0.1.82 #43255

[CP Staging] Bump react-native-live-markdown to 0.1.82 #43255

Conversation

BartoszGrajdek commented Jun 7, 2024 • edited by luacmartins Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Jun 7, 2024

BartoszGrajdek commented Jun 7, 2024

BartoszGrajdek commented Jun 7, 2024

ishpaul777 commented Jun 7, 2024 • edited Loading

Reviewer Checklist

Screenshots/Videos

ishpaul777 commented Jun 7, 2024

tomekzaw commented Jun 7, 2024

ishpaul777 commented Jun 7, 2024 • edited Loading

ishpaul777 commented Jun 7, 2024 • edited Loading

ishpaul777 commented Jun 7, 2024 • edited Loading

github-actions bot commented Jun 7, 2024

ishpaul777 commented Jun 7, 2024 • edited Loading

ishpaul777 commented Jun 7, 2024 • edited Loading

ishpaul777 commented Jun 7, 2024 • edited Loading

ishpaul777 commented Jun 7, 2024 • edited Loading

ishpaul777 commented Jun 7, 2024

luacmartins commented Jun 7, 2024

ishpaul777 commented Jun 7, 2024

OSBotify commented Jun 7, 2024

OSBotify commented Jun 7, 2024

kavimuru commented Jun 7, 2024 • edited Loading

fabOnReact commented Jun 10, 2024

Expensify Composer (When moving to another line, the word and emoji are close to each other):

OSBotify commented Jun 11, 2024

[CP Staging] Bump `react-native-live-markdown` to 0.1.82 #43255

[CP Staging] Bump `react-native-live-markdown` to 0.1.82 #43255

BartoszGrajdek commented Jun 7, 2024 •

edited by luacmartins

Loading

ishpaul777 commented Jun 7, 2024 •

edited

Loading

ishpaul777 commented Jun 7, 2024 •

edited

Loading

ishpaul777 commented Jun 7, 2024 •

edited

Loading

ishpaul777 commented Jun 7, 2024 •

edited

Loading

ishpaul777 commented Jun 7, 2024 •

edited

Loading

ishpaul777 commented Jun 7, 2024 •

edited

Loading

ishpaul777 commented Jun 7, 2024 •

edited

Loading

ishpaul777 commented Jun 7, 2024 •

edited

Loading

kavimuru commented Jun 7, 2024 •

edited

Loading