-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HOLD for payment 2024-07-22] [$250] Categorizing- Workspace chat under To field opens not here page when new WS is not created yet #42552
Comments
Triggered auto assignment to @mallenexpensify ( |
@mallenexpensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors |
We think that this bug might be related to #vip-vsp |
ProposalPlease re-state the problem that we are trying to solve in this issue.Categorizing a workspace chat under the "To" field opens the "Not Here" page when a new workspace has not yet been created What is the root cause of that problem?When a new workspace is created, only a draft workspace and draft report are generated. Clicking on the "To" field navigates the app to the report detail page. However, since the report field is undefined at this point (as we have only just created a draft report), this leads to the occurrence of the bug. What changes do you think we should make in order to solve the problem?In the ReportDetailPage, we're utilizing "withReportOrNotFound". Within "withReportOrNotFound", we also need to retrieve the draft report and use it as alternative value when the report is undefined What alternative solutions did you explore? (Optional)In the ReportDetailPage, we should acquire both the report and draft report within "withOnyx" and no longer rely on the "withReportOrNotFound" hook. Subsequently, we can verify if the report is undefined, we will utilize the draft report as an alternative value. |
ProposalPlease re-state the problem that we are trying to solve in this issue.Categorizing- Workspace chat under To field opens not here page when new WS is not created yet What is the root cause of that problem?We don't disable What changes do you think we should make in order to solve the problem?We can use
To: isDisabled:
!participant.isInvoiceRoom &&
(!participant.isPolicyExpenseChat || ReportUtils.isDraftReport(participant.reportID)) &&
!participant.isSelfDM &&
ReportUtils.isOptimisticPersonalDetail(participant.accountID ?? -1), What alternative solutions did you explore? (Optional) |
Job added to Upwork: https://www.upwork.com/jobs/~01c1df32a642cf9a1e |
Triggered auto assignment to Contributor-plus team member for initial proposal review - @rojiphil ( |
Was able to reproduce. Seems like it could be external. @rojiphil , if you agree, can you review the proposals above? Thx 2024-05-24_14-27-06.mp4 |
ProposalPlease re-state the problem that we are trying to solve in this issue.The workspace chat is clickable and leads to not here page What is the root cause of that problem?When the report is a draft report, it's not created yet so when we navigate to the If we look at this, we'll see that the option will be disabled if the participant account is optimistic ( We need to do the same for the draft workspace, if it's a draft workspace then the option should be disabled, because there's no workspace/workspace chat yet. It's just a draft. What changes do you think we should make in order to solve the problem?In here, create a method to check if the participant should be disabled. If the report is a draft report, early return
Then update this to
One improvement we can make it, when the user hovers on an inaccessible draft report, show a tooltip saying something like "This workspace chat will be created after you submit the expense". There was also a suggestion here that "please do not make it look disabled, because it's not a disabled UI component, its just read-only text". To do this, we need to add the There was a proposal above to make What alternative solutions did you explore? (Optional)For the An alternative to the |
@mallenexpensify @Expensify/Design |
Would love some more thoughts because I wasn't as involved in these convos, but I think you're right about this. To me it seems like we should have already created the workspace by the time they get to the confirmation screen—so clicking on that row would behave just like any other existing workspace. @shawnborton does that sound like where the Slack convos landed? |
Not entirely sure, but I kind of think we wouldn't create the workspace until the expense is successfully sent there? I don't feel strongly though. If we do opt for something like that, then I agree, I would just make that workspace row not pressable/hoverable (but please do not make it look disabled, because it's not a disabled UI component, its just read-only text) |
Ok yeah that also makes sense to me—because if you back out of this flow then you'd just have a randomly created workspace lingering around.
BIG agree with this. 💯 |
Proposal updated to address this concern
|
That feels right to me as well |
Thanks for confirming the expected behaviour here. @tienifr proposal LGTM as the proposal not only solves the problem but also addresses the need of not looking like disabled. However, the final UI changes also require the involvement of the design team but this can be taken up in the PR stage. |
Triggered auto assignment to @hayata-suenaga, see https://stackoverflow.com/c/expensify/questions/7972 for more details. |
📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸 |
Yes. Will review today. |
@rojiphil, @mallenexpensify, @hayata-suenaga, @tienifr Eep! 4 days overdue now. Issues have feelings too... |
@rojiphil, @mallenexpensify, @hayata-suenaga, @tienifr 6 days overdue. This is scarier than being forced to listen to Vogon poetry! |
PR reached production yesterday. |
@rojiphil, @mallenexpensify, @hayata-suenaga, @tienifr Now this issue is 8 days overdue. Are you sure this should be a Daily? Feel free to change it! |
Melvin, The PR is on production now |
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.6-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2024-07-22. 🎊 For reference, here are some details about the assignees on this issue:
|
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
|
Test Steps |
@rojiphil, @mallenexpensify, @hayata-suenaga, @tienifr Uh oh! This issue is overdue by 2 days. Don't forget to update your issues! |
Contributor: @tienifr due $250 via NewDot @rojiphil , can you please accept the job and reply here once you have? Test Case |
@mallenexpensify Offer accepted. Thanks |
@rojiphil, @mallenexpensify, @hayata-suenaga, @tienifr Whoops! This issue is 2 days overdue. Let's get this updated quick! |
@rojiphil paid! Updated payment comment above. |
$250 approved for @tienifr |
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 1.4.75-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team
Action Performed:
Expected Result:
Since the workspace chat is not created yet, the workspace chat should be disabled (not clickable)
Actual Result:
The workspace chat is clickable and leads to not here page
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
Add any screenshot/video evidence
Bug6489712_1716487367715.bandicam_2024-05-24_01-58-01-499.mp4
View all open jobs on GitHub
Upwork Automation - Do Not Edit
Issue Owner
Current Issue Owner: @mallenexpensifyThe text was updated successfully, but these errors were encountered: